On 2026-11-04 17:02 +03:00, Pascal Hambourg wrote: > On 18/10/2026 at 19:16, Holger Wansing wrote: >> >> There are also three merge requests related to depthcharge images/chrome OS >> machines [1][2][3]. >> >> [1] >> https://salsa.debian.org/installer-team/debian-installer/-/merge_requests/81 > > I have objections about the two partman-cros MRs. > >> [2] https://salsa.debian.org/installer-team/partman-cros/-/merge_requests/3 > > All other automatic partitioning recipes are gathered in partman-auto > and recipes for current architectures are built by a script for easier > maintenance and better consistency. Introducing recipes in another > package would make maintenance more difficult.
I agree. I think I had a libdebian-installer MR that would add amd64/cros and arm64/cros to archdetect, which partman-auto would want? > Regarding the recipes themselves, > - Do any ChromeOS machines require unpartitioned reserved space for the > boot loader ? Nope. > - Is it normal that the ChromeOS partition is duplicated ? Yes, we can do A/B booting if we have 2+ partitions. Modern boards can boot images up to 512 MiB, so I've been recommending two 512 MiB partitions. (My 7.2.11+deb14-arm64 test system with a MODULES=most initramfs has a ~227 MiB depthcharge image for reference) Also, the bootloader can only boot from GPT, and we don't need a /boot partition even if rootfs is encrypted (but it doesn't hurt). >> [3] https://salsa.debian.org/installer-team/partman-cros/-/merge_requests/2 > > Never clearing the flag seems a bit extreme. What about using the same > logic as in partman-efi to preserve unused existing ESPs instead ? I'm not sure the analysis is correct there, I have to test things again. I remember installing to a USB disk without messing up ChromeOS on the eMMC. Maybe they chose "Do not use" on existing partitions expecting it to be like the ESP case? IIRC I thought it makes no sense to mark a CrOS partition as "Do not use" except to indicate it should stop being one. One difference with ESPs is that we don't choose which partition will be used here. depthcharge-tools(-installer) will look at the disks that hold /boot and rootfs (as they are the only disks we can assume will be present during boot) and rotate between them itself. AIUI we choose one ESP partition during partitioning by marking others "Do not use", otherwise the first pre-existing ESP can be used regardless of if it is on a different drive than the rootfs (which I don't like vs. my approach). At least unused ESPs can show up as mere fat32 partitions, but with CrOS partitions having no filesystem we would lose all indication that they are and will continue to be CrOS partitions.

