Your message dated Mon, 26 Mar 2007 05:47:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#407890: fixed in torcs 1.2.4-3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: torcs
Version: 1.2.4-2
Tags: patch
The torcs XML writing code does not check for invalid characters when
saving preferences.xml, although entities (<, >, &) are
properly parsed when reading the file. If these charactes are used
for controls, torcs crashes due to problems parsing the XML.
Please find attached a patch which addresses this issue, generated in
response to a bug reported to Ubuntu
(https://bugs.launchpad.net/ubuntu/+source/torcs/+bug/4736).
--
Emmet HIKORY
--- src/libs/tgf/params.cpp.orig 2007-01-22 16:43:35.000000000 +0900
+++ src/libs/tgf/params.cpp 2007-01-22 16:45:52.000000000 +0900
@@ -31,6 +31,7 @@
#include <unistd.h>
#endif
#include <math.h>
+#include <string.h>
#include <xmlparse.h>
#ifdef WIN32
@@ -1179,7 +1180,18 @@
}
s += sprintf (s, "\"");
}
- sprintf (s, " val=\"%s\"/>\n", curParam->value);
+ if (! strcmp(curParam->value,"<")) {
+ sprintf (s, " val=\"<\"/>\n");
+ }
+ else if (! strcmp(curParam->value,">")) {
+ sprintf (s, " val=\">\"/>\n");
+ }
+ else if (! strcmp(curParam->value,"&")) {
+ sprintf (s, " val=\"&\"/>\n");
+ }
+ else {
+ sprintf (s, " val=\"%s\"/>\n", curParam->value);
+ }
outCtrl->curParam = GF_TAILQ_NEXT (curParam, linkParam);
return 1;
--- End Message ---
--- Begin Message ---
Source: torcs
Source-Version: 1.2.4-3
We believe that the bug you reported is fixed in the latest version of
torcs, which is due to be installed in the Debian FTP archive:
torcs_1.2.4-3.diff.gz
to pool/main/t/torcs/torcs_1.2.4-3.diff.gz
torcs_1.2.4-3.dsc
to pool/main/t/torcs/torcs_1.2.4-3.dsc
torcs_1.2.4-3_i386.deb
to pool/main/t/torcs/torcs_1.2.4-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Rudy Godoy <[EMAIL PROTECTED]> (supplier of updated torcs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 25 Mar 2007 23:25:05 -0500
Source: torcs
Binary: torcs
Architecture: source i386
Version: 1.2.4-3
Distribution: unstable
Urgency: low
Maintainer: Rudy Godoy <[EMAIL PROTECTED]>
Changed-By: Rudy Godoy <[EMAIL PROTECTED]>
Description:
torcs - 3D racing cars simulator game using OpenGL
Closes: 407890 412347
Changes:
torcs (1.2.4-3) unstable; urgency=low
.
* Applied patch for XML entity. Thanks Emmet Hikory (Closes: #407890)
* Switched maintainer email address.
* Bumped Standards version, no changes needed.
* Backported patch from 1.3 to fix saving screenshots on
$HOME/.torcs/screenshots/ directory. (Closes: #412347)
Files:
e70902743d6782902c78ae6ac14d0acf 940 games optional torcs_1.2.4-3.dsc
f9c770cf58dfa80d222afd5e42ffbbdb 9371 games optional torcs_1.2.4-3.diff.gz
42730256b74e8018269e8d54a0f963f4 4525578 games optional torcs_1.2.4-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGB1MVVQ8aADQzvSERApEIAKCuJDxvA55P0bG8/5cpaNw5hHMR6ACgugdl
1Ad8vGJBlwLuYQOhPEXcBlg=
=jhTT
-----END PGP SIGNATURE-----
--- End Message ---
