Your message dated Mon, 21 Apr 2008 17:03:41 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Re: Bug#407240: git-core: git-log should not open pager when 
it fails
has caused the Debian Bug report #407240,
regarding git log -h hides error message with pager
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
407240: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=407240
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: git-core
Version: 1:1.5.3.2-1
Severity: minor

git log paginates its output, even when its output is empty due to it
being run with an invalid option. I suspect it was written by someone
who uses PAGER=more, since more doesn't paginate empty input and thus
this problem is masked.

So if PAGER=less, git log -h has the worst behavior I've seen a program
exhibit with -h: Rather than displaying help, it displays an empty pager.
Quit out of the pager and you can finally see what the command is
complaining about, namely that there's no short form of --help for this
program.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages git-core depends on:
ii  cpio                    2.9-3            GNU cpio -- a program to manage ar
ii  libc6                   2.6.1-5          GNU C Library: Shared libraries
ii  libcurl3-gnutls         7.17.0-1         Multi-protocol file transfer libra
ii  libdigest-sha1-perl     2.11-2           NIST SHA-1 message digest algorith
ii  liberror-perl           0.15-8           Perl module for error/exception ha
ii  libexpat1               1.95.8-4         XML parsing C library - runtime li
ii  perl-modules            5.8.8-11         Core Perl modules
ii  zlib1g                  1:1.2.3.3.dfsg-5 compression library - runtime

Versions of packages git-core recommends:
ii  curl                          7.17.0-1   Get a file from an HTTP, HTTPS or 
pn  git-doc                       <none>     (no description available)
ii  less                          406-0      Pager program similar to more
ii  openssh-client [ssh-client]   1:4.6p1-5  secure shell client, an rlogin/rsh
ii  patch                         2.5.9-4    Apply a diff file to an original
ii  rsync                         2.6.9-5    fast remote file copy program (lik

-- no debconf information

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Version: 1:1.5.5-1

On Wed, Feb 28, 2007 at 11:00:30AM +0000, Gerrit Pape wrote:
> On Mon, Feb 05, 2007 at 04:37:09AM -0800, Josh Triplett wrote:
> > Why not just avoid starting the pager if an error (such as an invalid
> > argument) occurs?
> 
> Unfortunately it's not that easy.  By current design, the pager is
> started before the error is detected, and it's not trivial to change it.
> 
> But current design also hides the return code of git-log in such cases,
> by using the reutrn code of the pager, so it definitly should be
> improved.

Hi, upstream now changed 'git log' to print error messages to stdout, so
that they appear inside the pager, if the pager is a different program
than less, or LESS is set in the environment.

Regards, Gerrit.


--- End Message ---

Reply via email to