Your message dated Fri, 01 May 2009 22:02:04 +0000
with message-id <[email protected]>
and subject line Bug#526497: fixed in kernel-package 12.013
has caused the Debian Bug report #526497,
regarding kernel-package: typo in header_postinst.d/link example
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
526497: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526497
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: kernel-package
Version: 12.012
Severity: normal
Tags: patch

Hi!

The provided example for header_postinst.d/link is not correct.

a)

The test in line 52 is faulty:

+ '[' '!' -s asm-x86 ']'
+ '[' -e asm ']'
+ '[' /home/oweh -l asm ']'
/etc/kernel/header_postinst.d/link: line 52: [: -l: binary operator expected

The code in this line is

  if [ ~ -l 'asm' ]; then

but I think this should be

  if [ ! -L 'asm' ]; then

because the scripts needs to check if 'asm' is _not_ a symlink, whereas '-l'
tests something not even specified inside the man-page of bash or test (i.e.
I have no idea what '-l' tests)

b)

The test to set the correct architecture is incorrect for i386/amd64, as both
got merged around 2.6.24, thus the check should be "amd64|i386)" instead of just
"amd64)".

I am attaching a patch which fixes both minor problems.

Grüße,
Sven.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.29.1-337 (SMP w/4 CPU cores; PREEMPT)
Locale: lang=de...@euro, lc_ctype=de...@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages kernel-package depends on:
ii  binutils                      2.19.1-1   The GNU assembler, linker and bina
ii  build-essential               11.4       Informational list of build-essent
ii  debianutils                   3.0.1      Miscellaneous utilities specific t
ii  file                          5.00-1     Determines file type using "magic"
ii  gettext                       0.17-6     GNU Internationalization utilities
ii  make                          3.81-5     The GNU version of the "make" util
ii  module-init-tools             3.7-pre9-1 tools for managing Linux kernel mo
ii  po-debconf                    1.0.16     tool for managing templates file t
ii  util-linux                    2.13.1.1-1 Miscellaneous system utilities

kernel-package recommends no packages.

Versions of packages kernel-package suggests:
ii  bzip2                     1.0.5-1        high-quality block-sorting file co
pn  docbook-utils             <none>         (no description available)
ii  e2fsprogs                 1.41.5-1       ext2/ext3/ext4 file system utiliti
ii  initramfs-tools [linux-in 0.93.2         tools for generating an initramfs
pn  libdb3-dev                <none>         (no description available)
ii  libncurses5-dev [libncurs 5.7+20090411-1 developer's libraries and docs for
ii  linux-source-2.6.29-335 [ skuld.335      Linux kernel source for version 2.
ii  linux-source-2.6.29-336 [ skuld.336      Linux kernel source for version 2.
ii  linux-source-2.6.29.1-337 skuld.337      Linux kernel source for version 2.
ii  linux-source-2.6.29.2-339 skuld.339      Linux kernel source for version 2.
pn  xmlto                     <none>         (no description available)

-- no debconf information
--- /usr/share/kernel-package/examples/etc/kernel/header_postinst.d/link        
2009-04-13 00:18:18.000000000 +0200
+++ /etc/kernel/header_postinst.d/link  2009-05-01 17:26:43.000000000 +0200
@@ -23,7 +23,7 @@
     mipsel)
         architecture='mips'
         ;;
-    amd64)
+    amd64|i386)
         architecture='x86'
         ;;
     *)
@@ -49,7 +49,7 @@
     if [ ! -s "asm-$architecture" ]; then
         echo >&2 "/usr/src/linux-headers-$version/include/asm-$architecture 
does not exist"
     elif [ -e 'asm' ]; then
-        if [ ~ -l 'asm' ]; then
+        if [ ! -L 'asm' ]; then
             echo >&2 "/usr/src/linux-headers-$version/include/asm is not a 
symbolic link"
         else
             rm -f asm

--- End Message ---
--- Begin Message ---
Source: kernel-package
Source-Version: 12.013

We believe that the bug you reported is fixed in the latest version of
kernel-package, which is due to be installed in the Debian FTP archive:

kernel-package_12.013.dsc
  to pool/main/k/kernel-package/kernel-package_12.013.dsc
kernel-package_12.013.tar.gz
  to pool/main/k/kernel-package/kernel-package_12.013.tar.gz
kernel-package_12.013_all.deb
  to pool/main/k/kernel-package/kernel-package_12.013_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Manoj Srivastava <[email protected]> (supplier of updated kernel-package 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 01 May 2009 16:18:48 -0500
Source: kernel-package
Binary: kernel-package
Architecture: source all
Version: 12.013
Distribution: unstable
Urgency: low
Maintainer: Manoj Srivastava <[email protected]>
Changed-By: Manoj Srivastava <[email protected]>
Description: 
 kernel-package - A utility for building Linux kernel related Debian packages.
Closes: 526497
Changes: 
 kernel-package (12.013) unstable; urgency=low
 .
   * [873e67d]: Fix typo in header_postinst.d/link example
     The first change is an simple typo fix, ~ --> ! Next, the test to set
     the correct architecture is incorrect for i386/amd64, as both got
     merged around 2.6.24, thus the check should be "amd64|i386)" instead
     of just "amd64)".
     Bug fix: "typo in header_postinst.d/link example", thanks to Sven
     Hartge                                               (Closes: #526497).
   * [22a0d94]: Added more example files for /etc/kernel
     This commit adds a set of example script that wll automatically handle
     /lib/mocules/$VERSION/build -- setting it to point to the kernel
     headers files when either the kernel image or the kernel header
     packages are installed, and cleaning the link up when either of these
     packages are removed.
   * [04ba4c1]: Make sure that initramfs hook script are safe
     This means they will not error out if the corresponding initramfs
     generator is not installed. This way, people may install both the
     initramfs and yaird hook scripts, and they will only trigger if the
     generator is actually installed.
Checksums-Sha1: 
 ecb1cacec5d9bee7103ad73a9f89afceffd51c8e 900 kernel-package_12.013.dsc
 26eaf1bedb085099cfdda6885051ae83466fedf6 571740 kernel-package_12.013.tar.gz
 9e17168e14f616f86aed90509c6d5b2b8d96c0fb 525446 kernel-package_12.013_all.deb
Checksums-Sha256: 
 388550a3d6d1b50ac9d2411adf98d74a2a253569d0085dd6ce9967f8412babc7 900 
kernel-package_12.013.dsc
 bf189ffcfe6d58ba3bbc2389712ce9a76505f92ac81a2d508c53342f8c59303d 571740 
kernel-package_12.013.tar.gz
 0643f6e6508ecabf16f69cd8a874788871e9898fead490ac0b67abbb41d2beae 525446 
kernel-package_12.013_all.deb
Files: 
 b39411b82eccb34afdda0efee2525dc8 900 kernel optional kernel-package_12.013.dsc
 0e9ad9cdf69b3b5863eab6b3f99f15a8 571740 kernel optional 
kernel-package_12.013.tar.gz
 f09295a9f73a1af60f6e7282afb34389 525446 kernel optional 
kernel-package_12.013_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkn7bNkACgkQIbrau78kQky4eACgt4lvQJgwlv01mVawQKHnsyzB
xUIAnjmL507KnSYlnC2OALvnl65/4xPZ
=T4q/
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to