Your message dated Wed, 03 Jun 2009 15:33:15 +0000
with message-id <[email protected]>
and subject line Bug#528364: fixed in libmail-box-perl 2.090-1
has caused the Debian Bug report #528364,
regarding POSIX locker fails to detect existing lock
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
528364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528364
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libmail-box-perl
Version: 2.089-1
Severity: important
Tags: patch

Mail::Box::Locker::POSIX contains two errors, so that is it unable to detect an
existing lock.

1. fnctl returns the string "0 but true" on success and an undefined value
   on failure. The current code in sub _try_lock

   $? = fcntl($file, F_SETLK, pack('s @256', F_WRLCK)) || 0;
   $?==0;

means that the subroutine returns true regardless of the outcome of the fcntl
syscall.

2. In subroutine lock, the variable $? is compared to EAGAIN.  However, it is
   the variable $! that contains the errno.

A Patch is appended.

 Rainer Schöpf

------------------------------------------------------------------
*** /usr/share/perl5/Mail/Box/Locker/POSIX.pm.orig      2009-05-12 
14:26:12.548526088 +0200
--- /usr/share/perl5/Mail/Box/Locker/POSIX.pm   2009-05-12 14:30:24.292905561 
+0200
***************
*** 26,32 ****
  
  sub _try_lock($)
  {   my ($self, $file) = @_;
!     $? = fcntl($file, F_SETLK, pack('s @256', F_WRLCK)) || 0;
      $?==0;
  }
  
--- 26,32 ----
  
  sub _try_lock($)
  {   my ($self, $file) = @_;
!     $? = fcntl($file, F_SETLK, pack('s @256', F_WRLCK)) || (0 + $!);
      $?==0;
  }
  
***************
*** 66,72 ****
              return 1;
          }
  
!         if($? != EAGAIN)
          {   $self->log(ERROR =>
              "Will never get a POSIX lock on $filename for 
$self->{MBL_folder}: $!");
              last;
--- 66,72 ----
              return 1;
          }
  
!         if($! != EAGAIN)
          {   $self->log(ERROR =>
              "Will never get a POSIX lock on $filename for 
$self->{MBL_folder}: $!");
              last;
------------------------------------------------------------------

-- System Information:
Debian Release: squeeze/sid
  APT prefers oldstable
  APT policy: (500, 'oldstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libmail-box-perl depends on:
ii  libdigest-hmac-perl          1.01-7      create standard message integrity 
ii  libfile-remove-perl          1.42-1      remove files and directories, acce
ii  libio-stringy-perl           2.110-4     Perl modules for IO from scalars a
ii  libmailtools-perl            2.04-1      Manipulate email in perl programs
ii  libmime-types-perl           1.27-1      Perl extension for determining MIM
ii  libobject-realize-later-perl 0.18-1      Delayed creation of objects
ii  libtimedate-perl             1.1600-9    Time and date functions for Perl
ii  liburi-perl                  1.37+dfsg-1 Manipulates and accesses URI strin
ii  libuser-identity-perl        0.92-2      manages different identities/roles
ii  perl                         5.10.0-19   Larry Wall's Practical Extraction 

libmail-box-perl recommends no packages.

Versions of packages libmail-box-perl suggests:
ii  libhtml-format-perl           2.04-2     format HTML syntax trees into text
ii  libhtml-tree-perl             3.23-1     represent and create HTML syntax t
pn  libmail-imapclient-perl       <none>     (no description available)
ii  libmime-tools-perl            5.427-2    Perl5 modules for MIME-compliant m
ii  spamassassin                  3.2.5-4    Perl-based spam filter using text 

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: libmail-box-perl
Source-Version: 2.090-1

We believe that the bug you reported is fixed in the latest version of
libmail-box-perl, which is due to be installed in the Debian FTP archive:

libmail-box-perl_2.090-1.diff.gz
  to pool/main/libm/libmail-box-perl/libmail-box-perl_2.090-1.diff.gz
libmail-box-perl_2.090-1.dsc
  to pool/main/libm/libmail-box-perl/libmail-box-perl_2.090-1.dsc
libmail-box-perl_2.090-1_all.deb
  to pool/main/libm/libmail-box-perl/libmail-box-perl_2.090-1_all.deb
libmail-box-perl_2.090.orig.tar.gz
  to pool/main/libm/libmail-box-perl/libmail-box-perl_2.090.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ryan Niebur <[email protected]> (supplier of updated libmail-box-perl 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 03 Jun 2009 00:24:44 -0700
Source: libmail-box-perl
Binary: libmail-box-perl
Architecture: source all
Version: 2.090-1
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Ryan Niebur <[email protected]>
Description: 
 libmail-box-perl - message-folder management module
Closes: 528364
Changes: 
 libmail-box-perl (2.090-1) unstable; urgency=low
 .
   * New upstream release (closes: #528364)
   * Add myself to Uploaders
   * refresh patches
Checksums-Sha1: 
 f2227e7e9765fbd8a7ffae1cd99b11f8e8d962ea 1908 libmail-box-perl_2.090-1.dsc
 119f012bbd26fe6577a0188cae1e71ba9442b93b 607184 
libmail-box-perl_2.090.orig.tar.gz
 55f7a62efa852a7065d53663747acd6d31ea8563 6465 libmail-box-perl_2.090-1.diff.gz
 fd3bc8bef37b321fff676078574309d7a0895a1f 1079502 
libmail-box-perl_2.090-1_all.deb
Checksums-Sha256: 
 5f455ea21d80d2d6d8892fd81c3a1097d87bd82c98ac1367a0609accda9758bd 1908 
libmail-box-perl_2.090-1.dsc
 2001edc66068c49303b15a910a57563539a8faf20b559daa42acd82e2d6e67da 607184 
libmail-box-perl_2.090.orig.tar.gz
 f8544bc25ea5cfa233b38d2b9a3f60bede24819f94706a8fc8db5d380f7d00fd 6465 
libmail-box-perl_2.090-1.diff.gz
 9cb1a5110ec45e33ae1de59c239689741fb4b79610218d325ce5642f4d22aa9c 1079502 
libmail-box-perl_2.090-1_all.deb
Files: 
 e2f1c8f3a57758e18a36a3c13c7f19fa 1908 perl optional 
libmail-box-perl_2.090-1.dsc
 12562374d88418ee75a15d5308979ea7 607184 perl optional 
libmail-box-perl_2.090.orig.tar.gz
 ec11dd9c6f02468a84d181b303aa4d10 6465 perl optional 
libmail-box-perl_2.090-1.diff.gz
 c21b039dde11e8014e6b917764695623 1079502 perl optional 
libmail-box-perl_2.090-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkomkh4ACgkQOzKYnQDzz+Qw5ACfSPyDzn2lWj5Mze+dJa8mThqh
H8kAoLhimxfQT0kYVCMo5IeGyjvMRb70
=tc/p
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to