Your message dated Wed, 26 Aug 2009 04:34:52 +0000
with message-id <[email protected]>
and subject line Bug#515219: fixed in rdate 1:1.2-4
has caused the Debian Bug report #515219,
regarding rdate: cannot connect to an NTP server over IPv6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
515219: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515219
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rdate
Version: 1:1.1.3-2
Severity: normal
It is not possible to connect to an NTP server over IPv6.
$ rdate -v -n -p -6 eu.ntp.sixxs.net
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Failed to connect to server: Invalid argument
rdate: Unable to get a reasonable time estimate
-- System Information:
Debian Release: 5.0
APT prefers unstable
APT policy: (900, 'unstable'), (500, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=pl_PL.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages rdate depends on:
ii libc6 2.7-18 GNU C Library: Shared libraries
rdate recommends no packages.
rdate suggests no packages.
-- no debconf information
--
Jakub Wilk
diff --git a/src/ntp.c b/src/ntp.c
--- a/src/ntp.c
+++ b/src/ntp.c
@@ -91,10 +91,6 @@
#define MILLION_L 1000000l /* For conversion to/from timeval */
#define MILLION_D 1.0e6 /* Must be equal to MILLION_L */
-#ifdef __GLIBC__
-#define SA_LEN(x) sizeof(*x)
-#endif
-
struct ntp_data {
u_char status;
u_char version;
@@ -111,7 +107,7 @@
};
void ntp_client(const char *, int, struct timeval *, struct timeval *, int, int, int);
-int sync_ntp(int, const struct sockaddr *, double *, double *, int);
+int sync_ntp(int, const struct sockaddr *, socklen_t, double *, double *, int);
int write_packet(int, struct ntp_data *);
int read_packet(int, struct ntp_data *, double *, double *);
void unpack_ntp(struct ntp_data *, u_char *);
@@ -155,7 +151,8 @@
((struct sockaddr_in*)res->ai_addr)->sin_port = htons(port);
}
- ret = sync_ntp(s, res->ai_addr, &offset, &error, verbose);
+ ret = sync_ntp(s, res->ai_addr, res->ai_addrlen, &offset,
+ &error, verbose);
if (ret < 0) {
#ifdef DEBUG
fprintf(stderr, "try the next address\n");
@@ -181,8 +178,8 @@
}
int
-sync_ntp(int fd, const struct sockaddr *peer, double *offset, double *error,
- int verbose)
+sync_ntp(int fd, const struct sockaddr *peer, socklen_t addrlen,
+ double *offset, double *error, int verbose)
{
int attempts = 0, accepts = 0, rejects = 0;
int delay = MAX_DELAY, ret;
@@ -195,7 +192,7 @@
*offset = 0.0;
*error = NTP_INSANITY;
- if (connect(fd, peer, SA_LEN(peer)) < 0) {
+ if (connect(fd, peer, addrlen) < 0) {
warn("Failed to connect to server");
return (-1);
}
--- End Message ---
--- Begin Message ---
Source: rdate
Source-Version: 1:1.2-4
We believe that the bug you reported is fixed in the latest version of
rdate, which is due to be installed in the Debian FTP archive:
rdate-udeb_1.2-4_powerpc.udeb
to pool/main/r/rdate/rdate-udeb_1.2-4_powerpc.udeb
rdate_1.2-4.diff.gz
to pool/main/r/rdate/rdate_1.2-4.diff.gz
rdate_1.2-4.dsc
to pool/main/r/rdate/rdate_1.2-4.dsc
rdate_1.2-4_powerpc.deb
to pool/main/r/rdate/rdate_1.2-4_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <[email protected]> (supplier of updated rdate package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 26 Aug 2009 12:43:48 +1000
Source: rdate
Binary: rdate rdate-udeb
Architecture: source powerpc
Version: 1:1.2-4
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <[email protected]>
Changed-By: Anibal Monsalve Salazar <[email protected]>
Description:
rdate - sets the system's date from a remote host
rdate-udeb - sets the system's date from a remote host (udeb)
Closes: 515219
Changes:
rdate (1:1.2-4) unstable; urgency=low
.
* Connect to an NTP server over IPv6
Patch by Jakub Wilk
Closes: 515219
* Fix out-of-date-standards-version
* Fix patch-system-but-no-source-readme
* Update debian/watch
Checksums-Sha1:
1c1700aa185bba43c3ba811be8cd79083739405b 1035 rdate_1.2-4.dsc
69b24536bfbebd309ef93f24921c196d138588ae 9740 rdate_1.2-4.diff.gz
ac56c8acc6ceea31012ba59b5272ae2d7ce7035c 16680 rdate_1.2-4_powerpc.deb
4519fe34cadfe053c490562521c9aa5634a9e3be 7484 rdate-udeb_1.2-4_powerpc.udeb
Checksums-Sha256:
d6111905f0df58aaeba5b237a80b9eff558ddea90cc4a4a1f5ff31a58a1ddc2f 1035
rdate_1.2-4.dsc
e55a1e47066f4ec36279ad2d0196c1fadac84df69bb07a1bbdfee29bdab666c5 9740
rdate_1.2-4.diff.gz
83c441022584fc63af72b76ab6db29bca6b6432c7e375f5b8bac7963ed17443d 16680
rdate_1.2-4_powerpc.deb
8aaa86a7979c6e5d16be1b382862404e7eef636be3c11c9e24d63f15dabd8c2f 7484
rdate-udeb_1.2-4_powerpc.udeb
Files:
8b49d19be43783284ec4fcddb24cb803 1035 net optional rdate_1.2-4.dsc
b31d3cfdbb4035b6a1b4495e848807a3 9740 net optional rdate_1.2-4.diff.gz
d074c08c94ad045a4238ad00c7786ee1 16680 net optional rdate_1.2-4_powerpc.deb
e1c87c31166b4a9e6f01445be7ad8bf7 7484 debian-installer optional
rdate-udeb_1.2-4_powerpc.udeb
Package-Type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqUuU8ACgkQgY5NIXPNpFX5AQCfb9nSyhLTE+HS/cgi7HaIV1/d
+JgAn25ZWru9KHArDEvXVopP1HF14zOR
=S7UP
-----END PGP SIGNATURE-----
--- End Message ---
