Your message dated Tue, 25 Aug 2009 22:28:39 -0700
with message-id <[email protected]>
and subject line Re: Could use -Werror-implicit-function-declarations to catch
unresolvable symbols early
has caused the Debian Bug report #102311,
regarding Could use -Werror-implicit-function-declarations to catch
unresolvable symbols early
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
102311: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=102311
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pam
Severity: wishlist
On Mon, Jun 25, 2001 at 06:50:31PM -0400, Sam Hartman wrote:
> sorry about thi; I screwed up between testing the patch and doing the
> final build and introduced a typo. Yes, I know I suck. I will be
> more careful in the future.
For the record, it was actually my typo in the patch I submitted for #97977.
In order to make this kind of mistake much more difficult in the future, I
recommend adding -Werror-implicit-function-declaration to debian.defs. I did a
quick build, and fixed up the few places where declarations were missing. A
patch is attached.
--
- mdz
diff -ru Linux-PAM-0.72.orig/defs/debian.defs Linux-PAM-0.72/defs/debian.defs
--- Linux-PAM-0.72.orig/defs/debian.defs Tue Jun 26 00:12:57 2001
+++ Linux-PAM-0.72/defs/debian.defs Mon Jun 25 23:59:28 2001
@@ -37,4 +37,4 @@
CONFIGED := /etc
SCONFIGED := /etc/security
EXTRALS := -lnsl -lcrypt
-WARNINGS := -Wall
+WARNINGS := -Wall -Werror-implicit-function-declaration
diff -ru Linux-PAM-0.72.orig/libpam/pam_delay.c
Linux-PAM-0.72/libpam/pam_delay.c
--- Linux-PAM-0.72.orig/libpam/pam_delay.c Sun Jul 4 19:23:42 1999
+++ Linux-PAM-0.72/libpam/pam_delay.c Tue Jun 26 00:02:19 2001
@@ -21,6 +21,7 @@
*/
#include <unistd.h>
+#include <time.h>
#include "pam_private.h"
/* **********************************************************************
diff -ru Linux-PAM-0.72.orig/modules/pam_access/pam_access.c
Linux-PAM-0.72/modules/pam_access/pam_access.c
--- Linux-PAM-0.72.orig/modules/pam_access/pam_access.c Tue Jun 26 00:12:58 2001
+++ Linux-PAM-0.72/modules/pam_access/pam_access.c Tue Jun 26 00:06:06 2001
@@ -25,6 +25,7 @@
#include <errno.h>
#include <ctype.h>
#include <sys/utsname.h>
+#include <rpcsvc/ypclnt.h>
#ifndef BROKEN_NETWORK_MATCH
# include <netdb.h>
diff -ru Linux-PAM-0.72.orig/modules/pam_rhosts/pam_rhosts_auth.c
Linux-PAM-0.72/modules/pam_rhosts/pam_rhosts_auth.c
--- Linux-PAM-0.72.orig/modules/pam_rhosts/pam_rhosts_auth.c Tue Jun 26
00:12:57 2001
+++ Linux-PAM-0.72/modules/pam_rhosts/pam_rhosts_auth.c Tue Jun 26 00:09:52 2001
@@ -63,6 +63,7 @@
#include <netdb.h> /* This is supposed(?) to contain the following */
int innetgr(const char *, const char *, const char *,const char *);
+#include <sys/fsuid.h>
#include <stdio.h>
#include <errno.h>
#include <sys/time.h>
--- End Message ---
--- Begin Message ---
Source: pam
Source-Version: 1.1.0-1
We believe that the bug you reported is fixed in the latest version of
pam, which is due to be installed in the Debian FTP archive:
libpam-cracklib_1.1.0-1_amd64.deb
to pool/main/p/pam/libpam-cracklib_1.1.0-1_amd64.deb
libpam-doc_1.1.0-1_all.deb
to pool/main/p/pam/libpam-doc_1.1.0-1_all.deb
libpam-modules_1.1.0-1_amd64.deb
to pool/main/p/pam/libpam-modules_1.1.0-1_amd64.deb
libpam-runtime_1.1.0-1_all.deb
to pool/main/p/pam/libpam-runtime_1.1.0-1_all.deb
libpam0g-dev_1.1.0-1_amd64.deb
to pool/main/p/pam/libpam0g-dev_1.1.0-1_amd64.deb
libpam0g_1.1.0-1_amd64.deb
to pool/main/p/pam/libpam0g_1.1.0-1_amd64.deb
pam_1.1.0-1.diff.gz
to pool/main/p/pam/pam_1.1.0-1.diff.gz
pam_1.1.0-1.dsc
to pool/main/p/pam/pam_1.1.0-1.dsc
pam_1.1.0.orig.tar.gz
to pool/main/p/pam/pam_1.1.0.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Steve Langasek <[email protected]> (supplier of updated pam package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 25 Aug 2009 20:35:26 -0700
Source: pam
Binary: libpam0g libpam-modules libpam-runtime libpam0g-dev libpam-cracklib
libpam-doc
Architecture: source all amd64
Version: 1.1.0-1
Distribution: unstable
Urgency: low
Maintainer: Steve Langasek <[email protected]>
Changed-By: Steve Langasek <[email protected]>
Description:
libpam-cracklib - PAM module to enable cracklib support
libpam-doc - Documentation of PAM
libpam-modules - Pluggable Authentication Modules for PAM
libpam-runtime - Runtime support for the PAM library
libpam0g - Pluggable Authentication Modules library
libpam0g-dev - Development files for PAM
Closes: 10231 263767 308229 326407 376209 488690 514423 521266 543401
Changes:
pam (1.1.0-1) unstable; urgency=low
.
* New upstream version.
- pam_access no longer does DNS lookups when we know we're comparing
with a tty name or a service name. Closes: #376209.
- fixes for manpage spelling. Closes: #488690.
- fix evaluation of or'ed list of users in time.conf and group.conf.
Closes: #326407, #514423.
* Drop patches pam_unix_thread-safe_save_old_password.patch,
pam_env_ignore_garbage.patch, dont_freeze_password_chain,
pam_1.0.4_mindays, pam_mail-fix-quiet, pam_unix-chkpwd-wait, and
cve-2009-0887-libpam-pam_misc.patch, which are included upstream.
* Trim pam.d-manpage-section patch, which was mostly but not completely
applied upstream.
* Update debian/libpam0g.symbols for new extension.
* Bump the shlibs version as well, for our dpkg-shlibdeps fallback.
* And bump the version checks in the libpam-modules {pre,post}inst, so that
the necessary services get restarted for any modules that need the new
symbols.
* Add /sbin/mkhomedir_helper to libpam-modules.
* Document that pam_cracklib no longer checks /etc/security/opasswd.
Closes: #263767.
* debian/patches/007_modules_pam_unix: drop divergence from upstream
that treats "0" as a special value in various fields in /etc/shadow,
and document this in debian/NEWS. Thanks to Nicolas François
<[email protected]> for the detailed analysis.
Closes: #308229.
* Updated debconf translations:
- French, thanks to Jean-Baka Domelevo Entfellner <[email protected]>
(closes: #521266)
* Build with LDFLAGS=-Wl,-z,defs to guard against the possibility of
any undefined symbols (due to typos or otherwise) at build time.
Closes: #10231.
* On upgrade from versions before 1.1.0-1, if
/etc/pam.d/common-session-noninteractive has not been created (because
the user declined use of pam-auth-update), create it by copying
/etc/pam.d/common-session. Closes: #543401.
* debian/patches/fix-man-crud: new patch, fix "undefined macro" errors in
manpages caused by oddities of toolchain used when generating them
upstream.
Checksums-Sha1:
4bf95a723757748b39ca3e5c57c9c809d78023e7 1472 pam_1.1.0-1.dsc
2d9d10d79bae2e24af00e267190883f10a8604ae 1739305 pam_1.1.0.orig.tar.gz
899bb5444ac5e6faf0609b642cba46ecd3268ba4 247643 pam_1.1.0-1.diff.gz
48fa2c7023d0b2799af50675281dee2f394869b3 220252 libpam-runtime_1.1.0-1_all.deb
51bf0b15ccdb71ae19a0174c658b94555a10390c 308624 libpam-doc_1.1.0-1_all.deb
ebc92e3af4596587a19cd5c3711155b2ffe6053d 118656 libpam0g_1.1.0-1_amd64.deb
8210db64eef9a135f26152fc85d027d826f2cc02 354902
libpam-modules_1.1.0-1_amd64.deb
1ad1a8003918e1cd0144f7df3f7ac669fa3c48d4 182520 libpam0g-dev_1.1.0-1_amd64.deb
648cbd7e9505793aac8e8cdacbf429a70d242860 76432
libpam-cracklib_1.1.0-1_amd64.deb
Checksums-Sha256:
883a28be0f8dcce11225957f71e36c4284070b6cdba1d8fbbae2840ee778ef63 1472
pam_1.1.0-1.dsc
5b3541b949ff0d05f8065d88d7ed906a1b8414967e280cadaf1e629897c8f4e8 1739305
pam_1.1.0.orig.tar.gz
4aba4d17b651d5363680a2935a32dba5a49b514beda041bb4cfe813bab2139e1 247643
pam_1.1.0-1.diff.gz
96ba19248fef5afc154bb1608409afb50bd8be5ac0ec2fdf951c3b2037fcf43d 220252
libpam-runtime_1.1.0-1_all.deb
1a0a018595ad1ce0bf234657c38bdc981056d0c68686acf5cb9f111d1d5a89be 308624
libpam-doc_1.1.0-1_all.deb
8dc84ffadc0fb4808ffcb955cbb72c79c9afc67bd1fb3301c660f5a6ac0a8baf 118656
libpam0g_1.1.0-1_amd64.deb
a2456a7c459acc9fac3fb075dd0d0e645576209993dc6112aecef306a2a856ed 354902
libpam-modules_1.1.0-1_amd64.deb
06512464ef5088b146d4abc5147b60af22cd9beb9f9027e641396f673e1ab642 182520
libpam0g-dev_1.1.0-1_amd64.deb
a7b9bda303f2c617e8230dcc446a23350bfcdf7a1bebc24696860508ea55fc40 76432
libpam-cracklib_1.1.0-1_amd64.deb
Files:
f9ab0e84061a3ebdf874c27669bc292d 1472 libs optional pam_1.1.0-1.dsc
004ea633a4bd4d059e68f75b9fab4d35 1739305 libs optional pam_1.1.0.orig.tar.gz
8cedf4422acf8f8a643029d8c726112f 247643 libs optional pam_1.1.0-1.diff.gz
064e220ed8e8c6d58a4f58b026a4ee3a 220252 admin required
libpam-runtime_1.1.0-1_all.deb
041764356da5e383530bb953e3a752c8 308624 doc optional libpam-doc_1.1.0-1_all.deb
3ca15dc06535e95067f435ed565d359c 118656 libs required
libpam0g_1.1.0-1_amd64.deb
f75060342124a3ce55f793911928f4de 354902 admin required
libpam-modules_1.1.0-1_amd64.deb
654e262b033909440138fcfaddf9e60c 182520 libdevel optional
libpam0g-dev_1.1.0-1_amd64.deb
8c9c7963ee7ec848a9efed1982f0e04a 76432 admin optional
libpam-cracklib_1.1.0-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFKlK9UKN6ufymYLloRAhluAKClESkfh5rck8U+5K6yuNDwFKP4JQCfWNQb
NzX+uVhKJCuCScEs+zuU6G0=
=vuQe
-----END PGP SIGNATURE-----
--- End Message ---
