Your message dated Sat, 03 Mar 2012 11:18:55 +0000
with message-id <[email protected]>
and subject line Bug#659887: fixed in xfce4-panel 4.8.6-3
has caused the Debian Bug report #659887,
regarding xfce4-panel: use dh_installdeb maintscript support
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
659887: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659887
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-panel
Version: 4.8.6-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before xfce4-panel.
This seems generally undesirable; it would be better to enforce a single
code path. (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you could remove some of your handwritten maintainer scripts
entirely (quite possibly the postinst can go as well since ldconfig is
now handled by triggers, but that's a separate issue). Here's a patch:
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
diff -Nru xfce4-panel-4.8.6/debian/xfce4-panel.maintscript
xfce4-panel-4.8.6/debian/xfce4-panel.maintscript
--- xfce4-panel-4.8.6/debian/xfce4-panel.maintscript 1970-01-01
01:00:00.000000000 +0100
+++ xfce4-panel-4.8.6/debian/xfce4-panel.maintscript 2012-02-14
14:55:57.000000000 +0000
@@ -0,0 +1,7 @@
+rm_conffile /etc/xdg/xfce4/panel/clock-14.rc 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/launcher-10.rc 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/launcher-7.rc 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/launcher-9.rc 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/panels.xml 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/systray-4.rc 4.7.0
+rm_conffile /etc/xdg/xfce4/panel/xfce4-menu-5.rc 4.7.0
diff -Nru xfce4-panel-4.8.6/debian/xfce4-panel.postinst
xfce4-panel-4.8.6/debian/xfce4-panel.postinst
--- xfce4-panel-4.8.6/debian/xfce4-panel.postinst 2011-03-31
09:57:51.000000000 +0100
+++ xfce4-panel-4.8.6/debian/xfce4-panel.postinst 2012-02-14
14:56:13.000000000 +0000
@@ -2,25 +2,6 @@
set -e
-LASTVER="4.7.0"
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/clock-14.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-10.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-7.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-9.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/panels.xml "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/systray-4.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/xfce4-menu-5.rc "$LASTVER" -- "$@"
-fi
-
if [ "$1" = "configure" ]; then
# Run ldconfig to update shared library system
ldconfig
diff -Nru xfce4-panel-4.8.6/debian/xfce4-panel.postrm
xfce4-panel-4.8.6/debian/xfce4-panel.postrm
--- xfce4-panel-4.8.6/debian/xfce4-panel.postrm 2011-03-30 18:19:09.000000000
+0100
+++ xfce4-panel-4.8.6/debian/xfce4-panel.postrm 1970-01-01 01:00:00.000000000
+0100
@@ -1,24 +0,0 @@
-#!/bin/sh
-
-set -e
-
-LASTVER="4.7.0"
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/clock-14.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-10.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-7.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-9.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/panels.xml "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/systray-4.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/xfce4-menu-5.rc "$LASTVER" -- "$@"
-fi
-
-#DEBHELPER#
diff -Nru xfce4-panel-4.8.6/debian/xfce4-panel.preinst
xfce4-panel-4.8.6/debian/xfce4-panel.preinst
--- xfce4-panel-4.8.6/debian/xfce4-panel.preinst 2011-03-31
09:57:51.000000000 +0100
+++ xfce4-panel-4.8.6/debian/xfce4-panel.preinst 1970-01-01
01:00:00.000000000 +0100
@@ -1,24 +0,0 @@
-#!/bin/sh
-
-set -e
-
-LASTVER="4.7.0"
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/clock-14.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-10.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-7.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/launcher-9.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/panels.xml "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/systray-4.rc "$LASTVER" -- "$@"
- dpkg-maintscript-helper rm_conffile \
- /etc/xdg/xfce4/panel/xfce4-menu-5.rc "$LASTVER" -- "$@"
-fi
-
-#DEBHELPER#
Thanks,
--
Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---
Source: xfce4-panel
Source-Version: 4.8.6-3
We believe that the bug you reported is fixed in the latest version of
xfce4-panel, which is due to be installed in the Debian FTP archive:
xfce4-panel-dbg_4.8.6-3_amd64.deb
to main/x/xfce4-panel/xfce4-panel-dbg_4.8.6-3_amd64.deb
xfce4-panel-dev_4.8.6-3_amd64.deb
to main/x/xfce4-panel/xfce4-panel-dev_4.8.6-3_amd64.deb
xfce4-panel_4.8.6-3.debian.tar.gz
to main/x/xfce4-panel/xfce4-panel_4.8.6-3.debian.tar.gz
xfce4-panel_4.8.6-3.dsc
to main/x/xfce4-panel/xfce4-panel_4.8.6-3.dsc
xfce4-panel_4.8.6-3_amd64.deb
to main/x/xfce4-panel/xfce4-panel_4.8.6-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lionel Le Folgoc <[email protected]> (supplier of updated xfce4-panel package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 03 Mar 2012 12:08:11 +0100
Source: xfce4-panel
Binary: xfce4-panel xfce4-panel-dev xfce4-panel-dbg
Architecture: source amd64
Version: 4.8.6-3
Distribution: unstable
Urgency: low
Maintainer: Debian Xfce Maintainers <[email protected]>
Changed-By: Lionel Le Folgoc <[email protected]>
Description:
xfce4-panel - panel for Xfce4 desktop environment
xfce4-panel-dbg - debugging informations for xfce4-panel
xfce4-panel-dev - Xfce4 panel development files
Closes: 659887
Changes:
xfce4-panel (4.8.6-3) unstable; urgency=low
.
[ Lionel Le Folgoc ]
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
Thanks Colin Watson for the patch Closes: #659887
* debian/patches: add missing DEP3 headers.
.
[ Yves-Alexis Perez ]
* debian/control:
- update standards version to 3.9.3.
Checksums-Sha1:
712327cdb0b457abdc2ae2d7cd27e348520c0d5d 2393 xfce4-panel_4.8.6-3.dsc
a160bd9f64d6e5e33cd6a040506c1b0e0d648a76 12749
xfce4-panel_4.8.6-3.debian.tar.gz
ce9ec68281418c5afaaf5ab88884a1a6f087e95b 1226994 xfce4-panel_4.8.6-3_amd64.deb
dd2817eec02acfdac5e8ed7457b4ba814980d1a0 204822
xfce4-panel-dev_4.8.6-3_amd64.deb
290ec8c090f21741045726ced05119a7e93bb083 1179432
xfce4-panel-dbg_4.8.6-3_amd64.deb
Checksums-Sha256:
5298ef01e2e716fc3acbf0f72ae1655a877d056ec54803eb521f342f58c01772 2393
xfce4-panel_4.8.6-3.dsc
25fe6536f91343d688bfa659e71d535d1b971eace882b2fb8d969f7cebcd2d5e 12749
xfce4-panel_4.8.6-3.debian.tar.gz
a73a54f35ed517a7859eaf68ab03f60777be05fdef32b60d1585ff2e099c468c 1226994
xfce4-panel_4.8.6-3_amd64.deb
f4705df52493b3ef627f25bbfda7d1fbdea6aa785cdee298db1eae684caeff3b 204822
xfce4-panel-dev_4.8.6-3_amd64.deb
4e3e97b4cfae7c6bbb08db18d3424c71e4166f0eee561a40418316250990cb11 1179432
xfce4-panel-dbg_4.8.6-3_amd64.deb
Files:
f5ec3fef44466110eb441c2a90b003ec 2393 xfce optional xfce4-panel_4.8.6-3.dsc
c2cfe91f30a83963138eca1f72d67eda 12749 xfce optional
xfce4-panel_4.8.6-3.debian.tar.gz
42c7ad41e7f2c1619e00b7685a23c52c 1226994 xfce optional
xfce4-panel_4.8.6-3_amd64.deb
ba224538077d50f2cbe42f2c73583410 204822 xfce optional
xfce4-panel-dev_4.8.6-3_amd64.deb
d9304063cd2030d286919a5ffc824af5 1179432 debug extra
xfce4-panel-dbg_4.8.6-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCgAGBQJPUfzaAAoJEDBVD3hx7wuoZyYQAIjFXjTZWmkr7YH9bGDUAFF4
q7IcWyOvkJDvReJDkKORkfGB3L1JYTurt5+YRsZQwR8uORhA3+SM3McULBAQivvQ
FTGDBsrURIQ3+nFugiikD3Oed7kJw33YT+71J41FoQrQNGz+dbFqh6V3L32bC+Sf
D4SLr7WAxIcXNVfzphEaZLooP/UaTdXkfu46/J7oJ+5Y64BXtfiY1wQBhifUavQc
qC1/VNzT04qwn/Sz4Mu2qf/SC8m+AUBT68yb3wiplRB8OPHf+UNa0RmSfYRGAA+z
eEOKZoEGZa76viIx+nuFQH5kLqF9yifK70Wig1lJjF2tgozXgUZR6XR9XLb7bxHJ
sQFjf4xqzn1ZK45QoHV+knzyoP7vrvLKH7l6XXwPY2Vvi5F0qGZysurXAUzzjvRb
iINTv25wEZpSxEccifannTc0E3z0WVfJFrTtI/FXlkgYyqh2D5C3fkxJ2AIvG6Hs
sFxAWfLvHbB0kBbswJuMYXg/yZ3Wp5MOxjAIou+zQvg3EQJldE7XniLVuJ6aaIYl
dzwJHu9EplfopYBPRQiGxuiuWslhA2tUgZ5NTzSngZQ+aNAVOxrpEXxv/2M4oh2S
pKCBIb37H+tofs+ceR+F2tStneZa+Z8FNzVgsEcEgkWUMbcEjNqw8xez3uJey17+
mqZa4UN6K+GgKOLWfnGS
=wmuk
-----END PGP SIGNATURE-----
--- End Message ---
