Your message dated Sat, 03 Mar 2012 11:35:23 +0000
with message-id <[email protected]>
and subject line Bug#659890: fixed in xfce4-session 4.8.3-2
has caused the Debian Bug report #659890,
regarding xfce4-session: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
659890: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659890
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-session
Version: 4.8.3-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise

xfce4-session is currently using dpkg-maintscript-helper without a
pre-dependency.  This is academic for Debian because the version of dpkg
in squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have a handwritten postrm at all.
Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  This adds a Pre-Dependency on
    a sufficient version of dpkg.

diff -Nru xfce4-session-4.8.3/debian/control xfce4-session-4.8.3/debian/control
--- xfce4-session-4.8.3/debian/control  2012-02-12 17:05:23.000000000 +0000
+++ xfce4-session-4.8.3/debian/control  2012-02-14 15:10:49.000000000 +0000
@@ -16,7 +16,7 @@
 Package: xfce4-session
 Section: xfce
 Architecture: any
-Pre-Depends: multiarch-support
+Pre-Depends: ${misc:Pre-Depends}, multiarch-support
 Depends: ${shlibs:Depends}, ${misc:Depends}, xfce4-settings, xfconf
 Recommends: xfwm4, xfce4-utils, xfdesktop4, ${shlibs:Recommends}, consolekit, 
upower,
  dbus-x11, x11-xserver-utils
diff -Nru xfce4-session-4.8.3/debian/maintscript 
xfce4-session-4.8.3/debian/maintscript
--- xfce4-session-4.8.3/debian/maintscript      1970-01-01 01:00:00.000000000 
+0100
+++ xfce4-session-4.8.3/debian/maintscript      2012-02-14 15:10:25.000000000 
+0000
@@ -0,0 +1 @@
+rm_conffile /etc/xdg/autostart/xfce4-tips-autostart.desktop 4.8.1-4
diff -Nru xfce4-session-4.8.3/debian/postinst 
xfce4-session-4.8.3/debian/postinst
--- xfce4-session-4.8.3/debian/postinst 2011-09-13 22:46:59.000000000 +0100
+++ xfce4-session-4.8.3/debian/postinst 2012-02-14 15:10:32.000000000 +0000
@@ -7,9 +7,6 @@
     x-session-manager.1.gz /usr/share/man/man1/xfce4-session.1.gz 
 fi
 
-dpkg-maintscript-helper rm_conffile \
-  /etc/xdg/autostart/xfce4-tips-autostart.desktop 4.8.1-4 -- "$@"
-
 #DEBHELPER#
 
 exit 0
diff -Nru xfce4-session-4.8.3/debian/postrm xfce4-session-4.8.3/debian/postrm
--- xfce4-session-4.8.3/debian/postrm   2011-09-13 22:46:59.000000000 +0100
+++ xfce4-session-4.8.3/debian/postrm   1970-01-01 01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh -e
-
-dpkg-maintscript-helper rm_conffile \
-  /etc/xdg/autostart/xfce4-tips-autostart.desktop 4.8.1-4 -- "$@"
-
-#DEBHELPER#
-
-exit 0
diff -Nru xfce4-session-4.8.3/debian/preinst xfce4-session-4.8.3/debian/preinst
--- xfce4-session-4.8.3/debian/preinst  2011-09-13 22:51:47.000000000 +0100
+++ xfce4-session-4.8.3/debian/preinst  2012-02-14 15:10:29.000000000 +0000
@@ -1,8 +1,5 @@
 #!/bin/sh -e
 
-dpkg-maintscript-helper rm_conffile \
-  /etc/xdg/autostart/xfce4-tips-autostart.desktop 4.8.1-4 -- "$@"
-
 # Remove symlink for el, replaced by a folder in 4.8.2-1
 case "$1" in
 install|upgrade)

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: xfce4-session
Source-Version: 4.8.3-2

We believe that the bug you reported is fixed in the latest version of
xfce4-session, which is due to be installed in the Debian FTP archive:

xfce4-session-dbg_4.8.3-2_amd64.deb
  to main/x/xfce4-session/xfce4-session-dbg_4.8.3-2_amd64.deb
xfce4-session_4.8.3-2.debian.tar.gz
  to main/x/xfce4-session/xfce4-session_4.8.3-2.debian.tar.gz
xfce4-session_4.8.3-2.dsc
  to main/x/xfce4-session/xfce4-session_4.8.3-2.dsc
xfce4-session_4.8.3-2_amd64.deb
  to main/x/xfce4-session/xfce4-session_4.8.3-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lionel Le Folgoc <[email protected]> (supplier of updated xfce4-session package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 03 Mar 2012 12:17:56 +0100
Source: xfce4-session
Binary: xfce4-session xfce4-session-dbg
Architecture: source amd64
Version: 4.8.3-2
Distribution: unstable
Urgency: low
Maintainer: Debian Xfce Maintainers <[email protected]>
Changed-By: Lionel Le Folgoc <[email protected]>
Description: 
 xfce4-session - Xfce4 Session Manager
 xfce4-session-dbg - Xfce4 Session Manager (debug symbols)
Closes: 659890
Changes: 
 xfce4-session (4.8.3-2) unstable; urgency=low
 .
   [ Lionel Le Folgoc ]
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand.  This adds a Pre-Dependency on
     a sufficient version of dpkg. Thanks Colin Watson for the patch.
                                                                 Closes: #659890
   * debian/patches: add missing DEP3 headers.
 .
   [ Yves-Alexis Perez ]
   * debian/control:
     - update standards version to 3.9.3.
Checksums-Sha1: 
 87075a2f1b0a55607493c3e17f7d268befef1dfb 2380 xfce4-session_4.8.3-2.dsc
 01d36cc76d34dd89dccb2c07c7c9c6090fec9d30 13826 
xfce4-session_4.8.3-2.debian.tar.gz
 7f19cf8514ce1e2befcc2fc1822cb1c53130fd32 1356728 
xfce4-session_4.8.3-2_amd64.deb
 af522e03227392d11af5e86f5e7096f3144ff561 454134 
xfce4-session-dbg_4.8.3-2_amd64.deb
Checksums-Sha256: 
 f0d5a5212fc0880c99144bf369fc0702c8b18437314351f98bc794d0724a5336 2380 
xfce4-session_4.8.3-2.dsc
 0fa85c891aa491fe23c8f61737a8caf082ec629468a34b4cbfeaccb27d640bb5 13826 
xfce4-session_4.8.3-2.debian.tar.gz
 1c136570f7e221dfa0d00fc30284a672ccac59915cf0dd89a38fa2407b3655a8 1356728 
xfce4-session_4.8.3-2_amd64.deb
 2780c3f07c39ef0bb6b8ebea0d65bcdde7f7175dfa386f1f9697d5c67eb7d30d 454134 
xfce4-session-dbg_4.8.3-2_amd64.deb
Files: 
 356a373d6ac40219a54a76d249f5d66c 2380 xfce optional xfce4-session_4.8.3-2.dsc
 08db5f8f5a0436b3cbfd5901ccd06bcc 13826 xfce optional 
xfce4-session_4.8.3-2.debian.tar.gz
 d5958c8271470e021ee635c375a54e94 1356728 xfce optional 
xfce4-session_4.8.3-2_amd64.deb
 d39b5d0b738f9245ce35b6bf0f9809ea 454134 debug extra 
xfce4-session-dbg_4.8.3-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJPUf6wAAoJEDBVD3hx7wuodiwP+wb6k2GcVN1FBVJAZjD+/U+C
YbSShIaZwoJUjpXqbr2rZJhCG2aKjewkmAZg/ss9aGBWhbdpjLcPoAv04I+KYrIU
pwc4VoqA816pPE1l+xOurrVsIFWmyPTBRTrEY8Tdbp1+p/XdPwI0zM0SbpQN4F8H
+Uq5NHkKn1GWWrFOrndWMiUgnWUh9nwzQnOKdY4KHaozsTVU2c/7L/SUDUmazXYt
9XjZAhdnqws2uFhAN5xHBVm/DmdAf2Fh1p9jelxniavn4NWDidkEOO4CA6p7nY7D
2HmMSNZtCawDUOVSwpa0CP4qFwelEYbJk5+1r1UiSN3syzby0mjKs9nAtcYIocY/
ipIkkC6AeS7tm9QTr2Y7lpLF0X8gN/0ZshWXseX6XmzH5bCmxE1JiAwS2WOD6jvI
jsF+aYPkNdyf0Dw3kCChBDetnw4IrzZc6WQzn+ZlqQr3HyzCKqkFN79AsZvVwz0m
2Fac4Sy6QUR2E2WNR8GYbvlp6uhYEKtnzGhMBt3J/olkz26uDJSTTbY/4UORrG/N
ntnWyK6ADUn37lYYKXs0KA729WG3uYPGRNLG2IKZxaWVzR3k9ZNaTcN9YOAPaiCw
VLE8j4ioPZ57CtzUWVHyps3Lp3UuDRmMMSLfbwumbOcejodHNbmEyjCSs5vI8e5i
GJdngdHyV+c1l1DxaY6+
=UcBB
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to