Your message dated Fri, 25 May 2012 01:47:50 +0000
with message-id <[email protected]>
and subject line Bug#659797: fixed in uptimed 1:0.3.17-1
has caused the Debian Bug report #659797,
regarding uptimed: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
659797: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659797
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: uptimed
Version: 1:0.3.16-3.2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before uptimed.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts.
Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -u uptimed-0.3.16/debian/control uptimed-0.3.16/debian/control
--- uptimed-0.3.16/debian/control
+++ uptimed-0.3.16/debian/control
@@ -2,11 +2,12 @@
 Section: utils
 Priority: extra
 Maintainer: Thibaut VARENE <[email protected]>
-Build-Depends: debhelper (>= 7), quilt, automake, libtool
+Build-Depends: debhelper (>= 8.1.0~), quilt, automake, libtool
 Standards-Version: 3.8.0
 
 Package: uptimed
 Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}, ${shlibs:Depends}
 Description: Utility to track your highest uptimes
  Uptimed allows you to track your highest uptimes via boot IDs.
diff -u uptimed-0.3.16/debian/uptimed.postinst 
uptimed-0.3.16/debian/uptimed.postinst
--- uptimed-0.3.16/debian/uptimed.postinst
+++ uptimed-0.3.16/debian/uptimed.postinst
@@ -68,7 +68,2 @@
 
-# remove old bootid creating script.
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-       dpkg-maintscript-helper rm_conffile /etc/init.d/uptimed.sh 1:0.3.16-3.1 
-- "$@"
-fi
-
 #DEBHELPER#
diff -u uptimed-0.3.16/debian/uptimed.postrm 
uptimed-0.3.16/debian/uptimed.postrm
--- uptimed-0.3.16/debian/uptimed.postrm
+++ uptimed-0.3.16/debian/uptimed.postrm
@@ -1,10 +1,5 @@
 #!/bin/sh
 
-# remove old bootid creating script.
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-       dpkg-maintscript-helper rm_conffile /etc/init.d/uptimed.sh 1:0.3.16-3.1 
-- "$@"
-fi
-
 #DEBHELPER#
 
 if [ "$1" = "purge" ]; then
diff -u uptimed-0.3.16/debian/uptimed.preinst 
uptimed-0.3.16/debian/uptimed.preinst
--- uptimed-0.3.16/debian/uptimed.preinst
+++ uptimed-0.3.16/debian/uptimed.preinst
@@ -3,9 +3,6 @@
 set -e
 
-# remove old bootid creating script and symlinks from rcS.
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-       update-rc.d -f uptimed.sh remove
-       dpkg-maintscript-helper rm_conffile /etc/init.d/uptimed.sh 1:0.3.16-3.1 
-- "$@"
-fi
+# Remove symlinks from rcS.
+update-rc.d -f uptimed.sh remove
 
 #DEBHELPER#
only in patch2:
unchanged:
--- uptimed-0.3.16.orig/debian/uptimed.maintscript
+++ uptimed-0.3.16/debian/uptimed.maintscript
@@ -0,0 +1,2 @@
+# Remove old bootid creating script.
+rm_conffile /etc/init.d/uptimed.sh 1:0.3.16-3.1

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: uptimed
Source-Version: 1:0.3.17-1

We believe that the bug you reported is fixed in the latest version of
uptimed, which is due to be installed in the Debian FTP archive:

libuptimed-dev_0.3.17-1_ia64.deb
  to main/u/uptimed/libuptimed-dev_0.3.17-1_ia64.deb
libuptimed0_0.3.17-1_ia64.deb
  to main/u/uptimed/libuptimed0_0.3.17-1_ia64.deb
uprecords-cgi_0.3.17-1_all.deb
  to main/u/uptimed/uprecords-cgi_0.3.17-1_all.deb
uptimed_0.3.17-1.debian.tar.gz
  to main/u/uptimed/uptimed_0.3.17-1.debian.tar.gz
uptimed_0.3.17-1.dsc
  to main/u/uptimed/uptimed_0.3.17-1.dsc
uptimed_0.3.17-1_ia64.deb
  to main/u/uptimed/uptimed_0.3.17-1_ia64.deb
uptimed_0.3.17.orig.tar.bz2
  to main/u/uptimed/uptimed_0.3.17.orig.tar.bz2



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thibaut VARENE <[email protected]> (supplier of updated uptimed package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 25 May 2012 02:47:05 +0200
Source: uptimed
Binary: uptimed libuptimed0 libuptimed-dev uprecords-cgi
Architecture: source all ia64
Version: 1:0.3.17-1
Distribution: unstable
Urgency: low
Maintainer: Thibaut VARENE <[email protected]>
Changed-By: Thibaut VARENE <[email protected]>
Description: 
 libuptimed-dev - Development files for uptimed
 libuptimed0 - Library for uptimed
 uprecords-cgi - CGI script to show the world your highest uptimes
 uptimed    - Utility to track your highest uptimes
Closes: 645504 648948 650109 657922 659797
Changes: 
 uptimed (1:0.3.17-1) unstable; urgency=low
 .
   * New upstream release (Closes: #648948, #650109)
   * Switch to dpkg-source 3.0 (quilt) format
   * Move PID to /run and provide systemd .service file (Closes: #657922)
   * Use maintscript support, patch from Colin Watson (Closes: #659797)
   * Add status in init script, patch from Peter Eisentraut (Closes: #645504)
   * Enabled hardened build
   * Fixed some lintian warnings
Checksums-Sha1: 
 e87a545ad7f6003684d0de7a1c8a436965ca332b 1263 uptimed_0.3.17-1.dsc
 a40728353b153d1967371c2fd498e6bc3274c4c9 269102 uptimed_0.3.17.orig.tar.bz2
 9a230cdcc1edab769970bd832952a6b703bb986b 44731 uptimed_0.3.17-1.debian.tar.gz
 28cd7ec51390d50297d25347ec593929335d9c6a 19168 uprecords-cgi_0.3.17-1_all.deb
 c78c09fd02da452998ae4b7351e135ace100ad0e 41714 uptimed_0.3.17-1_ia64.deb
 8debd43d576344c1bc3d9e52c3b57e7a07d63954 18732 libuptimed0_0.3.17-1_ia64.deb
 87ca3cf7629e1d775333ff835661e7ca3e8305d7 18832 libuptimed-dev_0.3.17-1_ia64.deb
Checksums-Sha256: 
 8619439719b5122b920caa53e5eaafcffdca853e386767f8447848256fe5aea5 1263 
uptimed_0.3.17-1.dsc
 524ce8984c0d0a780a32025ba3ffb980e5eec3d78e65cf68c91edec7fe833a06 269102 
uptimed_0.3.17.orig.tar.bz2
 9b289b8ebe636bc46bd459dcf24ccbc34e5bd1ba1348120df561693c68c283d3 44731 
uptimed_0.3.17-1.debian.tar.gz
 f394264ad2a8a6547996b44d151da9f6dcf3ff06c5a70d454275b8bd186ca3e1 19168 
uprecords-cgi_0.3.17-1_all.deb
 a80116ea1e55900d1b4c76b6a1371712eafa75a11ea9c1025f4bd1b79e9bc5c6 41714 
uptimed_0.3.17-1_ia64.deb
 644537dafada6a7f3b9862b77544064b04af9031f78633da9eaa18b18b85e0ed 18732 
libuptimed0_0.3.17-1_ia64.deb
 56f111226cd444e3880ab69c9462b8119b0d4d07bde616e8da0f8cfb63740983 18832 
libuptimed-dev_0.3.17-1_ia64.deb
Files: 
 119261c715b921b241613072d456b5be 1263 utils extra uptimed_0.3.17-1.dsc
 528b62c33454b33537c3bf2366977bdb 269102 utils extra uptimed_0.3.17.orig.tar.bz2
 9c3aa3c4ee52cf21d099af580caa94d8 44731 utils extra 
uptimed_0.3.17-1.debian.tar.gz
 f52597c79181b8e7a271e4e65054200f 19168 utils extra 
uprecords-cgi_0.3.17-1_all.deb
 19aebaca17644565ec4e7f1cdebbeca2 41714 utils extra uptimed_0.3.17-1_ia64.deb
 818525a2bb994817c2f07ca0835c6c3f 18732 libs extra libuptimed0_0.3.17-1_ia64.deb
 13606d4a5777940c236554aab494266d 18832 libdevel extra 
libuptimed-dev_0.3.17-1_ia64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk++4foACgkQHjLD2rfS8GMaBgCfRaoXc2tlEjYt3zkQRtpUK0Qi
gVIAoKxTaCGC8rQ8g6s39kYZnORK8e7P
=/LuI
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to