Your message dated Thu, 6 Jun 2013 11:57:15 +0700
with message-id 
<cacvhritcbbqd5vx66jezmp8thj8mbgccokn5cvsb9kejxwc...@mail.gmail.com>
and subject line Obsolete bug
has caused the Debian Bug report #620002,
regarding libpango1.0-0: VTE always displays Thai SARA AM (U+0E33) with dotted 
circle
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
620002: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=620002
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libpango1.0-0
Version: 1.28.3-5
Severity: normal
Tags: patch

As reported upstream since Pango 1.24.x in GNOME #583718, Thai SARA AM
(U+0E33) is always rendered with dotted circle in VTE, and thus
gnome-terminal.

  https://bugzilla.gnome.org/show_bug.cgi?id=583718

This was once considered a duplicate of GNOME #584160, in which all
complex text languages are to be solved at once. But 2 years have passed
without any progress, and Thai people have suffered and complained
everywhere about this very visible glitch.

  https://bugzilla.gnome.org/show_bug.cgi?id=584160

In fact, this problem has been commonly treated in typewriters and
text-mode consoles by letting SARA AM take its own cell without
decomposition, making the fix very trivial. No need for any special
"complex text" analysis.

I have applied the proposed patch in my local repository for Thai users
here, with rebuilding on every update in sid for the past 2 years:

  http://ftp.debianclub.org/debclub/pool/main/p/pango1.0/

The patch has even been taken by Thai Ubuntu local team as a solution
for Thai Ubuntu users:

  http://www.ubuntuclub.com/node/2970

It should benefit to have the patch merged into sid, to reduce the downstream
difference, until upstream decides something over it.

Regards,
-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=th_TH.UTF-8, LC_CTYPE=th_TH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libpango1.0-0 depends on:
ii  fontconfig                    2.8.0-2.1  generic font configuration library
ii  libc6                         2.11.2-13  Embedded GNU C Library: Shared lib
ii  libcairo2                     1.10.2-6   The Cairo 2D vector graphics libra
ii  libfontconfig1                2.8.0-2.1  generic font configuration library
ii  libfreetype6                  2.4.4-1    FreeType 2 font engine, shared lib
ii  libglib2.0-0                  2.28.2-1   The GLib library of C routines
ii  libthai0                      0.1.15-1   Thai language support library
ii  libx11-6                      2:1.4.2-1  X11 client-side library
ii  libxft2                       2.2.0-2    FreeType-based font drawing librar
ii  libxrender1                   1:0.9.6-1  X Rendering Extension client libra

Versions of packages libpango1.0-0 recommends:
ii  x-ttcidfont-conf              32         TrueType and CID fonts configurati

Versions of packages libpango1.0-0 suggests:
pn  ttf-arphic-bkai00mp           <none>     (no description available)
pn  ttf-arphic-bsmi00lp           <none>     (no description available)
pn  ttf-arphic-gbsn00lp           <none>     (no description available)
pn  ttf-arphic-gkai00mp           <none>     (no description available)
ii  ttf-baekmuk                   2.2-3      Baekmuk series TrueType fonts
ii  ttf-sazanami-gothic [ttf-japa 20040629-8 Sazanami Gothic Japanese TrueType 
ii  ttf-sazanami-mincho [ttf-japa 20040629-8 Sazanami Mincho Japanese TrueType 
pn  ttf-thryomanes                <none>     (no description available)

-- no debconf information

Index: pango1.0-1.24.3/modules/thai/thai-fc.c
===================================================================
--- pango1.0-1.24.3.orig/modules/thai/thai-fc.c	2009-06-21 17:37:22.000000000 +0700
+++ pango1.0-1.24.3/modules/thai/thai-fc.c	2009-06-21 17:38:02.000000000 +0700
@@ -171,6 +171,8 @@
 
   if (G_UNLIKELY (!font_info))
     {
+      PangoFontMap *fontmap;
+
       /* No cached information not found, so we need to compute it
        * from scratch
        */
@@ -187,6 +189,26 @@
       else
 	font_info->font_set = THAI_FONT_TIS;
 
+      /* check if the font is monospace */
+      font_info->is_monospace = FALSE;
+      fontmap = pango_font_get_font_map (font);
+      if (fontmap)
+        {
+          PangoFontFamily **families;
+          int n_families, i;
+
+          pango_font_map_list_families (fontmap, &families, &n_families);
+          for (i = 0; i < n_families; i++)
+            {
+              if (pango_font_family_is_monospace (families[i]))
+                {
+                  font_info->is_monospace = TRUE;
+                  break;
+                }
+            }
+          g_free (families);
+        }
+
       g_object_set_qdata_full (G_OBJECT (font), info_id, font_info, (GDestroyNotify)g_free);
     }
 
Index: pango1.0-1.24.3/modules/thai/thai-shaper.c
===================================================================
--- pango1.0-1.24.3.orig/modules/thai/thai-shaper.c	2009-06-21 17:37:26.000000000 +0700
+++ pango1.0-1.24.3/modules/thai/thai-shaper.c	2009-06-21 17:38:02.000000000 +0700
@@ -164,7 +164,8 @@
     {
       case 1:
 	if (is_char_type (cluster[0],
-			  BelowVowel|BelowDiac|AboveVowel|AboveDiac|Tone|SaraAm))
+			  BelowVowel|BelowDiac|AboveVowel|AboveDiac|Tone)
+	    || (is_char_type (cluster[0], SaraAm) && !font_info->is_monospace))
 	  {
 	    gint n;
 	    glyph_lists[0] = get_null_base_glyph (font_info);
Index: pango1.0-1.24.3/modules/thai/thai-shaper.h
===================================================================
--- pango1.0-1.24.3.orig/modules/thai/thai-shaper.h	2009-06-21 17:37:35.000000000 +0700
+++ pango1.0-1.24.3/modules/thai/thai-shaper.h	2009-06-21 17:38:02.000000000 +0700
@@ -50,6 +50,7 @@
 {
   PangoFont       *font;
   ThaiFontSet      font_set;
+  gboolean         is_monospace;
 };
 
 /*

--- End Message ---
--- Begin Message ---
Version: 1.32.5-1

This bug has been obsoleted by the HarfBuzz replacement.

--
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/

--- End Message ---

Reply via email to