Your message dated Mon, 07 Jul 2014 16:00:35 +0000
with message-id <[email protected]>
and subject line Bug#736417: fixed in tcpflow 1.4.4+repack1-3
has caused the Debian Bug report #736417,
regarding tcpflow prints "write error to stdout" after every packet
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
736417: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736417
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tcpflow
Version: 1.4.4+repack1-2
Severity: normal

tcpflow prints "write error to stdout" after every packet. This is printed when 
the expected length and the actually written length are different, in tcpip.c 
line 272.
The root cause is that the written length is not calculated correctly.

On line 265, written is incremented by the output of fputc(), which seems to be 
assumed to be 1 in case a character is successfully written. However, fputc() 
is defined as returning the character actually written. One solution would be:

--- tcpflow-1.4.4+repack1.orig/src/tcpip.cpp
+++ tcpflow-1.4.4+repack1/src/tcpip.cpp
@@ -262,7 +262,7 @@ void tcpip::print_packet(const u_char *d
     else if(demux.opt.output_strip_nonprint){
        for(const u_char *cc = data;cc<data+length;cc++){
            if(isprint(*cc) || (*cc=='\n') || (*cc=='\r')){
-               written += fputc(*cc,stdout);
+               written += (fputc(*cc,stdout)!=EOF);
            }
        }
     }


Frank

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tcpflow depends on:
ii  libbz2-1.0         1.0.6-5
ii  libc6              2.17-97
ii  libcairo2          1.12.16-2
ii  libexpat1          2.1.0-4
ii  libfontconfig1     2.11.0-2
ii  libfreetype6       2.5.2-1
ii  libgcc1            1:4.8.2-13
ii  libhttp-parser2.1  2.1-2
ii  libpcap0.8         1.5.2-1
ii  libpixman-1-0      0.32.4-1
ii  libsqlite3-0       3.8.2-1
ii  libssl1.0.0        1.0.1f-1
ii  libstdc++6         4.8.2-13
ii  zlib1g             1:1.2.8.dfsg-1

tcpflow recommends no packages.

Versions of packages tcpflow suggests:
ii  tcpdump  4.5.1-2

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: tcpflow
Source-Version: 1.4.4+repack1-3

We believe that the bug you reported is fixed in the latest version of
tcpflow, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dima Kogan <[email protected]> (supplier of updated tcpflow package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 31 May 2014 12:49:51 -0700
Source: tcpflow
Binary: tcpflow tcpflow-nox tcpflow-dbg
Architecture: source amd64
Version: 1.4.4+repack1-3
Distribution: unstable
Urgency: medium
Maintainer: Dima Kogan <[email protected]>
Changed-By: Dima Kogan <[email protected]>
Description:
 tcpflow    - TCP flow recorder
 tcpflow-dbg - TCP flow recorder - debug symbols
 tcpflow-nox - TCP flow recorder - version without X11 dependencies
Closes: 729360 734064 736417
Changes:
 tcpflow (1.4.4+repack1-3) unstable; urgency=medium
 .
   * Bug fix: "tcpflow with no -i doesn't work", thanks to
     [email protected]; (Closes: #734064).
   * Bug fix: "tcpflow prints "write error to stdout" after every
     packet", thanks to Frank Gevaerts (Closes: #736417).
   * I now build a 'tcpflow-nox' package to provide a tcpflow without
     dependencies on x11 (Closes: #729360).
   * Bumped Standards-Version to 3.9.5; no changes necessary
Checksums-Sha1:
 fc054ef3a8de3006307ddc9ffa642e91f65306e9 2089 tcpflow_1.4.4+repack1-3.dsc
 1bb52713dd7b406364f44fad32272cc054aef3b9 525060 
tcpflow_1.4.4+repack1.orig.tar.gz
 9f6fbe89b53c34a4a05e3abd115ea52028e21cf6 12244 
tcpflow_1.4.4+repack1-3.debian.tar.xz
 768c34a553aa03715c3a57793266771858a2c639 228456 
tcpflow_1.4.4+repack1-3_amd64.deb
 35affc0d7a94aa25d411f4dfbfdc82aea94869ff 184648 
tcpflow-nox_1.4.4+repack1-3_amd64.deb
 96bc72117b7206d004bfb29c59c98f52c70ef44b 7106764 
tcpflow-dbg_1.4.4+repack1-3_amd64.deb
Checksums-Sha256:
 af3a1d892f5afcdabd1158d8de552d8956e30cc0f0fbe865b3db852c09d46f7a 2089 
tcpflow_1.4.4+repack1-3.dsc
 3269742db7acc51ce0ae8bfbe3dfe536654694e276032555f1e825c6f463711f 525060 
tcpflow_1.4.4+repack1.orig.tar.gz
 e006b5c6288bbc46e01a8488f7bf448ddd97ac454fe906764ddc3c03696b1a4b 12244 
tcpflow_1.4.4+repack1-3.debian.tar.xz
 51b23a3cbe007c9d1423787bf0552768b2cbaed4e596f95ad07ff64ffa7a41e3 228456 
tcpflow_1.4.4+repack1-3_amd64.deb
 2ab26fe7f91fb1b59c0fcb0908f7ceefb5c08271b72c09426abdbcddb95b1d8e 184648 
tcpflow-nox_1.4.4+repack1-3_amd64.deb
 289bf7f4f2d725c2655b5d1e41965f73866f52f5dae7b83dcd7030d19d05e854 7106764 
tcpflow-dbg_1.4.4+repack1-3_amd64.deb
Files:
 40ed0ac085d15e731cb04a8f25a870d6 228456 net optional 
tcpflow_1.4.4+repack1-3_amd64.deb
 58b87754b1f4edd9f9d929d44ebd253e 184648 net optional 
tcpflow-nox_1.4.4+repack1-3_amd64.deb
 837c44c3d8e4eaa0f2c6f5d8a9eaec09 7106764 debug extra 
tcpflow-dbg_1.4.4+repack1-3_amd64.deb
 43af2f88df7572c58f5c867d5c98f485 2089 net optional tcpflow_1.4.4+repack1-3.dsc
 49191520ce16ad3ce5044f01b0ca1e6b 525060 net optional 
tcpflow_1.4.4+repack1.orig.tar.gz
 bae3b29b9fde635db52ab4f75757ff02 12244 net optional 
tcpflow_1.4.4+repack1-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJTldehAAoJENPhc4PPp/8Gvp0P/0krkRJKXZQwck6GdAIXXnO/
fg8/7LRCUpgiT1Blz15FC5pT1KtWYioOuL1lWt1wRaOQXQxJPAeWBkoeHT+ukGbb
ujZumUEqndgH+yKru42Kg0g3koohwm/BQEkoWrmc1sixib78nt78LOk+KhMuRh89
2nw6FoWj5G8ZyyFXRnRk7mZr+5r51NnDtVMtWweEV5eotcewT61NlKRXhRCmmmf7
Ks7tnENGQs+ylPPJa/j3hfP6bkxgKkHW67+IfHM1e5w7VZNKcVQVFZKRezWnYiYo
8zXd62WLYbARzSRTPd2p2vC/MBtPabvR9qZPF3WGbnIL7i6hDPKab+TgsHZej/ew
Fsb+ixv3e36WUgECKzhSnUfJBZkMsHTtLgfCtckDmMMrSunVkhYFAI2fvFV3SS7M
Wtbg7Tx28bobPSZkDl3bNgRDhRr0/n61rUes/1SbKfvk8VyK+0cq1ofJR1/+SzDu
yOwCtywiU98TSiGRg2VWW9dIaO4crBn3ZDf2pPH6NxOesoFTBWMr8XECIejNpc9U
BEj2V18l6Oj92nCk7ddHXgbL/2PUnLtAhaARY+ULFJy55CNhZ7DbGfJg/XlV1A/H
uw55BAAQ6KbPm+RpWXIkwwdhpq8TIeQXRq2WsZ24g5KYxM445+9lBz+KhmfwmaOg
NpThks2SjFUKiZeHf/C5
=Ay9H
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to