Your message dated Fri, 24 Oct 2014 13:19:14 +0000
with message-id <[email protected]>
and subject line Bug#764246: fixed in fai 4.3
has caused the Debian Bug report #764246,
regarding fai-client: please also call savelog hooks on failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
764246: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764246
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-client
Version: 4.0.8~deb7u1
Severity: wishlist
Tags: patch
Dear Maintainer,
when using a savelog hook to replace the savelog functionality with a
custom variant (and using skip to make sure the original hook is not
run), this currently only works if the installation is successful, but
not if an error occurred. Unfortunately, the error case is the one that
is far more important for an administrator.
I've attached a patch against current git master that makes sure the
hooks for savelog are also called on failure. The patch should also
apply against older versions. The patch also makes sure that if another
earlier hook made the call to skip savelog, this will also be honored.
Thanks!
From 8542d992bef188c3c58b649455bf24ee288b305e Mon Sep 17 00:00:00 2001
From: Christian Seiler <[email protected]>
Date: Mon, 6 Oct 2014 17:43:56 +0200
Subject: [PATCH] On failure: also call hooks for savelog
If one uses savelog hooks to replace the existing functionality with
something different, or to do some additional action at that point that
may be required for savelog to work, make sure the hooks are also
called on failure, not only if the installation is successful.
---
lib/subroutines | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/subroutines b/lib/subroutines
index 16d5de5..8981fbc 100755
--- a/lib/subroutines
+++ b/lib/subroutines
@@ -34,7 +34,8 @@
die() {
# echo comment and exit installation
- task_savelog
+ [ -f $LOGDIR/skip.$taskname ] || call_hook savelog
+ [ -f $LOGDIR/skip.$taskname ] || task_savelog
echo "$@"
if [ X$FAI_ACTION = Xinstall ]; then
exec bash -i
--
1.7.10.4
--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 4.3
We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 24 Oct 2014 14:34:46 +0200
Source: fai
Binary: fai-client fai-doc fai-server fai-quickstart fai-nfsroot
fai-setup-storage
Architecture: source all
Version: 4.3
Distribution: unstable
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Description:
fai-client - Fully Automatic Installation client package
fai-doc - Documentation for FAI
fai-nfsroot - Fully Automatic Installation nfsroot package
fai-quickstart - Fully Automatic Installation quickstart package
fai-server - Fully Automatic Installation server package
fai-setup-storage - automatically prepare storage devices
Closes: 764246
Changes:
fai (4.3) unstable; urgency=low
.
[Kerim Güney]
* add btrfs support to setup-storage and to the man page
* Fix a small LVM bug concerning VG names
.
[Thomas Lange]
* make jessie the default release
* mk-basefile: add jessie
* NFSROOT: add pxelinux and syslinux-common instead of defining package
dependency
* fai-make-nfsroot: also copy ldlinux.c32 from the nfsroot
* task_inventory now calls task_savelog -r
* fcpoy: add warning if pre/postinst script is not executable
* dhcp-edit: drop support for old dhcp pathes
* fai-chboot: add option -U
* disk_config: increase size of / partition
.
[Christian Seiler]
* subroutine: On failure: also call hooks for savelog, Closes: #764246
.
[ Andreas B. Mundt]
* Restore capabilities that get lost in the base.tar.xz archive
Checksums-Sha1:
b9a417ed6f68dae077ed4c67f7e615ddc8f09bfb 1881 fai_4.3.dsc
2747e227b77b0e6e342a5b1d222c53544a475e0d 287328 fai_4.3.tar.xz
fb59c25ea7befb5a3de36d88b4b0dbd473fc0e1e 132354 fai-client_4.3_all.deb
0f380d4ccd53744b3748548371e65ac41554fb8c 825036 fai-doc_4.3_all.deb
6d46a4ada02d18bf4cb82e8e2938c7080847df19 61778 fai-server_4.3_all.deb
80032167a6dca24adc96c9b05ec2a7e56acb064b 1354 fai-quickstart_4.3_all.deb
ea568a8bf7fc8879bd750c08b2709a2556f94077 78124 fai-nfsroot_4.3_all.deb
e2657cb1472cf0a2997787c64144b32793d3e0ed 116290 fai-setup-storage_4.3_all.deb
Checksums-Sha256:
9988ebaeb2c86551619bc519318aeef605268e0be5f51ca6c73b5062d902d6cf 1881
fai_4.3.dsc
486002c14d4061a1ab0bde0ef10c1bfb7bde32a9a57c8feda667c4963fe136d1 287328
fai_4.3.tar.xz
c9ac0ec33e7c390c2b63e390f092a835aa55e55d3d53541f29f277b1225f5478 132354
fai-client_4.3_all.deb
bb1d972922cbc3493e5fbb477eb6c7bc17992a10af384afc0a33048cfea5fb23 825036
fai-doc_4.3_all.deb
3ce490c633d7819731fd44cde5aa11d8aa46ef8abb4eaabb50336a4285641219 61778
fai-server_4.3_all.deb
27dbc027d24168d0be20c6bb18d3408d8020c6bb7c24cba00df6efe4d6cd0554 1354
fai-quickstart_4.3_all.deb
ea6dedc3588f9403963fe1d02c4bc3f911b5254893e1e5f2d4f339980143cafb 78124
fai-nfsroot_4.3_all.deb
b044c803c4e0b1b7439ecd91a5937a54420e68bf7548bc825b35ae35bbe4b4fa 116290
fai-setup-storage_4.3_all.deb
Files:
3ffc0fd05251b0f7e1cbe819c72b8cb2 132354 admin extra fai-client_4.3_all.deb
4be752c96d4018b27f56c56c7bf2b50e 825036 doc extra fai-doc_4.3_all.deb
d59b3a2f9b21b7a821242200bf21425b 61778 admin extra fai-server_4.3_all.deb
1928c109c186ba43ff73cb4c9e982f98 1354 admin extra fai-quickstart_4.3_all.deb
b348969c56ef10a20096e5b2ce418de3 78124 admin extra fai-nfsroot_4.3_all.deb
5c3eafb389d8a13e2fa25ec4919f2b74 116290 admin extra
fai-setup-storage_4.3_all.deb
e27584782975f7418d1c2d435f267fb5 1881 admin extra fai_4.3.dsc
028b0ab20f4d8820126a1f780fcdec9a 287328 admin extra fai_4.3.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJUSke7AAoJECv42f4HS83k+/oP/j3fTNhbZFNe5O5jupLcr1B9
GoqewKcr2KvTvKx9Muk8zPdGXMzG7WG175+YPCDDdr2jJu4rAQJIKQGJN5xC9qLP
F208DyZFEC5nSEuChbuq4/33Uc0zCIU+GbNAScPJvYy0hswClVRk+WgDh9CBrdmM
L7LN+SiFAS+/oaG/ROfN3BxL0aQ5J+SJR/No/RajbL119biKwnVCtKDRmB/GPDj0
PTdy5eqn2lQvjPFHp6AD6BeYg1L6o7pSe5lZbo+GidoxogJYJLOeLN1nCR620u3g
xfMy6yJ4I5UVh7fA+UPuuQpoI3z0ujAcNNyhcdpnmtENjvNVn/V7jNLEpYvMuxAW
o8WpSBl2eZLNT4wvAxJZedG1MAtUAJUhY6uc9Xx9oNm9j5fGuoLXW6r6Q+xFtZP3
QFl2QwHa/o19lNLSF6gJC1PHbXc3oXWUI8/WZbg3nGIhRU2W3ebJ0dQ3NBA4h/g/
GF8oEWyzY8s2gXQGMx3En31m7FbCetuoGbEo7Kn4++WUEszuh759+0802sKi8lP3
+PApWPck+ZgCX+B5NRVSKyydbSs+ba2Hpp460fM370S3oHDZLxDXxK5niJZcL9Jh
kwFy32eWHPLP9D05ZjI/3mRRKSlSUPADOzpLzUUcKo4y1H9ltBC3Wz8V5AlXa3M/
iu3RNNjnDKKpQ1BxeGO8
=mwXh
-----END PGP SIGNATURE-----
--- End Message ---
