Your message dated Sat, 17 Dec 2016 18:18:36 +0000
with message-id <[email protected]>
and subject line Bug#847482: fixed in cinnamon-session 3.2.0-1
has caused the Debian Bug report #847482,
regarding cinnamon-session: Qt theme overrides no longer work on Qt >= 5.7
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
847482: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847482
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cinnamon-session
Version: 3.0.1-2
Control: block -1 by 822246 843257
Dear maintainers,
Qt 5.7 moved the GTK+ 2 theme engine from qtbase to qt-style-plugins[1].
In the process, this caused the old setting of QT_STYLE_OVERRIDE=gtk to
stop working, so Qt 5 programs will default to the out-of-place Fusion
theme.
A backported fix from upstream to fix this is attached: it sets Qt to
use qt5ct as a backend, which in turn allows the user to specify what Qt
5 theme to use globally. However, neither qt5ct[2] nor the new
qt5-style-plugins with GTK+2 support[3] have made it into Debian yet, so
there may be a need for a simpler fix.
Best,
James
[1]:
https://github.com/qt/qtstyleplugins/commit/102da7d50231fc5723dba6e72340bef3d29471aa
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822246
[3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843257
Description: Make QT5 apps follow the GTK style on Qt >= 5.7
Origin: upstream, https://github.com/linuxmint/cinnamon-session/pull/75
Last-Update: 2016-12-08
Bug: https://github.com/linuxmint/Cinnamon/issues/5440
Index: cinnamon-session/cinnamon-session/main.c
===================================================================
--- cinnamon-session.orig/cinnamon-session/main.c 2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/cinnamon-session/main.c 2016-11-24 22:33:52.229384394 -0800
@@ -296,6 +296,7 @@
{ "whale", 0, 0, G_OPTION_ARG_NONE, &please_fail, N_("Show the fail whale dialog for testing"), NULL },
{ NULL, 0, 0, 0, NULL, NULL, NULL }
};
+ char *qt_platform_theme_new = NULL;
/* Make sure that we have a session bus */
if (!require_dbus_session (argc, argv, &error)) {
@@ -383,8 +384,23 @@
*/
csm_util_setenv ("GNOME_DESKTOP_SESSION_ID", "this-is-deprecated");
- /* Make QT5 apps follow the GTK style */
- csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+ /* Make QT5 apps follow the GTK style. Starting with QT 5.7, a different
+ * env var has to be set than what worked in previous versions.
+ */
+ qt_platform_theme_new = HAVE_QT57 ? "qt5ct" : "qgnomeplatform";
+
+ if (NULL == g_getenv ("QT_QPA_PLATFORMTHEME")) {
+ csm_util_setenv ("QT_QPA_PLATFORMTHEME", qt_platform_theme_new);
+ }
+
+ if ( ! HAVE_QT57 && NULL == g_getenv ("QT_STYLE_OVERRIDE") ) {
+ csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+ } else if (HAVE_QT57 && NULL != g_getenv ("QT_STYLE_OVERRIDE")) {
+ g_unsetenv ("QT_STYLE_OVERRIDE");
+ }
+
/* GTK Overlay scrollbars */
settings = g_settings_new ("org.cinnamon.desktop.interface");
Index: cinnamon-session/configure.ac
===================================================================
--- cinnamon-session.orig/configure.ac 2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/configure.ac 2016-11-24 22:33:55.000000000 -0800
@@ -108,6 +108,20 @@
AC_SUBST(LOGIND_LIBS)
dnl ====================================================================
+dnl Check for qt 5.7+ to set correct env var for theme/styling
+dnl ====================================================================
+AC_ARG_ENABLE(qt57_theme_support,
+ AS_HELP_STRING([--enable-qt57-theme-support], [Support GTK styles for QT apps with QT 5.7+]),
+ [enable_qt57_theme_support=yes],
+ [enable_qt57_theme_support=no])
+
+if test x$enable_qt57_theme_support = xyes; then
+ AC_DEFINE([HAVE_QT57], [1], [Have QT 5.7+])
+else
+ AC_DEFINE([HAVE_QT57], [0], [Have QT 5.7+])
+fi
+
+dnl ====================================================================
dnl X development libraries check
dnl ====================================================================
@@ -349,12 +363,13 @@
GConf support: ${enable_gconf}
Logind support: ${have_logind}
+ Qt 5.7+ theme support: ${enable_qt57_theme_support}
IPv6 support: ${have_full_ipv6}
Backtrace support: ${have_backtrace}
XRender support: ${have_xrender}
XSync support: ${have_xsync}
XTest support: ${have_xtest}
- Legacy UPower backend: ${have_old_upower}
+ Legacy UPower backend: ${have_old_upower}
Build documentation: ${enable_docbook_docs}
"
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: cinnamon-session
Source-Version: 3.2.0-1
We believe that the bug you reported is fixed in the latest version of
cinnamon-session, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Maximiliano Curia <[email protected]> (supplier of updated cinnamon-session
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 17 Dec 2016 19:02:35 +0100
Source: cinnamon-session
Binary: cinnamon-session cinnamon-session-common
Architecture: source
Version: 3.2.0-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Cinnamon Team <[email protected]>
Changed-By: Maximiliano Curia <[email protected]>
Description:
cinnamon-session - Cinnamon Session Manager - Minimal runtime
cinnamon-session-common - Cinnamon Session Manager - common files
Closes: 847482
Changes:
cinnamon-session (3.2.0-1) experimental; urgency=medium
.
[ Margarita Manterola ]
* New upstream release.
* Add patch to use the "gtk2" theme engine when running under qt5.
Thanks to James Lu for reporting. (Closes: #847482)
.
[ Maximiliano Curia ]
* Drop upstream applied patch: gnome-common-deprecation.patch
Checksums-Sha1:
c2dae7742e310dc14347461c066d830749d5df8b 2598 cinnamon-session_3.2.0-1.dsc
def7f1a692151cd0d4c9d9eb6a88e45d35cf5fce 593282
cinnamon-session_3.2.0.orig.tar.gz
927d23b2fe7d6ba64b15ce8c1de153e876dcbba9 6132
cinnamon-session_3.2.0-1.debian.tar.xz
Checksums-Sha256:
ebd4a1dcafd89d68e2fc63cac9af7cb90e0fb70b6a7e52c11320135e8cc3af9f 2598
cinnamon-session_3.2.0-1.dsc
ce985b9dfa45f7994e8a9476d9261d003586cd76c903b1e9cbf82f587a7a41ab 593282
cinnamon-session_3.2.0.orig.tar.gz
629ecac850ae251910e60a98482a9fe51adaf8ed88570f781bf011380fe5aed8 6132
cinnamon-session_3.2.0-1.debian.tar.xz
Files:
da0d947d496bd6957db582f1417b8aba 2598 x11 optional cinnamon-session_3.2.0-1.dsc
5ded0838643fde945ae3768d4fe7e770 593282 x11 optional
cinnamon-session_3.2.0.orig.tar.gz
f1a4349274ace63e893172c91341636e 6132 x11 optional
cinnamon-session_3.2.0-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE+JIdOnQEyG4RNSIVxxl2mbKbIyoFAlhVfjUACgkQxxl2mbKb
IyoSyA//YyfE8uhTmEoXnNant4AY9JaErGbqMtdaICIZ53exFJFIAP/pcaPDxCG4
/teh/nEyiN962V1Zxz0OFPJaUqlc3op1YiEMc1Q3KS9NJt2FP5I0B62MEEtRudSD
fN4VCGIvKlfCs0Fuo+4SG+L+PPRPqHlxpVEpcDNq+WVvMzdSdG2NsDcz/Vd9r3//
Vtm7MoUOrR0SfmbUROXqiOrw/KxwrfgNPnPisWOiWE5BeXrSJKI00FbXAaviwmvT
dOyrbthsLDSXintEuMqw8f30Ro//aTU1vMsCzszEvJ9cxyiUNRjP0HH9joSSywqX
alWDx3Vs4sjrvVgYPB48iOb3T3hKRhfjkGGROa+XrgxKM5EEO4ITfa5cfk4dFtC4
DSm83a/+JvRyeJooXqAdkmCoVja8vNBldjHQnQ/DB7hY6sXgcIVMUmCLv7gRZSpE
jwnnk+6z8UIha7Evreri4nrfOKGxlbSk2RcfPb6ATQh9bsmaXWDm2UWgoE34Bv2v
se1QywbqtvUs5r8yr/nfK4yKiyTYeCX+eyZJNvg2chtmZqKE2VUgYq1TvkCwY+FV
z8bzSR6MMTlU5zMXPZhznCVGHnqSOLkbX32TSsZHyyhGtW4Ii0tQta2XxoJ5x9h6
GstvlSYJZc7pWhO10X0Xnh36439PONbyTztJazbl9xWA2lTqZkQ=
=sTTb
-----END PGP SIGNATURE-----
--- End Message ---
