Your message dated Tue, 03 Jan 2017 21:04:17 +0000
with message-id <[email protected]>
and subject line Bug#847482: fixed in cinnamon-session 3.2.0-4
has caused the Debian Bug report #847482,
regarding cinnamon-session: Qt theme overrides no longer work on Qt >= 5.7
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
847482: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847482
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cinnamon-session
Version: 3.0.1-2
Control: block -1 by 822246 843257
Dear maintainers,
Qt 5.7 moved the GTK+ 2 theme engine from qtbase to qt-style-plugins[1].
In the process, this caused the old setting of QT_STYLE_OVERRIDE=gtk to
stop working, so Qt 5 programs will default to the out-of-place Fusion
theme.
A backported fix from upstream to fix this is attached: it sets Qt to
use qt5ct as a backend, which in turn allows the user to specify what Qt
5 theme to use globally. However, neither qt5ct[2] nor the new
qt5-style-plugins with GTK+2 support[3] have made it into Debian yet, so
there may be a need for a simpler fix.
Best,
James
[1]:
https://github.com/qt/qtstyleplugins/commit/102da7d50231fc5723dba6e72340bef3d29471aa
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822246
[3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843257
Description: Make QT5 apps follow the GTK style on Qt >= 5.7
Origin: upstream, https://github.com/linuxmint/cinnamon-session/pull/75
Last-Update: 2016-12-08
Bug: https://github.com/linuxmint/Cinnamon/issues/5440
Index: cinnamon-session/cinnamon-session/main.c
===================================================================
--- cinnamon-session.orig/cinnamon-session/main.c 2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/cinnamon-session/main.c 2016-11-24 22:33:52.229384394 -0800
@@ -296,6 +296,7 @@
{ "whale", 0, 0, G_OPTION_ARG_NONE, &please_fail, N_("Show the fail whale dialog for testing"), NULL },
{ NULL, 0, 0, 0, NULL, NULL, NULL }
};
+ char *qt_platform_theme_new = NULL;
/* Make sure that we have a session bus */
if (!require_dbus_session (argc, argv, &error)) {
@@ -383,8 +384,23 @@
*/
csm_util_setenv ("GNOME_DESKTOP_SESSION_ID", "this-is-deprecated");
- /* Make QT5 apps follow the GTK style */
- csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+ /* Make QT5 apps follow the GTK style. Starting with QT 5.7, a different
+ * env var has to be set than what worked in previous versions.
+ */
+ qt_platform_theme_new = HAVE_QT57 ? "qt5ct" : "qgnomeplatform";
+
+ if (NULL == g_getenv ("QT_QPA_PLATFORMTHEME")) {
+ csm_util_setenv ("QT_QPA_PLATFORMTHEME", qt_platform_theme_new);
+ }
+
+ if ( ! HAVE_QT57 && NULL == g_getenv ("QT_STYLE_OVERRIDE") ) {
+ csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+ } else if (HAVE_QT57 && NULL != g_getenv ("QT_STYLE_OVERRIDE")) {
+ g_unsetenv ("QT_STYLE_OVERRIDE");
+ }
+
/* GTK Overlay scrollbars */
settings = g_settings_new ("org.cinnamon.desktop.interface");
Index: cinnamon-session/configure.ac
===================================================================
--- cinnamon-session.orig/configure.ac 2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/configure.ac 2016-11-24 22:33:55.000000000 -0800
@@ -108,6 +108,20 @@
AC_SUBST(LOGIND_LIBS)
dnl ====================================================================
+dnl Check for qt 5.7+ to set correct env var for theme/styling
+dnl ====================================================================
+AC_ARG_ENABLE(qt57_theme_support,
+ AS_HELP_STRING([--enable-qt57-theme-support], [Support GTK styles for QT apps with QT 5.7+]),
+ [enable_qt57_theme_support=yes],
+ [enable_qt57_theme_support=no])
+
+if test x$enable_qt57_theme_support = xyes; then
+ AC_DEFINE([HAVE_QT57], [1], [Have QT 5.7+])
+else
+ AC_DEFINE([HAVE_QT57], [0], [Have QT 5.7+])
+fi
+
+dnl ====================================================================
dnl X development libraries check
dnl ====================================================================
@@ -349,12 +363,13 @@
GConf support: ${enable_gconf}
Logind support: ${have_logind}
+ Qt 5.7+ theme support: ${enable_qt57_theme_support}
IPv6 support: ${have_full_ipv6}
Backtrace support: ${have_backtrace}
XRender support: ${have_xrender}
XSync support: ${have_xsync}
XTest support: ${have_xtest}
- Legacy UPower backend: ${have_old_upower}
+ Legacy UPower backend: ${have_old_upower}
Build documentation: ${enable_docbook_docs}
"
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: cinnamon-session
Source-Version: 3.2.0-4
We believe that the bug you reported is fixed in the latest version of
cinnamon-session, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Maximiliano Curia <[email protected]> (supplier of updated cinnamon-session
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 03 Jan 2017 21:45:03 +0100
Source: cinnamon-session
Binary: cinnamon-session cinnamon-session-common
Architecture: source
Version: 3.2.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Cinnamon Team <[email protected]>
Changed-By: Maximiliano Curia <[email protected]>
Description:
cinnamon-session - Cinnamon Session Manager - Minimal runtime
cinnamon-session-common - Cinnamon Session Manager - common files
Closes: 847482
Changes:
cinnamon-session (3.2.0-4) unstable; urgency=medium
.
* Add missing qt5 build parameter. (Closes: #847482)
Thanks to James Lu for reporting.
Checksums-Sha1:
51d804a8d058b4b1ce2481b11792af411c1e90fa 2608 cinnamon-session_3.2.0-4.dsc
dbc95e6cc30f712ca39c0a02ec5d8316af63d75e 6256
cinnamon-session_3.2.0-4.debian.tar.xz
Checksums-Sha256:
b01351ac78c484cdbc185f924824cdf9304696328c8962ca2c298acd5963c726 2608
cinnamon-session_3.2.0-4.dsc
ed7890cd4de0ef07b3a7c1939aad45530093bccda5c24a689fbbfe66987991d1 6256
cinnamon-session_3.2.0-4.debian.tar.xz
Files:
8bfff928a4345fab86ca4e42d65e8f4e 2608 x11 optional cinnamon-session_3.2.0-4.dsc
65293582c39f44724006162a7b4053aa 6256 x11 optional
cinnamon-session_3.2.0-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE+JIdOnQEyG4RNSIVxxl2mbKbIyoFAlhsEEkACgkQxxl2mbKb
IyrtPg//btZL/oRmeEWWJZNOtSFfwUJMdt36uuKkBCZpD3rKgahUkD5xkujTNvUG
afHAM8ppyNxkMQUPvVkpTDwlNjKdiK6UTMRF5tUI1Zsk5bdAo1MEA43tGkHa7fh8
xNkfkzSI+bQm+jQL2R/LIXXEY5zt49wEDOleilP9tGKhqeMiVnIsjQgsOuzYtdrr
FFQ41o3vQbqg3O2xFI0jT75aPiyZl6LiIcOP5l++dk2qssjCNoQJfa/8vjPY1+fy
RTRDmLK2sswVjRqoVVnCfMZoQOIjGIggjhhA4ulw185WJHFZ9+53VX58GpFBVwbH
xfC6xbtjnfXfWYaRCNo23I+jAf19izpPtBEJ4LEC7yLTvGwH/VUi4qrvJAyXJCxr
8SmhwLmuGt4KeH/E+w79idxp7+QJk4YGxaxsg96Sbh5ddjOYD2SelrBEzL7D7Gms
MTyiJtGAIh4/GYEEni0M48JMhKBiUG+tWSrvbzAGJ+waUxNwTnXqhOWRG6Gpi2SO
SZLsmcqcRS+EfLL5aCFnybZOmjREnRfBeHojZX2Gx2eBgNqeBBcffta/KqiQCKCo
XLjicJ7tXERcF+rbtNflB0RRepm7X8zxPGRjalrzhwqAA5wisT3+OSoSw28FePzJ
sDtkcKst5bxRYKMkWC2NVbs5CQHifDmMJtduU4I1uEEsk+sriIE=
=/7lW
-----END PGP SIGNATURE-----
--- End Message ---
