Your message dated Sat, 18 Mar 2017 06:52:20 +0000
with message-id <[email protected]>
and subject line Bug#857424: fixed in orthanc-dicomweb 0.3+dfsg-2
has caused the Debian Bug report #857424,
regarding orthanc-dicomweb: Libraries manually set in wrong order
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
857424: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857424
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: orthanc-dicomweb
Version: 0.3+dfsg-1
Severity: normal
Tags: patch
Dear Maintainer,
Similar issue as reported for orthanc-webviewer 2.2-1 in bug #857355.
Currently the file debian/patches/cmake is removing cmake's automatic
library linking resolution and adding "missing" libraries manually,
while also unecessarily modifying a link_libraries call on
Orthanc/Resources/CMake/Compiler.cmake.
The uuid library ends up being added twice while linking
libOrthancWebViewer.so. I verified that this is no longer required.
The libraries are being added through LINK_FLAGS, which is not a good
practice. On make this would be the similar to adding libraries to
LD_FLAGS instead of LD_LIBS, which causes 'undefined reference' errors
when stric order is enabled (like in Ubuntu, where the package FTBFS).
I verified that cmake is able to successfully determine the required
gdcm libraries and that the library arguments in LINK_FLAGS can be
safely removed.
Please see the attached patch for the fix.
Regards,
Tiago Daitx
-- System Information:
Debian Release: stretch/sid
APT prefers xenial-updates
APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500,
'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.8.0-34-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru orthanc-dicomweb-0.3+dfsg/debian/patches/cmake orthanc-dicomweb-0.3+dfsg/debian/patches/cmake
--- orthanc-dicomweb-0.3+dfsg/debian/patches/cmake 2016-06-29 05:58:36.000000000 -0300
+++ orthanc-dicomweb-0.3+dfsg/debian/patches/cmake 2017-03-10 15:07:31.000000000 -0300
@@ -15,13 +15,7 @@
include(${ORTHANC_ROOT}/Resources/CMake/BoostConfiguration.cmake)
include(${ORTHANC_ROOT}/Resources/CMake/GoogleTestConfiguration.cmake)
-@@ -136,15 +136,13 @@ add_library(OrthancDicomWeb SHARED ${COR
- ${AUTOGENERATED_SOURCES}
- )
-
--target_link_libraries(OrthancDicomWeb ${GDCM_LIBRARIES})
--
- message("Setting the version of the library to ${ORTHANC_DICOM_WEB_VERSION}")
+@@ -142,9 +142,9 @@ add_library(OrthancDicomWeb SHARED ${COR
add_definitions(-DORTHANC_DICOM_WEB_VERSION="${ORTHANC_DICOM_WEB_VERSION}")
@@ -30,20 +24,7 @@
- SOVERSION ${ORTHANC_DICOM_WEB_VERSION}
+set_target_properties(OrthancDicomWeb PROPERTIES
+ NO_SONAME ON
-+ LINK_FLAGS "-lgdcmDICT -lgdcmDSED -lgdcmMSFF -lgdcmCommon -luuid -Wl,-soname,libOrthancDicomWeb.so.${ORTHANC_DICOM_WEB_VERSION}"
++ LINK_FLAGS "-Wl,-soname,libOrthancDicomWeb.so.${ORTHANC_DICOM_WEB_VERSION}"
)
install(
-Index: OrthancDicomWeb-0.3/Orthanc/Resources/CMake/Compiler.cmake
-===================================================================
---- OrthancDicomWeb-0.3.orig/Orthanc/Resources/CMake/Compiler.cmake
-+++ OrthancDicomWeb-0.3/Orthanc/Resources/CMake/Compiler.cmake
-@@ -60,7 +60,7 @@ if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux
- # Remove the "-rdynamic" option
- # http://www.mail-archive.com/[email protected]/msg08837.html
- set(CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS "")
-- link_libraries(uuid pthread rt)
-+ link_libraries(pthread rt)
-
- if (NOT ${CMAKE_SYSTEM_NAME} STREQUAL "FreeBSD")
- set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--as-needed")
--- End Message ---
--- Begin Message ---
Source: orthanc-dicomweb
Source-Version: 0.3+dfsg-2
We believe that the bug you reported is fixed in the latest version of
orthanc-dicomweb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastien Jodogne <[email protected]> (supplier of updated orthanc-dicomweb
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 17 Mar 2017 16:28:46 +0100
Source: orthanc-dicomweb
Binary: orthanc-dicomweb
Architecture: source
Version: 0.3+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Sebastien Jodogne <[email protected]>
Description:
orthanc-dicomweb - Plugin to extend Orthanc with support of WADO and DICOMweb
Closes: 857424
Changes:
orthanc-dicomweb (0.3+dfsg-2) unstable; urgency=medium
.
[ Tiago Sturmer Daitx <[email protected]> ]
* Fix linking of libraries. Closes: #857424
Checksums-Sha1:
4d844e4173060fbb5b0792b91cd42a7f7db9d613 2287 orthanc-dicomweb_0.3+dfsg-2.dsc
69afc850de4b04f88f83eaba4983b6230801f669 5156
orthanc-dicomweb_0.3+dfsg-2.debian.tar.xz
5ff4af662bdbcf0a27fe62a2c8ae02aecfa0c335 18480
orthanc-dicomweb_0.3+dfsg-2_source.buildinfo
Checksums-Sha256:
c83eca0cf9c6b0091c359ca8ffe19c7598551c0ca6943a5e16371ee90d2e1232 2287
orthanc-dicomweb_0.3+dfsg-2.dsc
2bc57e110bfd421cf534369a45f2cbbdf99e4daaafa1f9ae48aaacb6f4d18e51 5156
orthanc-dicomweb_0.3+dfsg-2.debian.tar.xz
a9b82d35a7100e32cdafae94c65fd9802806693a0756e3dfd22f60385b599195 18480
orthanc-dicomweb_0.3+dfsg-2_source.buildinfo
Files:
32af975f0302655f7676981d509f4d27 2287 science optional
orthanc-dicomweb_0.3+dfsg-2.dsc
c40fe2299d4e9c4a36461a730eed67d8 5156 science optional
orthanc-dicomweb_0.3+dfsg-2.debian.tar.xz
3941fcbd69989727e299a40895dac034 18480 science optional
orthanc-dicomweb_0.3+dfsg-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAljM09oRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtHjuw//WBEorh6903GFDP4GTa41hGB57qrQ7QzT
G5VbYiRFOGr6lXSawo9DtVQ4PwcUtRI2l6jZmtissEkpl9uEjR7thTzoZ/22PKiA
UpBkAtUju6JbDaH26fsXaBVlB6s3rrC7+P+XIdpuYtC5EFT9M7EOzy0d8Ph5gpZJ
YgdT6wmEaSRuDeBXgg9sFnQBhWon4iqhtUKyPvLsV0uGA6Q7R4HDPOZNXXS3nzdN
8YIXGMfdV/skfXwb66lZUK5ERB2P88Go6pyK8eAAO0RUJ4PYTTFve25s3WphT5Dw
mSX5iQwr2QN++f4AH/pN6yc60e1jCbQzfJ9ZRlRUDU1VuM3L2vWRW80uTQ4s4rOx
ZZhW2Qyoe3Vt1lelBTUn0fwOaCKfEmaNSS94vQ/IX/IHFi9jlwuZNwDUMjFylqb3
f7lbhljbihAtlyum00UE01EDRlYArLTNr4O6uPC65Ta4OsV3rHV3AAXUu5b04ZKR
0YyLGaNww9cOZzq/nxV8aV24ZrYdM9oHQsPB7+VEa0YiQUk4oPGi5TyuO9xdDAgQ
tWAeogt4tZ7mNqPFCzDq38y9ryWBwAcMeOgdWao6AYTcM/ceV21510AoRixjXHca
frDYqGyEEt8htcOHRrISzyv9mxQoJQa3OomZSTbDTqi4Iu19Aot6vkMNHC3NXmMS
4k50takOQ5c=
=wVD5
-----END PGP SIGNATURE-----
--- End Message ---
