Your message dated Sat, 18 Mar 2017 10:36:05 +0000
with message-id <[email protected]>
and subject line Bug#857619: fixed in matrix-synapse 0.19.2+dfsg-5
has caused the Debian Bug report #857619,
regarding matrix-synapse: Stop service if server name is not configured
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
857619: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857619
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: matrix-synapse
Version: 0.19.2+dfsg-4
Severity: normal
Tags: patch
Dear Maintainer,
Currently if the domain name is not known, and the user simply presses enter on
the
debconf page, the install completes but the
/etc/matrix-synapse/conf.d/server_name.yaml
is not written and a package installtion error happens. This prevents that by
failing gracefully.
Also domain name cannot be changed after its configured and the service is used.
This allows the user to make an informed decision before setting a proper
domain
name rather that something temporary which is hard to be changed later on.
I have also raised this with the upstream developers too.
>From 7fb9a42437c09e8821541f26bf137b513b7ac343 Mon Sep 17 00:00:00 2001
From: Rahul De <[email protected]>
Date: Mon, 13 Mar 2017 14:12:52 +0530
Subject: [PATCH] Fail silently if server name is not configured
- This is for the scenario of the user not setting the server name in debconf
when the FQDN isn't known.
- That results in /etc/matrix-synapse/conf.d/server_name.yaml not being present.
- This prevents the service from starting util the file is present.
---
debian/matrix-synapse.init | 4 ++++
debian/matrix-synapse.service | 1 +
2 files changed, 5 insertions(+)
diff --git a/debian/matrix-synapse.init b/debian/matrix-synapse.init
index 905bd3c..9d27bca 100755
--- a/debian/matrix-synapse.init
+++ b/debian/matrix-synapse.init
@@ -20,6 +20,7 @@ PATH=/sbin:/usr/sbin:/bin:/usr/bin
DESC="matrix-synapse"
NAME=matrix-synapse
SCRIPTNAME=/etc/init.d/$NAME
+CONFIGFILE_SERVERNAME="/etc/matrix-synapse/conf.d/server_name.yaml"
PYTHON="/usr/bin/python"
CONFIGS="--config-path /etc/matrix-synapse/homeserver.yaml --config-path
/etc/matrix-synapse/conf.d/"
@@ -50,6 +51,9 @@ get_config_key()
#
do_start()
{
+ # Fail silently if CONFIGFILE_SERVERNAME doesn't exist
+ [ -f $CONFIGFILE_SERVERNAME ] || return 0
+
# Running --generate-config to create keys if any are absent.
# Doesn't matter if not
$PYTHON -m "synapse.app.homeserver" $CONFIGS --generate-keys || return 2
diff --git a/debian/matrix-synapse.service b/debian/matrix-synapse.service
index ab94e07..fe9bf89 100644
--- a/debian/matrix-synapse.service
+++ b/debian/matrix-synapse.service
@@ -1,5 +1,6 @@
[Unit]
Description=Synapse Matrix homeserver
+ConditionPathExists=/etc/matrix-synapse/conf.d/server_name.yaml
[Service]
Type=simple
--
2.12.0
--- End Message ---
--- Begin Message ---
Source: matrix-synapse
Source-Version: 0.19.2+dfsg-5
We believe that the bug you reported is fixed in the latest version of
matrix-synapse, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andrew Shadura <[email protected]> (supplier of updated matrix-synapse
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 18 Mar 2017 11:14:06 +0100
Source: matrix-synapse
Binary: matrix-synapse
Architecture: source
Version: 0.19.2+dfsg-5
Distribution: unstable
Urgency: medium
Maintainer: Andrew Shadura <[email protected]>
Changed-By: Andrew Shadura <[email protected]>
Description:
matrix-synapse - Matrix reference homeserver
Closes: 857428 857526 857619
Changes:
matrix-synapse (0.19.2+dfsg-5) unstable; urgency=medium
.
[ Simó Albert i Beltran ]
* When purging remove configuration files created by debian/postinst
(Closes: #857428)
.
[ Helge Kreutzmann ]
* Add initial German debconf translation. (Closes: #857526)
.
[ Rahul De ]
* Fail silently if server name is not configured (Closes: #857619)
Checksums-Sha1:
7e50a976354402ffc5f8ebd0f77b328d7816e85b 2266 matrix-synapse_0.19.2+dfsg-5.dsc
e3b79f71733afc447230bb7ee9c07b9fe8f736c7 83160
matrix-synapse_0.19.2+dfsg-5.debian.tar.xz
Checksums-Sha256:
0040c3c88f6a0e4d97832ae750501368a8c1a8d27eb692d5ab7352dc7f9ce10f 2266
matrix-synapse_0.19.2+dfsg-5.dsc
c58c82bf43449c7371cb7a261e052fde17c0835ee215fadfa3873438ad5b6d63 83160
matrix-synapse_0.19.2+dfsg-5.debian.tar.xz
Files:
38ae19486d42cb7f605606f872fef702 2266 net optional
matrix-synapse_0.19.2+dfsg-5.dsc
4848aca45b027a3d85043575908fca91 83160 net optional
matrix-synapse_0.19.2+dfsg-5.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEcBAEBCAAGBQJYzQkMAAoJEJ1bI/kYT6UUvrUH/Au9HNdrBhoPSBZczIZnVLqC
rc3ILaujErQ+T8XgMdSjmeJz/f7N4X7MnRokYUOI48S/RsIAFmGb/LgUNjaWdrxy
XpKjmmgE4E9n4pxP9FReU+jetqk+0PM+gwcjwChWBWW19ODofI+m1huz7Y2rbBuG
1JeXVgV9U6AtFNdpWSkvQUkmNpthMhLZnzQ+DtmusAYLsvHBRVjxjZyqoVh1J9wf
m5yYnzx6IPNV1UZdt5zV/h/w2hGQLODxNRPUxBQeArOIx7GzcSm3T+1Pg9f0fovU
xe5HTfA3qfydvxoOG9wrzkqRiNha59A1jSc91l2Jy2aFuZzzwxvkiCN6EzSPvIQ=
=RnYz
-----END PGP SIGNATURE-----
--- End Message ---
