Your message dated Tue, 04 Apr 2006 15:32:07 -0700 with message-id <[EMAIL PROTECTED]> and subject line Bug#356771: fixed in jack 3.1.1+cvs20050801-7 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: jack Version: 3.1.1+cvs20050801-6 Attached is a patch to jack_init.py and jack_tag.py to make them use Mutagen rather than pyflac. It doesn't touch the stuff in debian/patches, however. Mutagen exposes the stream info as f.info.{sample_rate,total_samples}, similar to pyflac. -- Joe Wreschnig <[EMAIL PROTECTED]>--- jack_init.py.old 2006-03-13 17:06:34.000000000 -0600 +++ jack_init.py 2006-03-13 16:53:54.000000000 -0600 @@ -62,7 +62,7 @@ ogg = dummy_ogg() try: - import flac.metadata + import mutagen.flac as flac except ImportError: flac = None --- jack_tag.py.old 2006-03-13 16:53:35.000000000 -0600 +++ jack_tag.py 2006-03-13 17:21:36.000000000 -0600 @@ -153,34 +153,22 @@ mp3file.close() elif jack_helpers.helpers[cf['_encoder']]['target'] == "flac": if flac: - chain = flac.metadata.Chain() - chain.read(mp3name) - it = flac.metadata.Iterator() - it.init(chain) - while 1: - if it.get_block_type() == flac.metadata.VORBIS_COMMENT: - block = it.get_block() - vc = flac.metadata.VorbisComment(block) - break - if not it.next(): - break - if vc: - vc.comments['ALBUM'] = a_title.encode("utf-8") - vc.comments['TRACKNUMBER'] = `i[NUM]` - vc.comments['TITLE'] = t_name.encode("utf-8") - if t_artist: - vc.comments['ARTIST'] = t_artist.encode("utf-8") - else: - vc.comments['ARTIST'] = a_artist.encode("utf-8") - if cf['_id3_genre'] != -1: - vc.comments['GENRE'] = id3genres[cf['_id3_genre']] - if cf['_id3_year'] != -1: - vc.comments['DATE'] = `cf['_id3_year']` - chain.write(True, True) + f = flac.FLAC(mp3name) + if f.vc is None: f.add_vorbiscomment() + f.vc['ALBUM'] = a_title + f.vc['TRACKNUMBER'] = str(i[NUM]) + f.vc['TITLE'] = t_name + if t_artist: f.vc['ARTIST'] = t_artist + else: f.vc['ARTIST'] = a_artist + if cf['_id3_genre'] != -1: + f.vc['GENRE'] = id3genres[cf['_id3_genre']] + if cf['_id3_year'] != -1: + f.vc['DATE'] = str(cf['_id3_year']) + f.save() else: print - print "Please install the pyflac module available at" - print "http://www.sacredchao.net/quodlibet/wiki/Download"; + print "Please install the Mutagen module available at" + print "http://www.sacredchao.net/quodlibet/wiki/Development/Mutagen"; print "Without it, you'll not be able to tag FLAC tracks." elif jack_helpers.helpers[cf['_encoder']]['target'] == "ogg": vf = ogg.vorbis.VorbisFile(mp3name)
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---Source: jack Source-Version: 3.1.1+cvs20050801-7 We believe that the bug you reported is fixed in the latest version of jack, which is due to be installed in the Debian FTP archive: jack_3.1.1+cvs20050801-7.diff.gz to pool/main/j/jack/jack_3.1.1+cvs20050801-7.diff.gz jack_3.1.1+cvs20050801-7.dsc to pool/main/j/jack/jack_3.1.1+cvs20050801-7.dsc jack_3.1.1+cvs20050801-7_i386.deb to pool/main/j/jack/jack_3.1.1+cvs20050801-7_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Martin Michlmayr <[EMAIL PROTECTED]> (supplier of updated jack package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Wed, 05 Apr 2006 00:24:14 +0200 Source: jack Binary: jack Architecture: source i386 Version: 3.1.1+cvs20050801-7 Distribution: unstable Urgency: low Maintainer: Michael Banck <[EMAIL PROTECTED]> Changed-By: Martin Michlmayr <[EMAIL PROTECTED]> Description: jack - Rip and encode CDs with one command Closes: 356771 360497 360801 Changes: jack (3.1.1+cvs20050801-7) unstable; urgency=low . [ Martin Michlmayr ] * debian/patches/32_man_minus.patch: Escape minus signs in the man page properly. Thanks for the report, Francesco Poli. * debian/patches/45_fix_normalize_example.patch: Likewise. * debian/patches/83_man_plugin.patch: Likewise. * debian/patches/47_locale_check.patch: Check whether the locale is known, otherwise jack will produce a traceback; closes: #360801. * debian/patches/48_search_base_dir.patch: Search base_dir for existing directories; closes: #360497. * debian/patches/33_flac_mutagen.patch: Use mutagen instead of pyflac since the latter is obsolete and has been removed from the archive. Thanks, Joe Wreschnig; closes: #356771. * debian/patches/44_guess_toc_ogg_flac.patch: Update to use mutagen. * debian/patches/77_upd_progress_flac.patch: Likewise. * debian/control (Depends): replace python-flac with python-mutagen. * debian/patches/49_nicer_ripper_encoder.patch: Print a nicer message when an unknown ripper or encoder is specified. * debian/patches/50_check_ripper_encoder.patch: Check whether a command passed via --ripper/--encoder actually exists. Files: b418a73e8f606b2670d056d474105299 686 sound optional jack_3.1.1+cvs20050801-7.dsc 3ffb6459963129dd91aaf026e42a9667 52809 sound optional jack_3.1.1+cvs20050801-7.diff.gz 899fc9c1339321bc5a625862c5268c31 127700 sound optional jack_3.1.1+cvs20050801-7_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFEMvJHKb5dImj9VJ8RAu2pAJ9i1RnYnp+yWNS+yzNP907ZH2hY+gCePoxc pvPwp/AsTj+uBWQIs7KbMV0= =/HIc -----END PGP SIGNATURE-----
--- End Message ---
