Your message dated Wed, 19 Dec 2018 23:40:42 +0000 with message-id <[email protected]> and subject line Re: [Pkg-sysvinit-devel] Bug#746678: Missing or inconsistent absolute location of /sbin/insserv has caused the Debian Bug report #746678, regarding Missing or inconsistent absolute location of /sbin/insserv to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 746678: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=746678 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: sysv-rc Version: 2.88dsf-53 Tags: patch In #637390, a call to insserv was made absolute to accomodate environments where /sbin was not in the PATH. We should either change all of them or none of them really? Patch attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] `-diff --git a/debian/src/sysv-rc/sbin/update-rc.d b/debian/src/sysv-rc/sbin/update-rc.d index e641e76..a5c5d64 100755 --- a/debian/src/sysv-rc/sbin/update-rc.d +++ b/debian/src/sysv-rc/sbin/update-rc.d @@ -183,7 +183,7 @@ sub insserv_updatercd { } else { # insserv removes all dangling symlinks, no need to tell it # what to look for. - my $rc = system("insserv", @opts) >> 8; + my $rc = system("/sbin/insserv", @opts) >> 8; if (0 == $rc && !$notreally) { remove_last_action($scriptname); } @@ -200,7 +200,7 @@ sub insserv_updatercd { } if ( -f "/etc/init.d/$scriptname" ) { - my $rc = system("insserv", @opts, $scriptname) >> 8; + my $rc = system("/sbin/insserv", @opts, $scriptname) >> 8; if (0 == $rc && !$notreally) { save_last_action($scriptname, @orig_argv); } @@ -216,7 +216,7 @@ sub insserv_updatercd { insserv_toggle($notreally, $action, $scriptname, @args); # Call insserv to resequence modified links - my $rc = system("insserv", @opts, $scriptname) >> 8; + my $rc = system("/sbin/insserv", @opts, $scriptname) >> 8; if (0 == $rc && !$notreally) { save_last_action($scriptname, @orig_argv); }
--- End Message ---
--- Begin Message ---control: tags -1 +wontfix [2014-05-02 17:09] Petter Reinholdtsen <[email protected]> > [Chris Lamb] > > In #637390, a call to insserv was made absolute to accomodate > > environments where /sbin was not in the PATH. > > > > We should either change all of them or none of them really? > > I am working on a migration where insserv go to > /usr/lib/insserv/insserv, so a full path will be needed everywhere > when that is complete. Those changes are in experiemental at the > moment, and held up due to some regressions in insserv 1.16 compared > to 1.14 currently used in unstable. Absolute path to command is bad thing, codified in Lintian: The indicated program run in a maintainer script has a prepended path. Programs called from maintainer scripts normally should not have a path prepended. dpkg ensures that the PATH is set to a reasonable value, and prepending a path may prevent the local administrator from using a replacement version of a command for some local reason. By the way, as of insserv=1.18 binary is at /sbin/insserv. Help with evaluating pros and cons of moving it into private directory is welcome.
--- End Message ---
