Your message dated Fri, 18 Dec 2020 12:23:22 +0100
with message-id <[email protected]>
and subject line 
has caused the Debian Bug report #906161,
regarding python-debianbts: get_bugs doesn't marshal usertags properly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
906161: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906161
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-debianbts
Version: 2.7.2
Severity: normal
Tags: patch

Hi,

marshaling for get_bugs' "usertags" param doesn't seem to work properly.
There's some special casing with _build_int_array_el for lists and
tuples but not for dicts.  The below seems to make it work.

Cheers,
Julien

diff --git a/debianbts/debianbts.py b/debianbts/debianbts.py
index d638e26..8816b7a 100644
--- a/debianbts/debianbts.py
+++ b/debianbts/debianbts.py
@@ -405,6 +405,13 @@ def get_bugs(*key_value):
         arg_name = 'arg' + str(arg_n)
         if isinstance(kv, (list, tuple)):
             _build_int_array_el(arg_name, method_el, kv)
+        elif isinstance(kv, dict):
+            el = method_el.add_child(arg_name)
+            for k, v in kv.items():
+                if isinstance(v, (list, tuple)):
+                    _build_int_array_el(k, el, v)
+                else:
+                    el.marshall(k, v)
         else:
             method_el.marshall(arg_name, kv)
 

--- End Message ---
--- Begin Message --- Didn't receive an answer from the reporter to reproduce the bug for 2 years, closing the bug.




--
Dr. Bastian Venthur                                 https://venthur.de
Debian Developer                                 venthur at debian org

--- End Message ---

Reply via email to