Your message dated Thu, 07 Jan 2021 20:35:39 +0000
with message-id <[email protected]>
and subject line Bug#979175: fixed in zeromq3 4.3.3-5
has caused the Debian Bug report #979175,
regarding src:zeromq3: FTBFS on kFreeBSD due to undefined variable s_ in 
src/stream_engine_base.cpp
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
979175: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979175
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:zeromq3
Version: 4.3.3-4
Severity: normal
Tags: patch upstream

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

This package currentl fails to build from source on kFreeBSD:

src/stream_engine_base.cpp: In function ‘std::string 
get_peer_address(zmq::fd_t)’:
src/stream_engine_base.cpp:87:26: error: ‘_s’ was not declared in this scope; 
did you mean ‘s_’?
   87 |         if (!getsockopt (_s, 0, LOCAL_PEERCRED, &cred, &size)
      |                          ^~
      |                          s_
src/stream_engine_base.cpp:94:13: error: ‘_peer_address’ was not declared in 
this scope; did you mean ‘peer_address’?
   94 |             _peer_address += buf.str ();
      |             ^~~~~~~~~~~~~
      |             peer_address
make[2]: *** [Makefile:5866: src/libzmq_la-stream_engine_base.lo] Error 1

Full log: 
https://buildd.debian.org/status/fetch.php?pkg=zeromq3&arch=kfreebsd-amd64&ver=4.3.3-4&stamp=1608930571&raw=0


Untested patch attached.

Reported upstream: https://github.com/zeromq/libzmq/issues/4113

 - Jonas

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl/yMKYACgkQLHwxRsGg
ASG6mQ/8DoFLDN9hvTDMCBh+JVy5/+JFKKYTsRdbIZUXEMsJjoYrsldhRXPYZzXV
uFEqWR3KmSZ3vbdXIxBnk7kpCdyG2J9iKz1WyXelB77CuUoBQ9myIXLSB28siujg
/j0Rd7jEr7/idCxfEf13ryd9zQfOIkq86/kAELSsbU9EhIvDB+Opt4Ak0r0nWeJ5
osbTKg9fhvrqeCm6Y5DVfR0DMn4cUUhFz3c4bEJirOd6/AsceTr4EFOGxqbuHrUh
hHZO6Y4j7oRXAZxJPf34OzAYOlfbJSKcAZhroT63Mm/OfI/Um/jiTn3EAgerD6gd
5NhQK3A7hPgemnOWlGMu4QocCqs51GDY2YRAQ4Mme6Bm4r/LJ/WTH6ZSrQRMf44e
w+8mzrYGe4MSIyzuUgqUVtwCXOtUUGK0EE/rWpRXYNf4SchIlcQiTjF793F425I0
GUWpEj7QncVv80IHBteqZz7494qdjN2C7KawHsKhV2AjPNvUUE4+TY3blZMRJzI/
efuPROo5KczkAAW+sF/0lx3tzO5Ovx3Bi9OGeW6b5q1BBlBwKosAz1vbos2+duEd
fAI+6F/YMBkb3NLMQwKHpHxs/TYiAyYQDKXp06m0fyzXTjzfj9ebAOzxBzqt7QDr
pkd85romPScyU538g6zTxP/uhHM6jOLOqrHC0ttAlzxHPxxx7kA=
=zDmN
-----END PGP SIGNATURE-----
--- a/src/stream_engine_base.cpp
+++ b/src/stream_engine_base.cpp
@@ -63,18 +63,18 @@
 #include "likely.hpp"
 #include "wire.hpp"
 
-static std::string get_peer_address (zmq::fd_t s_)
+static std::string get_peer_address (zmq::fd_t _s)
 {
     std::string peer_address;
 
-    const int family = zmq::get_peer_ip_address (s_, peer_address);
+    const int family = zmq::get_peer_ip_address (_s, peer_address);
     if (family == 0)
         peer_address.clear ();
 #if defined ZMQ_HAVE_SO_PEERCRED
     else if (family == PF_UNIX) {
         struct ucred cred;
         socklen_t size = sizeof (cred);
-        if (!getsockopt (s_, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
+        if (!getsockopt (_s, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
             std::ostringstream buf;
             buf << ":" << cred.uid << ":" << cred.gid << ":" << cred.pid;
             peer_address += buf.str ();
--- a/src/stream_engine_base.cpp
+++ b/src/stream_engine_base.cpp
@@ -63,18 +63,18 @@
 #include "likely.hpp"
 #include "wire.hpp"
 
-static std::string get_peer_address (zmq::fd_t s_)
+static std::string get_peer_address (zmq::fd_t _s)
 {
     std::string peer_address;
 
-    const int family = zmq::get_peer_ip_address (s_, peer_address);
+    const int family = zmq::get_peer_ip_address (_s, peer_address);
     if (family == 0)
         peer_address.clear ();
 #if defined ZMQ_HAVE_SO_PEERCRED
     else if (family == PF_UNIX) {
         struct ucred cred;
         socklen_t size = sizeof (cred);
-        if (!getsockopt (s_, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
+        if (!getsockopt (_s, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
             std::ostringstream buf;
             buf << ":" << cred.uid << ":" << cred.gid << ":" << cred.pid;
             peer_address += buf.str ();

--- End Message ---
--- Begin Message ---
Source: zeromq3
Source-Version: 4.3.3-5
Done: Laszlo Boszormenyi (GCS) <[email protected]>

We believe that the bug you reported is fixed in the latest version of
zeromq3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated zeromq3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 07 Jan 2021 19:10:33 +0100
Source: zeromq3
Architecture: source
Version: 4.3.3-5
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Closes: 977662 979175
Changes:
 zeromq3 (4.3.3-5) unstable; urgency=medium
 .
   * Backport upstream fix for:
     - FTBFS on kFreeBSD (closes: #979175).
   * Add special license exception granted by copyright holders
     (closes: #977662).
   * Update packaging bits.
   * Sync with Ubuntu.
 .
   [ Matthias Klose <[email protected]> ]
   * Fix test_hwm_pubsub on slow platforms like riscv64. Patch from an
     unmerged upstream PR.
   * Fix ftbfs on s390x (which appears to inline more aggressively than on
     other architectures).
Checksums-Sha1:
 71a597cb316db623c9635b78bfdbebc4d80102c9 1873 zeromq3_4.3.3-5.dsc
 f9c5b26ce434dff44a3f3aa761d44f1790b44200 26536 zeromq3_4.3.3-5.debian.tar.xz
Checksums-Sha256:
 e11168c4965e948382c0b59e565db9729068554ab0d274c3ba7e9d85b95617f8 1873 
zeromq3_4.3.3-5.dsc
 961b75a73fb53b6c0d6daaccca7edae442c382f81bd771aec571daff5bce449e 26536 
zeromq3_4.3.3-5.debian.tar.xz
Files:
 6e3009e526b647192b9b5c07a248a456 1873 libs optional zeromq3_4.3.3-5.dsc
 e10d57ad21ddd50d3ef8138b469eb174 26536 libs optional 
zeromq3_4.3.3-5.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAl/3aW0ACgkQ3OMQ54ZM
yL9rRg//RoIMR923GmzkQwz3/PXPgpUxmylDwvfNddqHprQ1USSjM0rYdtRqoayW
WBjUeNTVdtU6EG9M9i09rrg7KVdVtZD7H8TuNbvDsOVXwCcLcratBJH5vZ9/U11b
aPr6mdRKZvRuMNwM9KMp8msYvcDRF6d808BY3JXOiNxCdG/YhX8WniQGht2Cyk7h
P0PmUfBErNvuoDKNeb3skbY4qVlCsiOK7IeZ8XjIGgAu6iVfDp2a8hvQSIArvYB1
hYi5KL1fv4mERbhVv6EiRRmY8liAPP7UZ6qQXTegiohdbtjRA01C+94q46d6CWyb
DbzAsKJsLTeOizhu7wv6yQIXWrLZ7179WFYzH7kP91HZqCZb2u5XDkfFCPsSqwFK
/chdMNmFnZypjQ2Z9Ob7MgbCqtBlXcM4v4RYFVOjhoCjMSQ2lsvoP6rCGKHWLsh9
nezjv+u1jNHqJnX51cb3mzcWGgt8yUvJV9qYyoM61A2ya9OhejU8nhdtr+vKr8EY
izyU69xfP3eQcIIhiXUpzMVV8Qgc9h/4+UKAotWPu2SZFLfe0tBXMZC0WZOBpnzC
wk+1FRFK2W3+WJgoFdj2JesmpjruGc3psoJuzTn6QIzrzvdV9ibhDDWcpYTyDTcH
17XFV9yFAt/6tc/EWy4JaHEL/u3Ov5PY4KvHbZjtYwW5EsmOwZY=
=Xr1j
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to