Your message dated Sat, 09 Jan 2021 14:34:10 +0000
with message-id <[email protected]>
and subject line Bug#979175: fixed in zeromq3 4.3.3-6
has caused the Debian Bug report #979175,
regarding src:zeromq3: FTBFS on kFreeBSD due to undefined variable s_ in 
src/stream_engine_base.cpp
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
979175: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979175
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:zeromq3
Version: 4.3.3-4
Severity: normal
Tags: patch upstream

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

This package currentl fails to build from source on kFreeBSD:

src/stream_engine_base.cpp: In function ‘std::string 
get_peer_address(zmq::fd_t)’:
src/stream_engine_base.cpp:87:26: error: ‘_s’ was not declared in this scope; 
did you mean ‘s_’?
   87 |         if (!getsockopt (_s, 0, LOCAL_PEERCRED, &cred, &size)
      |                          ^~
      |                          s_
src/stream_engine_base.cpp:94:13: error: ‘_peer_address’ was not declared in 
this scope; did you mean ‘peer_address’?
   94 |             _peer_address += buf.str ();
      |             ^~~~~~~~~~~~~
      |             peer_address
make[2]: *** [Makefile:5866: src/libzmq_la-stream_engine_base.lo] Error 1

Full log: 
https://buildd.debian.org/status/fetch.php?pkg=zeromq3&arch=kfreebsd-amd64&ver=4.3.3-4&stamp=1608930571&raw=0


Untested patch attached.

Reported upstream: https://github.com/zeromq/libzmq/issues/4113

 - Jonas

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl/yMKYACgkQLHwxRsGg
ASG6mQ/8DoFLDN9hvTDMCBh+JVy5/+JFKKYTsRdbIZUXEMsJjoYrsldhRXPYZzXV
uFEqWR3KmSZ3vbdXIxBnk7kpCdyG2J9iKz1WyXelB77CuUoBQ9myIXLSB28siujg
/j0Rd7jEr7/idCxfEf13ryd9zQfOIkq86/kAELSsbU9EhIvDB+Opt4Ak0r0nWeJ5
osbTKg9fhvrqeCm6Y5DVfR0DMn4cUUhFz3c4bEJirOd6/AsceTr4EFOGxqbuHrUh
hHZO6Y4j7oRXAZxJPf34OzAYOlfbJSKcAZhroT63Mm/OfI/Um/jiTn3EAgerD6gd
5NhQK3A7hPgemnOWlGMu4QocCqs51GDY2YRAQ4Mme6Bm4r/LJ/WTH6ZSrQRMf44e
w+8mzrYGe4MSIyzuUgqUVtwCXOtUUGK0EE/rWpRXYNf4SchIlcQiTjF793F425I0
GUWpEj7QncVv80IHBteqZz7494qdjN2C7KawHsKhV2AjPNvUUE4+TY3blZMRJzI/
efuPROo5KczkAAW+sF/0lx3tzO5Ovx3Bi9OGeW6b5q1BBlBwKosAz1vbos2+duEd
fAI+6F/YMBkb3NLMQwKHpHxs/TYiAyYQDKXp06m0fyzXTjzfj9ebAOzxBzqt7QDr
pkd85romPScyU538g6zTxP/uhHM6jOLOqrHC0ttAlzxHPxxx7kA=
=zDmN
-----END PGP SIGNATURE-----
--- a/src/stream_engine_base.cpp
+++ b/src/stream_engine_base.cpp
@@ -63,18 +63,18 @@
 #include "likely.hpp"
 #include "wire.hpp"
 
-static std::string get_peer_address (zmq::fd_t s_)
+static std::string get_peer_address (zmq::fd_t _s)
 {
     std::string peer_address;
 
-    const int family = zmq::get_peer_ip_address (s_, peer_address);
+    const int family = zmq::get_peer_ip_address (_s, peer_address);
     if (family == 0)
         peer_address.clear ();
 #if defined ZMQ_HAVE_SO_PEERCRED
     else if (family == PF_UNIX) {
         struct ucred cred;
         socklen_t size = sizeof (cred);
-        if (!getsockopt (s_, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
+        if (!getsockopt (_s, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
             std::ostringstream buf;
             buf << ":" << cred.uid << ":" << cred.gid << ":" << cred.pid;
             peer_address += buf.str ();
--- a/src/stream_engine_base.cpp
+++ b/src/stream_engine_base.cpp
@@ -63,18 +63,18 @@
 #include "likely.hpp"
 #include "wire.hpp"
 
-static std::string get_peer_address (zmq::fd_t s_)
+static std::string get_peer_address (zmq::fd_t _s)
 {
     std::string peer_address;
 
-    const int family = zmq::get_peer_ip_address (s_, peer_address);
+    const int family = zmq::get_peer_ip_address (_s, peer_address);
     if (family == 0)
         peer_address.clear ();
 #if defined ZMQ_HAVE_SO_PEERCRED
     else if (family == PF_UNIX) {
         struct ucred cred;
         socklen_t size = sizeof (cred);
-        if (!getsockopt (s_, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
+        if (!getsockopt (_s, SOL_SOCKET, SO_PEERCRED, &cred, &size)) {
             std::ostringstream buf;
             buf << ":" << cred.uid << ":" << cred.gid << ":" << cred.pid;
             peer_address += buf.str ();

--- End Message ---
--- Begin Message ---
Source: zeromq3
Source-Version: 4.3.3-6
Done: Laszlo Boszormenyi (GCS) <[email protected]>

We believe that the bug you reported is fixed in the latest version of
zeromq3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated zeromq3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 09 Jan 2021 14:46:20 +0100
Source: zeromq3
Architecture: source
Version: 4.3.3-6
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Closes: 979175
Changes:
 zeromq3 (4.3.3-6) unstable; urgency=medium
 .
   * Backport upstream fix for:
     - another FTBFS on kFreeBSD (closes: #979175).
Checksums-Sha1:
 1a4783728f837b77ceb772848b291a85ff61ac85 1873 zeromq3_4.3.3-6.dsc
 a9b4b1809674272aa4190ea1117e77d265e112ce 26716 zeromq3_4.3.3-6.debian.tar.xz
Checksums-Sha256:
 c3f890642408fa58c08a72f4742d66e77f75aff61049daf0e789a0b5e015f74b 1873 
zeromq3_4.3.3-6.dsc
 fd7622cc7d7dbbb2ec87629ae61a3a0a18cd4d59b576868656fbcefd87dd5620 26716 
zeromq3_4.3.3-6.debian.tar.xz
Files:
 79d0cd280e948a958d3861d58bb7c3f1 1873 libs optional zeromq3_4.3.3-6.dsc
 4d3c4d50e52fa894c2042312839e22b9 26716 libs optional 
zeromq3_4.3.3-6.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAl/5uW0ACgkQ3OMQ54ZM
yL/azhAAkCsxxUbL2hmW2EWAIeMWILB6KzTeqvGvpVtilmC+oeoLQhcbBQzQTwv1
ObyZZDU/7+1E1JNS/dP8Vy4Axbq3HWlKVdzr1+G9SbKqjmzepCB/VoUDrxkc1ce3
IyFVgSaADWsOxvd7pzz5eSbtIM3fMpGbnBATQ1p7np9qQ2TYGJKVHFC4my6/Tcx+
11RcQbBukBCGDxwoyHytRRZ6jcyInRSysyLFuGqiK8uus3Zr829hU7U1PSNGNMXY
n8DmRPdFanMAxdu8LueDsoMEpNF/odapkeNvT6Xb2P24gHbVcu/aZvNTMl0CTCHJ
C0btUEdApQBcqK/QTYU9tNySgRb6s4nju4WyWCgj8bOQxKH4xokJ0v0i7U8/+SDO
O/k0IZe3jJNboMN93MWR3YjJtEP91LgGg4MS9haSaWq32tQWWpEP3mII5xs9a7Qs
YmH8KEKnzLFK/qd2YAxtNPKEqkRG4KYXlW1EMuQr9hbjMGIZaW8DDKyEoobiyO4g
MmnLXcnAn0XWbyOtdjT3Eg373xKeRTLry3rKgjeh2H8xy7Vg0a3Cy5SW/nvJSlsf
N4e9qrd6g94TGjyxB9xBco68rGryIqu+8fZA7SHgqTP5Vr5RyAQzCuuX4mF5qMf1
h101B1viTrSozc/hs05mIl51vRyzelhVaie2RhHMNNJdKTQpUAs=
=3Nka
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to