Your message dated Tue, 20 Sep 2022 11:36:00 +0000
with message-id <[email protected]>
and subject line Bug#951659: fixed in fai 6.0~alpha2
has caused the Debian Bug report #951659,
regarding setup-storage should allow default tmpfs settings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
951659: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951659
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.8.4
Severity: wishlist
File: /usr/sbin/setup-storage
Tags: upstream

The setup-storage(8) command has the following grammar for tmpfs
blocks:

    volume ::= tmpfs <mountpoint> <tmpfs_size> <mount_options>
    tmpfs_size ::= <sizespec>
    sizespec ::= RAM:[[:digit:]]+%|[[:digit:]]+[kKMGTP%iB]*

This forces a line that looks like the examples in the manpage:

    tmpfs   /tmp    RAM:20% defaults
    tmpfs   /scratch        3GiB    defaults

... which is great if you want to control that. But in our
configuration, we're happy to delegate the decision of how big a tmpfs
should be to the kernel, which has its own defaults (50% of RAM at the
time of writing, I believe).

It seems there's no way to do that delegation in setup-storage(8)
right now: if I use `-` as a <sizespec>, I get the following error:

    # setup-storage -f "disk-config/gnt-fsn" -X
    Starting setup-storage 2.2
    Using config file: disk-config/gnt-fsn
    
          ERROR (line 15):  invalid tmpfs size near " - defaults disk_config
                           nvme0n1 disklabel:gpt-bios gpt_bios_part:1 bootable:2
          [...]
    
          ERROR (line 15): Invalid volume: Was expecting tmpfs size but found "-
                           defaults" instead
    
          ERROR (line 15): Invalid line: Was expecting '\n' but found "tmpfs 
/tmp -
                           defaults" instead
    Syntax error

(I'll also note the duplicate errors, with the first strangely
containing the entire configuration after the tmpfs keyword, stripped
here for brievety.)

It seems to me "-" should be allowed here, like this:

    disk_config tmpfs
    tmpfs   /tmp    -       defaults

It's allowed in fstab and just worked fine in our previous
configuration.

Thanks!

-- System Information:
Debian Release: 10.3
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable'), (1, 'experimental'), (1, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fai-setup-storage depends on:
ii  e2fsprogs                 1.44.5-1+deb10u3
ii  liblinux-lvm-perl         0.17-2
ii  libparse-recdescent-perl  1.967015+dfsg-2
ii  parted                    3.2-25
ii  perl                      5.28.1-6

Versions of packages fai-setup-storage recommends:
ii  lvm2   2.03.02-3
ii  mdadm  4.1-1

Versions of packages fai-setup-storage suggests:
ii  cryptsetup     2:2.1.0-5+deb10u2
ii  dmsetup        2:1.02.155-3
ii  dosfstools     4.1-2
pn  jfsutils       <none>
ii  ntfs-3g        1:2017.3.23AR.3-3
ii  reiserfsprogs  1:3.6.27-3
ii  xfsprogs       4.20.0-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha2
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 20 Sep 2022 10:59:17 +0200
Source: fai
Architecture: source
Version: 6.0~alpha2
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha2) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 0a6147b2ac3ce6c52f37b9f7c2786b6c527403f0 2070 fai_6.0~alpha2.dsc
 df96f6aa31ad28118814043665fa8caff063383e 290984 fai_6.0~alpha2.tar.xz
 8e83dde7ef69b0cb18895766100961f41db19d5f 16281 fai_6.0~alpha2_amd64.buildinfo
Checksums-Sha256:
 20aeeb3c1dfbedcaedb683bb6262a86b1302de7169d2bfdf8c8d7b54345f6458 2070 
fai_6.0~alpha2.dsc
 061487591927c58a3dde5a0e8662985afc3f0232ed0faf59a8a03ed2f605949e 290984 
fai_6.0~alpha2.tar.xz
 c9e1e3ee4edb016596c95db3d331e7ada9fffa8a9622ef79e380b375b3d86c1d 16281 
fai_6.0~alpha2_amd64.buildinfo
Files:
 c3f9740500731a57c7b266493e447e12 2070 admin optional fai_6.0~alpha2.dsc
 407a64f831993ffae03f19d54aa000e8 290984 admin optional fai_6.0~alpha2.tar.xz
 fadd8a1bd1b78351f92e20b6600fa580 16281 admin optional 
fai_6.0~alpha2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMpgP0RHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeTcjg//cBCAIOkqoZWLd73h4PmdC0nFIhDwLajW
6GjYLQl90Tffrfl/y+ntQ2287ZUih8/7zJzu+tp5jwWd9ykIbM+yGklpPgQUic7e
s3TdMovN3QGvV2wj9p5lgrh0Fchkl2URxuYcz9bjBTZR9DI+RSA+r9M3YiKd9YBL
EACPad50qtcQ+99vkGcHM9srOeV9ZI2HuAyGM2MUFIWJtGyB8dA38VBBauCJC2Vk
SMIDFowuvy74DPz5TIPXX7O55U/TpA1ECvOQPJX5d9mZlJ7triZDzFLq0f1t2Exa
cuJwXjdRk7OogTYJMBzKr/h6fsYTm1EqpiWOXZlUiKdnKc22QeTWhAHqVACrCeKN
W1O0wqmd1zsK56mRhQpvuh4BkjEoohQjwr36IQ1Q3Tm016lcjxYQ7YG5RSym2ilu
pXu5ORuwHhsCJi4D3YbC/TBSTT98rNf3G8HTrYkM21hIOL0Qn2DbPzcsaKnXtwvF
oQ2OhCweBsnrmvyZMrANqE5ubERa7/moaiPExVUW8lM4q4M7uADumPrtankFvjWg
32fKO9hO86BbcYPylj8BH/jlcXu/tSE+CrVj/Ta1vZ3qUebzNKIA3Jn7y2aamadG
cZ6eTnDZVGB3kCagVlPkcK2NoLJKc/VsUm9xDt55SlJB11LjpyRHO8HPa0SJC7Wh
MdhwzqJRcRg=
=JRvj
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to