Your message dated Wed, 21 Sep 2022 23:25:50 +0000
with message-id <[email protected]>
and subject line Bug#951659: fixed in fai 6.0~alpha7
has caused the Debian Bug report #951659,
regarding setup-storage should allow default tmpfs settings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
951659: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951659
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.8.4
Severity: wishlist
File: /usr/sbin/setup-storage
Tags: upstream

The setup-storage(8) command has the following grammar for tmpfs
blocks:

    volume ::= tmpfs <mountpoint> <tmpfs_size> <mount_options>
    tmpfs_size ::= <sizespec>
    sizespec ::= RAM:[[:digit:]]+%|[[:digit:]]+[kKMGTP%iB]*

This forces a line that looks like the examples in the manpage:

    tmpfs   /tmp    RAM:20% defaults
    tmpfs   /scratch        3GiB    defaults

... which is great if you want to control that. But in our
configuration, we're happy to delegate the decision of how big a tmpfs
should be to the kernel, which has its own defaults (50% of RAM at the
time of writing, I believe).

It seems there's no way to do that delegation in setup-storage(8)
right now: if I use `-` as a <sizespec>, I get the following error:

    # setup-storage -f "disk-config/gnt-fsn" -X
    Starting setup-storage 2.2
    Using config file: disk-config/gnt-fsn
    
          ERROR (line 15):  invalid tmpfs size near " - defaults disk_config
                           nvme0n1 disklabel:gpt-bios gpt_bios_part:1 bootable:2
          [...]
    
          ERROR (line 15): Invalid volume: Was expecting tmpfs size but found "-
                           defaults" instead
    
          ERROR (line 15): Invalid line: Was expecting '\n' but found "tmpfs 
/tmp -
                           defaults" instead
    Syntax error

(I'll also note the duplicate errors, with the first strangely
containing the entire configuration after the tmpfs keyword, stripped
here for brievety.)

It seems to me "-" should be allowed here, like this:

    disk_config tmpfs
    tmpfs   /tmp    -       defaults

It's allowed in fstab and just worked fine in our previous
configuration.

Thanks!

-- System Information:
Debian Release: 10.3
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable'), (1, 'experimental'), (1, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fai-setup-storage depends on:
ii  e2fsprogs                 1.44.5-1+deb10u3
ii  liblinux-lvm-perl         0.17-2
ii  libparse-recdescent-perl  1.967015+dfsg-2
ii  parted                    3.2-25
ii  perl                      5.28.1-6

Versions of packages fai-setup-storage recommends:
ii  lvm2   2.03.02-3
ii  mdadm  4.1-1

Versions of packages fai-setup-storage suggests:
ii  cryptsetup     2:2.1.0-5+deb10u2
ii  dmsetup        2:1.02.155-3
ii  dosfstools     4.1-2
pn  jfsutils       <none>
ii  ntfs-3g        1:2017.3.23AR.3-3
ii  reiserfsprogs  1:3.6.27-3
ii  xfsprogs       4.20.0-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha7
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 20 Sep 2022 12:02:28 +0200
Source: fai
Architecture: source
Version: 6.0~alpha7
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha7) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 11ee4a760c7b80979f675fc1d9af4cad0d6b579e 2070 fai_6.0~alpha7.dsc
 763e6e2b9546ceb9a82a749a9f060795686225d7 290960 fai_6.0~alpha7.tar.xz
 f8f98ca9eac6f8b97768b75330c0a6c8343fc4d6 16281 fai_6.0~alpha7_amd64.buildinfo
Checksums-Sha256:
 db6258ff0e18ba769ac316a570d6a1a1535322a56cb2ec42245b404d9ed2a033 2070 
fai_6.0~alpha7.dsc
 509ade3285ad2084aa31bd1c68911c3cbba39290a6f97ca839ef01a966b1b987 290960 
fai_6.0~alpha7.tar.xz
 37047ca636f815df1a5dff007e8cbfd6f068dba2d4f1e06bea9e9ce34214d1a5 16281 
fai_6.0~alpha7_amd64.buildinfo
Files:
 d8a3d327c92886aa9c5c721a90dc6d63 2070 admin optional fai_6.0~alpha7.dsc
 8adedc5e4b6fe29c16eb672f64b798c8 290960 admin optional fai_6.0~alpha7.tar.xz
 247765eb8b7f932d0fbf2108f97a8175 16281 admin optional 
fai_6.0~alpha7_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMridERHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeSwXxAArtf23AavHhjxyqhlX/3chgHHJ6mo5tsy
m3ptz4YQJ3eV+ds9qw0Z25RJYBt9NiDc7D6Sa3c0uuaVE9a8hPf68pMf++TLZ4AR
ojVDV+HyFYuNQ1QO0Ijy0q3oHzTa80zQvaTky5LgfK7cUUz0kxxa35YC5HKNigM1
nOpw1JdYq4zqrJ6LZASoefPlZfPnr5QL6f1lPujBvfKqu6z76O3hU+5ODY7eqOdV
ov6Dj9E+3boouz7itrI3pdrDtqNZSufOqpSpP3iWnzgOcERx3Bkb775HTiYa/FpB
2rmfX1KiihcygT02RngZECuX99VDZC0L7iMtYY9ATnPASOygb5k1OrkCd2Cx2iiY
Nc/KKf6ScTVGIVawljq1kyVLEEVJt5rUarnPOKb+aDUOevpGRZ7ovYclUDJNk9oW
hZrx28XwLUHyiUJrvY4DDrx5ZbStB273TEq+fNLxaTgbMXlY2IE9xjVTsdtm2MT+
DOIhR9SHiaSQmJC55117BNNAfmYhN9l7BZRkdC7On0176ES5rCfioWrbLq9Waahx
xZA5b4LnoEnUwzJdhW7FHG/15C9slXGqxtVSvwqcvquASsGbsFTGeAgk20mCJh08
5EHyk5bSLE/a49mqrElYhSTGuNAkjC8iaMmKqbhkXdXb7F2yIxCMYJI4tSoWVsl/
PTDyYaAtE6U=
=D0pv
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to