Your message dated Wed, 22 Nov 2023 15:00:10 -0800
with message-id <87wmu9s8at.fsf@contorta>
and subject line Re: Bug#840741: http-icons: please make the build reproducible
has caused the Debian Bug report #840741,
regarding http-icons: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
840741: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840741
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: http-icons
Version: 0~20041010-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: randomness
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that http-icons could not be built reproducibly.
The GIF images were being optimised while building by converting
to PNM and back to GIF. The conversion back to GIF introduced some
variation.
Upon further investigation, it looked like this "optimisation" was
actually increasing the sizes of images (!), so I am just actually
just dropping the optimisation here. :)
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/control 2016-10-14 12:46:59.733298732 +0200
--- b/debian/control 2016-10-14 13:05:41.960636682 +0200
@@ -6,8 +6,7 @@
devscripts,
debhelper,
dh-buildinfo,
- optipng,
- netpbm
+ optipng
Standards-Version: 3.9.3
Homepage: http://www.ideocentric.com/technology/articles/title/apache-icons
Vcs-Git: git://git.debian.org/git/collab-maint/http-icons.git
--- a/debian/rules 2016-10-14 12:46:59.733298732 +0200
--- b/debian/rules 2016-10-14 13:05:46.152701399 +0200
@@ -38,15 +38,11 @@
DEB_COPYRIGHT_CHECK_IGNORE_REGEX =
^(.*\.(gif|png))|debian/(changelog|copyright(|_hints|_newhints))$
# optimize images, and recreate broken blank.png from blank.gif
-CDBS_BUILD_DEPENDS += , optipng, netpbm
+CDBS_BUILD_DEPENDS += , optipng
build/$(pkg):: debian/stamp-optimize-images
debian/stamp-optimize-images:
mkdir -p build/small; \
- set -e; for img in *.gif small/*.gif; do \
- giftopnm --alphaout=build/$$img.alpha $$img > build/$$img.pnm; \
- ppmtogif -sort -alpha=build/$$img.alpha build/$$img.pnm >
build/$$img; \
- rm -f build/$$img.alpha build/$$img.pnm; \
- done
+ set -e; for img in *.gif small/*.gif; do cp -v $$img build/$$img; done
find . -maxdepth 1 -name '*.png' \! -name 'blank.png' -exec optipng -nx
-force {} -dir build {} \;
optipng -nx -force -out build/blank.png blank.gif
optipng -nx -force -dir build/small small/*.png
--- End Message ---
--- Begin Message ---
Version: 0~20041010-1.1
On 2016-10-14, Chris Lamb wrote:
The GIF images were being optimised while building by converting
> to PNM and back to GIF. The conversion back to GIF introduced some
> variation.
>
> Upon further investigation, it looked like this "optimisation" was
> actually increasing the sizes of images (!), so I am just actually
> just dropping the optimisation here. :)
Seems like this was fixed in some dependent toolchain in unstable around
2023-03-19. All builds since 2022-04-05 have been reproducible (other
than a small number of FTBFS):
https://tests.reproducible-builds.org/debian/history/http-icons.html
I have marked it as done in 0~20041010-1.1, although strictly speaking
that version also had some old unreproducible builds, so nothing in this
particular version source code *actually* fixed the issue.
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
