Your message dated Wed, 22 Nov 2023 15:12:41 -0800
with message-id <87ttpds7py.fsf@contorta>
and subject line Re: Bug#834776: uhub: please make the build reproducible
has caused the Debian Bug report #834776,
regarding uhub: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
834776: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834776
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: uhub
Version: 0.4.1-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: umask
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], I noticed
that uhub could not be built reproducibly.
This was because dh_fixperms was not being called (to avoid mangling
the existing chmod), meaning that files were installed to the .deb
varying on the current umask.
The solution is to reinstate the call to dh_fixperms but to use its
--exclude/-X argument.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/rules 2016-08-18 23:54:55.441456261 +0100
--- b/debian/rules 2016-08-19 00:01:22.564666976 +0100
@@ -22,8 +22,8 @@
dh_auto_install
chmod 0750 $(CURDIR)/debian/$(PACKAGE)/var/log/uhub
-# Do nothing:
-.PHONY: override_dh_fixperms
+override_dh_fixperms:
+ dh_fixperms -Xvar/log/uhub
get-orig-source:
# preparation
--- End Message ---
--- Begin Message ---
Version: 0.4.1-3.2
On 2016-08-19, Chris Lamb wrote:
> This was because dh_fixperms was not being called (to avoid mangling
> the existing chmod), meaning that files were installed to the .deb
> varying on the current umask.
>
> The solution is to reinstate the call to dh_fixperms but to use its
> --exclude/-X argument.
This appears to be fixed in some other way, as builds since bullseye
(~2021) appear to be reproducible:
https://tests.reproducible-builds.org/debian/history/amd64/uhub.html
I have marked it as done in version 0.4.1-3.2 as that version has
consistently built reproducibly, although strictly speaking, it was
probably some toolchain change introduced in bullseye that fixed the
issue (e.g. builds of 0.4.1-3.1 in bullseye or newer were also
reproducible, although builds of 0.4.1-3.1 in buster were not).
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
