Your message dated Fri, 30 Aug 2024 19:33:26 +0000
with message-id <[email protected]>
and subject line Bug#941080: fixed in puppetdb 8.4.1-2
has caused the Debian Bug report #941080,
regarding puppetdb does not remove old logrotate.d config on upgrade
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
941080: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941080
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: puppetdb
Version: 6.2.0-3
Severity: normal
This package ships two log rotation mechanisms for
/var/log/puppetdb/puppetdb.log:
root@pauli:~# dpkg -L puppetdb | grep log
/etc/puppetdb/logback.xml
/etc/puppetdb/request-logging.xml
/usr/share/doc/puppetdb/changelog.Debian.gz
/var/log
/var/log/puppetdb
/etc/logrotate.d/puppetdb
This creates noise when logrotate comes at night to try rotating the
logs:
/etc/cron.daily/logrotate:
error: destination /var/log/puppetdb/puppetdb-access.log.1 already exists,
renaming to /var/log/puppetdb/puppetdb-access.log.1-2019030706.backup
error: error setting owner of /var/log/puppetdb/puppetdb-access.log.1 to uid
119 and gid 125: Operation not permitted
error: destination /var/log/puppetdb/puppetdb.log.1 already exists, renaming to
/var/log/puppetdb/puppetdb.log.1-2019030706.backup
error: error setting owner of /var/log/puppetdb/puppetdb.log.1 to uid 119 and
gid 125: Operation not permitted
run-parts: /etc/cron.daily/logrotate exited with return code 1
It also marks the service as "degraded" in systemd, just for good
measure.
A workaround is to not ship a logrotate.d file at all, and it's the
approach DSA has taken to solve the issue so far:
https://salsa.debian.org/dsa-team/mirror/dsa-puppet/commit/e31d91af7a8a5d9b90bc309e38067605c00d7f13
... but I wonder if we would rather not ship `logback.xml`, to follow
POLA (Principle Of Least Astonishment). That config file is:
1. XML, and therefore not quite human readable
2. non-standard, as far as basic Linux sysadmin work is concerned (it
might be "standard" in the Java world, but looks like gibberish to
me)
So I would suggest to not let PuppetDB rotate its own logs unless
there's a good reason to do so in the first place.
But in either case, we shouldn't do *both*.
PS: after investigation, I noticed this bug (#881584) was declared
fixed in 4.4.1-3, but that's not really accurate: the bug won't be
present on new installs, but on upgrade, the old config file sticks
around. So you need to somehow remove that config file on upgarde, but
I would still argue against using the logback.xml mechanism and
instead revert to using the logrotate one.
-- System Information:
Debian Release: 10.1
APT prefers stable
APT policy: (500, 'stable'), (1, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8),
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- End Message ---
--- Begin Message ---
Source: puppetdb
Source-Version: 8.4.1-2
Done: Jérôme Charaoui <[email protected]>
We believe that the bug you reported is fixed in the latest version of
puppetdb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jérôme Charaoui <[email protected]> (supplier of updated puppetdb package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 30 Aug 2024 12:32:52 -0400
Source: puppetdb
Architecture: source
Version: 8.4.1-2
Distribution: unstable
Urgency: medium
Maintainer: Puppet Package Maintainers
<[email protected]>
Changed-By: Jérôme Charaoui <[email protected]>
Closes: 941080 1077976
Changes:
puppetdb (8.4.1-2) unstable; urgency=medium
.
* remove obsolete logrotate config on upgrade (Closes: #941080)
* d/control: add Rules-Requires-Root: no
* d/control: bump Standards-Version, no changes needed
* d/tests: add allow-stderr to restrictions (Closes: #1077976)
Checksums-Sha1:
b2b5ea0073b5e284b3074b1ea54427dad25975e2 3564 puppetdb_8.4.1-2.dsc
68b5d4779d5a9831e1b8a1bd58689011faf9df49 23876 puppetdb_8.4.1-2.debian.tar.xz
59b751d56c572bc454791b3a886a0dd845cb5cc0 15955 puppetdb_8.4.1-2_amd64.buildinfo
Checksums-Sha256:
603e2f479ee4d53cc2bfca496bb49303f11fe6775c42165b0140c4fbf7cf3da4 3564
puppetdb_8.4.1-2.dsc
19733f845cc28b9a209f95f1668d0cd9ae54d8cfef5e9d103da592444de5fea4 23876
puppetdb_8.4.1-2.debian.tar.xz
ad810a30bc508397aa75bc29c0d4eb1806afe4e66cb10de76d03ee871caaea5e 15955
puppetdb_8.4.1-2_amd64.buildinfo
Files:
93768248b1df925559ee69b1c74e7fb2 3564 admin optional puppetdb_8.4.1-2.dsc
ef9571769ab8a3dcbca92bde9a031392 23876 admin optional
puppetdb_8.4.1-2.debian.tar.xz
a582cbcbc82dc27ed4456306a613f881 15955 admin optional
puppetdb_8.4.1-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQTAq04Rv2xblqv/eu5pxS9ljpiFQgUCZtIUwgAKCRBpxS9ljpiF
QiEBAP47vUCY9xSpoBlwlyMXgbj83W/hX6PbAVRyBxkOAGJrOwD/ThGzjI5B7P96
+jSkgSjQY89gHjStH21NvzsJXqKuAQM=
=TDtQ
-----END PGP SIGNATURE-----
pgp392sPzJnZS.pgp
Description: PGP signature
--- End Message ---
