Your message dated Tue, 07 Jul 2026 17:49:05 +0000
with message-id <[email protected]>
and subject line Bug#1141612: fixed in dh-runit 2.17.3
has caused the Debian Bug report #1141612,
regarding /usr/lib/runit-helper/runit-helper misses necessary service restarts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1141612: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1141612
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit-helper
Version: 2.16.6
Severity: critical
Hi,
(rationale for critical severity: makes unrelated software break)
/usr/lib/runit-helper/runit-helper only performs requested runit service
operations if the following test succeeds:
ok_pipe () {
[ -p "/etc/sv/$NAME/supervise/ok" ]
}
This test can yield both false positives and false negatives.
* False positive: /etc/sv/$NAME was a runit service, but is no longer
symlinked into the directory runsvdir monitors (e.g. due to runsvchdir), so the
supervise/ok pipe still exists but there is no process attached to it.
* False negative: if a runit service is installed in any directory other than
/etc/sv, /etc/service/$NAME/supervise/ok may exist and be a pipe without
/etc/sv/$NAME/supervise/ok existing.
I have been hit by the false-negative error on two openssh-server upgrades,
once when upgrading to 10.0p1 and once (today) with 10.4p1 -- in both cases, if
ssh is not restarted after the package upgrade, it can't accept new
connections. (If being able to ssh into a system is the entire purpose of the
system, then this even "breaks the entire system".)
My ssh runit service is not /etc/sv/ssh, so even though the openssh-server
postinst script did try to issue a runit restart command like this:
NAME='ssh' ENABLE='yes' ONUPGRADE='restart'
/usr/lib/runit-helper/runit-helper postinst "$@"
This was ineffective because runit-helper decided not to perform the restart.
If runit helper were less (unnecessarily?) complex and had just tried to "sv
restart $NAME", ssh would just have worked after the upgrade.
(On a philosophical level, I think it's better for such critical, low-level
system software to just attempt requested operations instead of trying to
anticipate all possible errors and not even making the attempt if it looks like
it might fail.)
My recommendation would be to lose 90% of the complexity in runit-helper that
deals with potentially not doing what it was asked to do; and instead
handle/mask errors (if any) after they happen.
András
-- System Information:
Distributor ID: Devuan
Description: Devuan GNU/Linux 7 (freia/ceres)
Release: 7
Codename: freia ceres
Architecture: x86_64
Kernel: Linux 7.0.13+deb14-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=hu_HU.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: runit (via /run/runit.stopit)
LSM: AppArmor: enabled
-- no debconf information
--
In DBLSPACE no one can hear you scream.
--- End Message ---
--- Begin Message ---
Source: dh-runit
Source-Version: 2.17.3
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dh-runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated dh-runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 07 Jul 2026 17:50:55 +0200
Source: dh-runit
Architecture: source
Version: 2.17.3
Distribution: experimental
Urgency: medium
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 1141612
Changes:
dh-runit (2.17.3) experimental; urgency=medium
.
* d/rules: remove trailing whitespace
* runit-helper: fix restart for services outside expected path
(Closes: #1141612)
* runit-helper: drop pidof, use dpkg's s-s-d instead
Checksums-Sha1:
5ed2a96b48b771d105899f600fd2906321cdb588 1768 dh-runit_2.17.3.dsc
9436e2816f0496cff413dc26a444cd69edd36eb7 22960 dh-runit_2.17.3.tar.xz
58987ce37f009395d71b9612533a83a7c6402b88 6148 dh-runit_2.17.3_amd64.buildinfo
Checksums-Sha256:
4559cb9bf52e532e9fa4fae374987a556acbb424c43d6e395e15ebdf2806b2df 1768
dh-runit_2.17.3.dsc
b38295736899afafeaa525fa1885ebabc9204a16db4a515603cd54d05cad8ec3 22960
dh-runit_2.17.3.tar.xz
f45133e4c49ebcf0032b9ce723b7c1e5ea71ad1ad79351dbae394641e89fe700 6148
dh-runit_2.17.3_amd64.buildinfo
Files:
da3bde49ec7a2c5af0679b4be9d120a2 1768 admin optional dh-runit_2.17.3.dsc
f701735a490e1d16bd1f54c55b2bd7bc 22960 admin optional dh-runit_2.17.3.tar.xz
5b4b67f8b26e30ad963c454b20691208 6148 admin optional
dh-runit_2.17.3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE2ji91PGnrxOd1bVNxxYb07RU7gMFAmpNNpEACgkQxxYb07RU
7gPtqw//cfB3WYEze+aL1j4Qi5Q3Q3GVIH9n9tdBaL0Hm9eWT+zbtjSDh84sGUE7
xVQHkGW3x/wtfv+2uBO1RuJrR2hNf3VXnfoaBeUpZqeAFSyNHmDG1119I0DX4hyo
PQ/3LG1vOAKQZ9tso+XbYlnhhYE+qScnGenORi9TQP9oCqFz4kOyDhL9o1tvKCR8
dnPrUAJ4mIwnBg0lfvb9h/WUTMTJzHRlwWG8CRGvyEGWPexuXLJGqtmJa50plZkT
4Nzp20LY+eQy3+axzNy1hzyoTgOMe6933fJC1/LRoWQZtX1pgjCVQ4HOLBAnrfTQ
9HqntefFDhkyWVpy4kqYr8cmdr6k9CF8lNALXmgdanuOCTaax5Qw6ZGlxJu5qaQR
9DiDaq1rPijCyfYzEXBXjYxDsQkUFkNpPXl8PNc4JSrlEur5KM4J2Nkt2VDsGTMp
pADplrTGel0FAzG/dDS1MerUJUn22ZQZHqaVWvasbdFMhyaFHvJodDo64IGEGs46
fLceqoCfgcGafl27bwNZF4u772Lu/AoDZR9vPiWV8KZG+AFLLeuyWopvfyo98vVc
OYT7YQWL2RIubzpJEKB4wVRY/UXraNHq5iupmb2S5x9K9vSdbHVJ3N0PRCSD+vQs
xZx/sXzuHHxn3g3xYEZz8crojqCjx7vCAoKtjGNwD4fEnGXxOVA=
=+1Tf
-----END PGP SIGNATURE-----
pgpO3JqlWhM7Y.pgp
Description: PGP signature
--- End Message ---
