Your message dated Tue, 07 Jul 2026 19:19:40 +0000
with message-id <[email protected]>
and subject line Bug#1141612: fixed in dh-runit 2.16.7
has caused the Debian Bug report #1141612,
regarding /usr/lib/runit-helper/runit-helper misses necessary service restarts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1141612: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1141612
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit-helper
Version: 2.16.6
Severity: critical
Hi,
(rationale for critical severity: makes unrelated software break)
/usr/lib/runit-helper/runit-helper only performs requested runit service
operations if the following test succeeds:
ok_pipe () {
[ -p "/etc/sv/$NAME/supervise/ok" ]
}
This test can yield both false positives and false negatives.
* False positive: /etc/sv/$NAME was a runit service, but is no longer
symlinked into the directory runsvdir monitors (e.g. due to runsvchdir), so the
supervise/ok pipe still exists but there is no process attached to it.
* False negative: if a runit service is installed in any directory other than
/etc/sv, /etc/service/$NAME/supervise/ok may exist and be a pipe without
/etc/sv/$NAME/supervise/ok existing.
I have been hit by the false-negative error on two openssh-server upgrades,
once when upgrading to 10.0p1 and once (today) with 10.4p1 -- in both cases, if
ssh is not restarted after the package upgrade, it can't accept new
connections. (If being able to ssh into a system is the entire purpose of the
system, then this even "breaks the entire system".)
My ssh runit service is not /etc/sv/ssh, so even though the openssh-server
postinst script did try to issue a runit restart command like this:
NAME='ssh' ENABLE='yes' ONUPGRADE='restart'
/usr/lib/runit-helper/runit-helper postinst "$@"
This was ineffective because runit-helper decided not to perform the restart.
If runit helper were less (unnecessarily?) complex and had just tried to "sv
restart $NAME", ssh would just have worked after the upgrade.
(On a philosophical level, I think it's better for such critical, low-level
system software to just attempt requested operations instead of trying to
anticipate all possible errors and not even making the attempt if it looks like
it might fail.)
My recommendation would be to lose 90% of the complexity in runit-helper that
deals with potentially not doing what it was asked to do; and instead
handle/mask errors (if any) after they happen.
András
-- System Information:
Distributor ID: Devuan
Description: Devuan GNU/Linux 7 (freia/ceres)
Release: 7
Codename: freia ceres
Architecture: x86_64
Kernel: Linux 7.0.13+deb14-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=hu_HU.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: runit (via /run/runit.stopit)
LSM: AppArmor: enabled
-- no debconf information
--
In DBLSPACE no one can hear you scream.
--- End Message ---
--- Begin Message ---
Source: dh-runit
Source-Version: 2.16.7
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dh-runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated dh-runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 07 Jul 2026 19:35:06 +0200
Source: dh-runit
Architecture: source
Version: 2.16.7
Distribution: unstable
Urgency: medium
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 1141612
Changes:
dh-runit (2.16.7) unstable; urgency=medium
.
* runit-helper: fix restart for services outside expected path
(Closes: #1141612)
* runit-helper: drop pidof, use dpkg's s-s-d instead
Checksums-Sha1:
aba6296ebf8d0de1e036e2e8da7a522159a8b400 1786 dh-runit_2.16.7.dsc
b503c0297f1b0b68d00b0203a13048c08c6427fc 18592 dh-runit_2.16.7.tar.xz
a7e56876521ad96818442cdfbb7b4ed3f2abdc43 7124 dh-runit_2.16.7_amd64.buildinfo
Checksums-Sha256:
e3a8c2fa23d05e145748aa80cec2498c7d3ad32ac87adbc35eab44315e7b1ccc 1786
dh-runit_2.16.7.dsc
e478ac7ab7e9765355907f435eb70025c5906f99f16b726af03b61b82f21147e 18592
dh-runit_2.16.7.tar.xz
62a220fb14d467f057172d8a2a3a3bb1a7d4255f21a97ece285798680c68854a 7124
dh-runit_2.16.7_amd64.buildinfo
Files:
04a1d7bbde131f277b932834d0a3304e 1786 admin optional dh-runit_2.16.7.dsc
d355144f15d6061e66e06d47d3e98729 18592 admin optional dh-runit_2.16.7.tar.xz
358db64176cf2fba95c1f36db9bd5bf3 7124 admin optional
dh-runit_2.16.7_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE2ji91PGnrxOd1bVNxxYb07RU7gMFAmpNTikACgkQxxYb07RU
7gMbGw/+PZ6JRcicZmjW9f4R94+he2Tyg2TDJxk95AOqJmpwBinYjVceEvkB/Sxo
DbWaGYetWkm7E63UGiXh7S9hrN+NEL6WY7iFiLsoxlUUeu8qy/Tao6fXIHzl9WgD
nvM6ScKbVNa6Tn7ty75XK131oEOQ71E+KzcUkAgmB1sE7b8BmSW6QstQaax/NfYI
xJV5GfeNHMwHmjCQKbFEFKCYQM8zlvTamdeP0QkiLQ0egTqxKByeUPrsgR8bpgFO
mmZt/hoZh3ecH8p0+HfE8tCZoaErztZJBHhdXA+6A+d0zHulTzUTsZFn9Mm/tWCr
okKfRZRp16jYPhqSRm/KtlP+l5NoMUfhM+OaaEhycZpO962HIDp8pF/3nRq54Ma9
v98wBHj3I9fLNVAuqBKoy0bgVYNsEIAO+86L1A7yqtT343yD5J8P5A0eJ8UO7vEk
Kx3OekhC3i1okuvoHFwsQAxlwVeKCovgT0LgSL5yGgHXja5AAe/7g30zgtvwAB9i
LxMOEGJbvKtwzJWeFnEBiuCLzOYTACzdknc5bIPjYfNjeW0I/PBS141YckRayrcu
pIiX5GmnDqWrP7LtIYrZwch6E4ZHVabUeuv/l1SvBkgw9yJH7BEjl09LjbkhQ2+4
zJBLn+GyNa/yP/jTaoMLQXzQvUSUj3YnaEW+fICJuSiuB2u3Mq4=
=4aWE
-----END PGP SIGNATURE-----
pgpYf7OTtlR5w.pgp
Description: PGP signature
--- End Message ---
