Hi,
> IANADD, but here's a list of things that I encountered while testing
> out your package.
Thanks a lot for a review.
> - Since you use xz compression, please consider adding Pre-Depends:
> dpkg (>= 1.15.6) to debian/control (i.e. lintian tag
> data.tar.xz-member-without-dpkg-pre-depends, which I think has been
> recently removed).
Yes, I am aware of this lintian note, but I ignore it because:
1) It is useless for new packages.
2) "Pre-Depends should be used sparingly, preferably only by packages whose
premature upgrade or installation would hamper the ability of the system
to continue with any upgrade that might be in progress.
You should not specify a Pre-Depends entry for a package before this has
been discussed on the debian-devel mailing list and a consensus about
doing that has been reached." [1]
[1] http://www.debian.org/doc/debian-policy/ch-relationships.html
> This is more of a pedantic issue than something
> strictly necessary, but it does help backporters.
There is dpkg verison 1.15.8.13 in Debian Squeeze:
http://packages.debian.org/squeeze/dpkg
Older releases are not supported.
> - Another pedantic issue: there are 2 commas in a row in your
> build-depends list for astromenace-data (i.e. debhelper (>=
> 9),,fonts-liberation...).
Thanks. I'll fix it ASAP. Hope it will be today, because since tomorrow I
will be on vacation during two weeks.
> - Dmitry Smirnov is listed as an Uploader for astromenace but not for
> astromenace-data; is this intended?
I am not sure that he want to co-maintain it. But he could add or remove
himself from uploaders list at any moment. Dmitry, could you comment this?
> - Please make astromenace depend on astromenace-data, not just
> recommends
This is bad idea because astromenace-data has build dependency from
astromenace and it FTBFS if astromenace depends from it. (Circular
dependencies.) So it should stay as is, at least for a first iteration.
> (and have astromenace-data recommends/suggests
> astromenace), as is the norm for packages which depend on a separate
> -data package.
> - astromenace-data FTBFS when built twice in a row:
Hmm, I missed this. Thanks. Will be fixed.
Best regards,
Boris
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
