Hi Jonas, On 2013-09-01 19:05:52, Jonas Smedegaard wrote: > It seems photofloat does some attempt at reusing JavaScript packages, > by use of symlinks, but lack declaring dependency on them,
I think that will be fixed with the next upload, that's #721562, right? > and still ship with minified files, and a file scripts.min.js bundling > seemingly bundling all JavaScript files - assumingly from included > convenience code copy, not from the separately maintained library > packages. Right, that's the intention anyways. > The package should solely use Javascript library packages for reusable > Javascript code - including getting the jQuery modules packaged which do > not currently exist: If not interested in maintaining those packages > yourself try ask the JavaScript Team to take care of that. Indeed, I think Jerome took care of that. > For the bundling file I think best would be for the package to generate > that file using a dpkg trigger, so that it gets regenerated whenever one > of its dependent library packages are updated. That makes sense. I am not familiar with dpkg triggers, any pointers on where to start? > The bundle file is most optimally minimized if done in one go, instead > of concatenating individually minimized parts. The most efficient and > also most reliable minimizer is uglifyjs. Noted. > Seems only the minified bundle file is the only JavaScript file needed > at the location for use at runtime - other files and symlinks to files > might be better located at a different location, if setting up above > suggested auto-bundling. Right. Maybe we don't even need to ship those in the binary package at all. There are some rough edges in the packaging, I just wanted to get this out the door. I have also made some noise upstream about some patches in the software itself which is itself pretty rough: http://lists.zx2c4.com/pipermail/photofloat/2014-January/000031.html Hopefully things will settle down with time. Thanks for your excellent feedback in any case, A. -- Il n'existe aucune limite sacrée ou non à l'action de l'homme dans l'univers. Depuis nos origines nous avons le choix: être aveuglé par la vérité ou coudre nos paupières. - [no one is innocent]
pgpn5H6J4C6dX.pgp
Description: PGP signature
