Quoting Jerome Charaoui (2014-01-27 06:37:13) > That should do the trick. Antoine, I should note that instead of > creating a distinct "update-photofloat-js" as we discussed, I reverted > to shipping the upstream Makefile and simply call that to > minify+bundle js.
Shipping the makefile cause the binary package to depend on make. That's inelegant but more importantly it raise the risk of flaws e.g. in how errors are handled. ...and regarding errors: Seems you only only recommend yui-compressor, but the makefile fails hard if that isn't available. ...and regarding yui-compressor: Dependin on that at runtime pulls in Java, which I find inelegant and annoying. Please consider use the scss tool (from package ruby-sass) instead: the SCSS dataformat is a superset of CSS so you can simply use plain CSS as input. If the thought of then pulling in Ruby displeases you, then consider libtext-sass-perl or python-pyscss. ...and regarding CSS compression: Please consider not compressing at all but only cat'ing those files (or use "sass --style expanded" during build, which then serves to also checks validity of that code) and install it below /etc, and put a symlink at the original location, to allow system owner to customize default look. Oh, and while I am at it - it seems you don't need TeX with lmodern, and thus should depend not on lmodern but fonts-lmodern. If you insist on using make, I suggest to invoke it in make fashion: make -C /usr/share/photofloat/web js/scripts.min.js - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
