Quoting Jerome Charaoui (2014-01-29 18:35:23) > Le 2014-01-27 06:07, Jonas Smedegaard a écrit : >> Shipping the makefile cause the binary package to depend on make. >> That's inelegant but more importantly it raise the risk of flaws e.g. >> in how errors are handled. >> >> ...and regarding errors: Seems you only only recommend >> yui-compressor, but the makefile fails hard if that isn't available. > > In the interest of keeping maintenance down, I thought it was better > to rely on upstream code rather than ship a custom script. In this > state, the Makefile only fails in the absence of yui-compressor if the > user modifies the CSS. Not ideal, for sure, but not package-breaking > either.
Fair enough. Just wanted to point it out (lazily: didn't check myself closely) in case you'd missed something. >> ...and regarding yui-compressor: Dependin on that at runtime pulls in >> Java, which I find inelegant and annoying. Please consider use the >> scss tool (from package ruby-sass) instead: the SCSS dataformat is a >> superset of CSS so you can simply use plain CSS as input. If the >> thought of then pulling in Ruby displeases you, then consider >> libtext-sass-perl or python-pyscss. >> >> ...and regarding CSS compression: Please consider not compressing at >> all but only cat'ing those files (or use "sass --style expanded" >> during build, which then serves to also checks validity of that code) >> and install it below /etc, and put a symlink at the original >> location, to allow system owner to customize default look. > > You've already raised most of these (good, imo) ideas in bug #721568. Oh, right. Silly me. > This bug report and patch are aimed are improving the javascript > situation. Please don't assume that we are ignoring the rest of your > suggestions just because everything doesn't get fixed in a single > patch. :) It was a simple case of failing memory :-) - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
