On 30.04.2014 06:06, Tobias Frost wrote:
> Dear maintainer,
>
> I've prepared an NMU for isdnutils (versioned as 1:3.25+dfsg1-3.4). The diff
> is attached to this message.

Thank you for your work.

I agree with most of the changes you propose.  Here are the ones where I
differ.

> --- isdnutils-3.25+dfsg1/debian/control       2013-06-06 12:36:15.000000000 
> +0200
> [...]
> - automake, autoconf, libssl-dev, psutils,
> + automake, autoconf, libssl-dev, psutils, libcapi20-dev (>=1:3.27),

I don't think there is a need for a versioned dependency.  I suggest to
drop it to an unversioned one.

> -Depends: libcapi20-3 (= ${binary:Version}), ${shlibs:Depends},
> +Depends: ${shlibs:Depends},

Are you sure the new package no longer needs a dependency on libcapi20-3
or that this will be picked up automatically?

> -Depends: ppp (>= 2.4.4), ppp (<< 2.4.6), libcapi20-3 (= ${binary:Version}),
> +Depends: ppp (>= 2.4.6), ppp (<< 2.4.7),

I'd keep the lower bound at 2.4.4.  Do you have specific reasons to
believe that anything below 2.4.6 will stop working?

> --- isdnutils-3.25+dfsg1/debian/isdnutils-base.cron.d 2013-06-06 
> 12:36:15.000000000 +0200
> +++ isdnutils-3.25+dfsg1/debian/isdnutils-base.cron.d 1970-01-01 
> 01:00:00.000000000 +0100

I don't see a reason for removal of this file in this NMU.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to