Thank you for the quick reply.

On 30.04.2014 19:02, Tobias Frost wrote:
>>> --- isdnutils-3.25+dfsg1/debian/control     2013-06-06 12:36:15.000000000 
>>> +0200
>>> [...]
>>> - automake, autoconf, libssl-dev, psutils,
>>> + automake, autoconf, libssl-dev, psutils, libcapi20-dev (>=1:3.27),
>> I don't think there is a need for a versioned dependency.  I suggest to
>> drop it to an unversioned one.
> I added the versioned dependency to ensure that the new pacakged version is
> used and never the one included in isdnutils. I'd keep it.

Your reasons for the additions were easily understood.  Yet, there
simply is no need for that. The older versions of the package are
absolutely fine if that is what is available.  The versioned dependency
is artificial and thus detrimental.

>>> -Depends: ppp (>= 2.4.4), ppp (<< 2.4.6), libcapi20-3 (= ${binary:Version}),
>>> +Depends: ppp (>= 2.4.6), ppp (<< 2.4.7),
>> I'd keep the lower bound at 2.4.4.  Do you have specific reasons to
>> believe that anything below 2.4.6 will stop working?
> Won't work as the ppp's plugin-directory contains the version number.
> Like here: https://packages.debian.org/sid/amd64/pppdcapiplugin/filelist

I see.  In that case, the build-time dependency will need to receive an
appropriate versioning, too.

>>> --- isdnutils-3.25+dfsg1/debian/isdnutils-base.cron.d       2013-06-06
>>> 12:36:15.000000000 +0200
>>> +++ isdnutils-3.25+dfsg1/debian/isdnutils-base.cron.d       1970-01-01
>>> 01:00:00.000000000 +0100
>> I don't see a reason for removal of this file in this NMU.
>>
> Yes, this patch slipped in when applying the patch from Ubuntu (see #710359).
> However, this fixes #698785, so proably could/should be left in as well. Let
> me know if you veto.

Indeed, the file is wrong.  It is an inittab file.  Simply removing it
is not the proper fix, though, it needs to be put in the appropriate
place.  I'd leave that for a future upload if I were you.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to