Hi Martin, 2014-07-16 9:15 GMT+01:00 Martin Quinson <[email protected]>: > Hello, > > I guess that the packages are now ready to upload, and I'm willing to > do so in the next, but I would really appreciate your review first, > please.
In the next...? Thanks for your work on this anyway, and for keeping the flame (flare? :-)) alive. I don't have as much time/energy as I used to, and I've been working on other things in Debian and elsewhere. So I tried to look at this like a month ago but then fell out of my focus again. I also though that perhaps there would be a new upstream version before Jessie's freeze, but it doesn't seem likely at this point, so I guess that we'll go with the one to be uploaded. > I reduced the amount of patches to its minimum. In particular, I'm not > renaming the binary nor adding a helper script file. Instead, I got > the flare engine binary to refuse starting without a game specied. If > someone simply types "flare", s/he gets: > > | flare: You must specify a game to play on the command line. Example: > | flare --game=flare-game > > I guess that this is good enough. Upstream is aware of the problem: > https://github.com/clintbellanger/flare-engine/issues/1039 Didn't test this, but I wonder what happens if one tries to launch it via GUI menu... will it fail to start? Will the users see the error, at least? If it does not work as it is now, perhaps it would be a solution to specify the game in the "command line" of the .desktop file, creating different .desktops for the games present. > Then, I simply added two lintian overrides for errors that are due to > the split between packages. I checked, and these overrides are common > in other games that come with engine/data packages produced by > separate source packages. > > flare-engine source: version-substvar-for-external-package flare-engine -> > flare-game > flare-game: desktop-command-not-in-package > usr/share/applications/flare.desktop usr/games/flare This is fine, I think. > So I think this is it. The game is finally correctly packaged. > > Could you please have a look before I upload this? Nitpicking really, but an explicit dependency on quilt is not needed, as far as I know, since recent (<2 years or so) versions of dpkg can handle it. But I don't have any pointer to documentation to show you, so in case of doubt you can leave it. http://anonscm.debian.org/gitweb/?p=pkg-games/flare-engine.git;a=commitdiff;h=cc76f514a4d9af43b156b46c0879623f13aee57a I think that the rest is fine, from what I remember from past discussions I thought that the job was mostly done and I was already happy with the status. Of course, it's likely that some unexpected problems arise, but even in the worst cases the package is not important enough to cause massive problems to users. And in any case, it's better to catch the problems well before the freeze :-) So please go ahead whenever you feel ready. Cheers. -- Manuel A. Fernandez Montecelo <[email protected]> -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
