Control: tags -1 +patch +pending

Hi Jakub,

Le lundi, 4 août 2014, 20.11:33 Jakub Wilk a écrit :
> * Didier 'OdyX' Raboud <o...@debian.org>, 2014-08-03, 01:21:
> >* The udev rule seems to be working
> 
> As I noted previously, it didn't work here, unless I renamed the rule
> file. But now I checked again, and it works without renaming. Very
> odd. Possibly related bug: #754348
> 
> >Jakub: could you (out of luck) try the attached patch that reverts
> >this?
> 
> I don't think this will be necessary; see below.
> 
> >>More importantly, jimctl doesn't seem to honour TMPDIR. :-(
> >
> >Thanks for the catch, I've reported this upstream:
> >https://github.com/msteveb/jimtcl/issues/17
> 
> So I cherry picked the upstream patch for jimtcl, and patched
> /lib/udev/usb_modeswitch to use TMPDIR. Now the device switches
> correctly. \o/

Yay. So we're on the good track here. I've cherry-picked the upstream 
patch on top of the new upstream release [0] and it's now pending in 
binary-NEW [1]. I might upload 0.74-2 with that patch in the meantime.

As for usb-modeswitch, I'm considering the attached patch to use /run as 
TMPDIR for all three init systems. Expect an upload soon'ish.

Cheers,
OdyX

[0] 
http://anonscm.debian.org/cgit/collab-maint/jimtcl.git/commit/?id=ec11aff0a36e7d2d847d88c7a1eecbedb2bb2cde
[1] https://ftp-master.debian.org/new/jimtcl_0.75-1.html

--- a/usb-modeswitch-upstart.conf
+++ b/usb-modeswitch-upstart.conf
@@ -1,5 +1,6 @@
 start on usb-modeswitch-upstart
 task
+env TMPDIR=/run
 script
 	exec /usr/sbin/usb_modeswitch_dispatcher --switch-upstart $UMS_PARAM
 end script
--- a/usb_modeswitch.sh
+++ b/usb_modeswitch.sh
@@ -82,6 +82,7 @@
 		elif [ -d "/run/systemd/system/" ]; then # Test if systemd is running
 			exec /bin/systemctl --no-block start usb_modeswitch@$1.service
 		else
+			export TMPDIR=/run
 			exec /usr/sbin/usb_modeswitch_dispatcher --switch-mode $1 &
 		fi
 		exit 0
--- a/usb_modeswitch@.service
+++ b/usb_modeswitch@.service
@@ -4,3 +4,4 @@
 [Service]
 Type=oneshot
 ExecStart=/usr/sbin/usb_modeswitch_dispatcher --switch-systemd %I
+Environment="TMPDIR=/run"

Reply via email to