On Mon, Jan 12, 2015 at 04:24:24PM +0000, Steve McIntyre wrote: >> >>This all looks reasonable enough, but why not "return is_64_kernel () ? >>64 : 32;" here? Then you could simplify >>grub_install_get_default_x86_platform to just conditionalise on "if >>(read_platform_size () == 64)" and avoid duplication. > >Could do, yes. I personally tend to shy away from ternary usage like >that, but meh. :-) OK, how about: > >--- grub-core/osdep/linux/platform.c.org 2015-01-12 16:03:03.942786770 >+0000 >+++ grub-core/osdep/linux/platform.c 2015-01-12 16:23:12.367107511 +0000
Hi Colin, Does this newer patch look OK for you? -- Steve McIntyre, Cambridge, UK. [email protected] Armed with "Valor": "Centurion" represents quality of Discipline, Honor, Integrity and Loyalty. Now you don't have to be a Caesar to concord the digital world while feeling safe and proud. -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
