On Tue, Jan 27, 2015 at 08:12:51PM +0000, Colin Watson wrote: >On Mon, Jan 12, 2015 at 04:24:24PM +0000, Steve McIntyre wrote: >> On Mon, Jan 12, 2015 at 03:17:39PM +0000, Colin Watson wrote: >> >This all looks reasonable enough, but why not "return is_64_kernel () ? >> >64 : 32;" here? Then you could simplify >> >grub_install_get_default_x86_platform to just conditionalise on "if >> >(read_platform_size () == 64)" and avoid duplication. >> >> Could do, yes. I personally tend to shy away from ternary usage like >> that, but meh. :-) > >I meant this as a rough sketch rather than literal code ...
Yeah, OK... >> OK, how about: > >Looks good, thanks! Sorry for the delay in reviewing this. I've pushed >it to the Debian master branch. Lovely, ta. I've also been remiss in taking it upstream so far. -- Steve McIntyre, Cambridge, UK. [email protected] "Further comment on how I feel about IBM will appear once I've worked out whether they're being malicious or incompetent. Capital letters are forecast." Matthew Garrett, http://www.livejournal.com/users/mjg59/30675.html -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
