Package: freedombox-setup Version: 0.3 Severity: minor Tags: patch Hello,
Attached patch proposes to remove pagekite from recommends list of freedombox- setup since Plinth has the ability to install it when necessary. In general, allowing more and more optional modules to be installed and managed by Plinth is better. - If user input is required for making a setup decision it can be presented in Plinth during first boot or when enabling the module. - Plinth can and will be split in modules which are individually packaged. This make allows for things to be more modular. - If the module requires UI, then it need not be split into two parts: freedombox-setup part and the Plinth. Everything can happen in Plinth. - FreedomBox setup is harder to debug and test compared to Plinth. These arguments are for non-essential modules only. -- Sunil -- System Information: Debian Release: 8.0 APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386, armhf Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
>From 4f0c2849de42ea8d4b877b20a1fb55370699715e Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa <[email protected]> Date: Fri, 13 Feb 2015 14:54:22 +0530 Subject: [PATCH] Remove pagekite as recommendation In general, allowing more and more optional modules to be installed and managed by Plinth is better. - If user input is required for making a setup decision it can be presented in Plinth during first boot or when enabling the module. - Plinth can and will be split in modules which are individually packaged. This make allows for things to be more modular. - If the module requires UI, then it need not be split into two parts: freedombox-setup part and the Plinth. Everything can happen in Plinth. - FreedomBox setup is harder to debug and test compared to Plinth. These arguments are for non-essential modules only. --- debian/changelog | 4 ++++ debian/control | 1 - debian/freedombox-setup.freedombox-first-run.init | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/debian/changelog b/debian/changelog index d530cbc..cf4a5f6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -10,6 +10,10 @@ freedombox-setup (0.4) UNRELEASED; urgency=low interface now. * Update jwchat test to check /jwchat URL. + [ Sunil Mohan Adapa ] + * Remove pagekite recommendation as Plinth now takes care of its + installation and setup. + -- Petter Reinholdtsen <[email protected]> Sun, 14 Dec 2014 20:26:25 +0100 freedombox-setup (0.3) unstable; urgency=low diff --git a/debian/control b/debian/control index 3e23173..2c6e695 100644 --- a/debian/control +++ b/debian/control @@ -77,7 +77,6 @@ Recommends: batctl , rfkill , wireless-tools - , pagekite Suggests: monkeysphere Description: Package to set up freedombox environment diff --git a/debian/freedombox-setup.freedombox-first-run.init b/debian/freedombox-setup.freedombox-first-run.init index 3311345..2775574 100755 --- a/debian/freedombox-setup.freedombox-first-run.init +++ b/debian/freedombox-setup.freedombox-first-run.init @@ -5,7 +5,7 @@ # Default-Stop: # Required-Start: $network $remote_fs $syslog # Required-Stop: $remote_fs $syslog -# Should-Start: firewalld tor haveged lxc pagekite +# Should-Start: firewalld tor haveged lxc # Short-Description: Finish Freedombox install after first boot # Description: # Script to complete the post-install process on first FBX boot. -- 2.1.4
