Hi, Quoting Daniel Schepler (2015-08-26 19:02:56) > On Wed, Aug 26, 2015 at 9:19 AM, Felix Geyer <fge...@debian.org> wrote: > > I've added a stage1 build profile to disable building the Qt GUI: > > > > http://anonscm.debian.org/cgit/collab-maint/cmake.git/commit/?h=experimental&id=a8bc51cb82c1ea7b5ba8ba72b39d764d22f5b828 > > > Looks good - just one minor comment: I tend to use "filter" instead of > "findstring". It probably doesn't make that much difference, though - it's > not too likely that somebody will try to use another profile name that > contains "stage1".
For what it's worth, the canonical way of checking whether a profile is active is in the build profile spec: https://wiki.debian.org/BuildProfileSpec#The_DEB_BUILD_PROFILES_environment_variable It indeed uses "filter" as Daniel already pointed out. > > A difference between using the system libraries vs. the bundled one might > > be the feature set that curl is built with. Afaik cmake uses curl to > > submit test results to a dashboard and to allow downloading files during a > > build. I wouldn't expect differences in curl to impact cmake in the > > context of Debian package builds. > > > > On the other hand, it would impact user-visible functionality. See for > example http://www.cmake.org/pipermail/cmake/2014-October/058911.html. So, > doing this without a rename of the resulting cmake package would technically > violate the requirement we're discussing. Whether it's a small enough > violation that it could be ignored, I don't really know. > > I'd be fine with adding this to cmake. Please let me know if this would be > useful. I CC-ed Helmut who is currently the best person to know whether making libcurl*-dev optional for src:cmake makes any sense at all or not. Thanks! cheers, josch
signature.asc
Description: signature
