On Tue, Jun 23, 2015 at 11:14:07PM +0100, Dominic Hargreaves wrote:
> Source: latex2html
> Version: 2008-debian1-10
> Severity: important
> User: [email protected]
> Usertags: perl-5.22-transition
> Tags: sid stretch upstream
>
> This package FTBFS with perl 5.22 (currently in experimental):
>
> Extension: loading /«PKGBUILDDIR»/versions/math.pl
> Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at
> /«PKG
> BUILDDIR»/versions/frame.pl line 357.
> Compilation failed in require at ../latex2html line 11035.
> make[3]: *** [fresh] Error 255
> Extension: loading /«PKGBUILDDIR»/versions/frame.plMakefile:171: recipe for
> targ
> et 'fresh' failed
It looks like perl's suggestion to omit defined may be wrong here, since
the code seems nonsensical, since $colorset is set to a scalar, and then
treated as an arrayref:
sub check_frame_colorset {
[...]
local($colorset);
if ($reverse == 0) {$colorset="${which}_colorset"}
elsif ($reverse == 1) {$colorset="${which}_colorset_star"}
elsif ($reverse == 2) {$colorset="${which}_colorset_star_star"}
else {$colorset="${which}_colorset"}
if (!(defined @$colorset))
{ print STDERR "\nframes for $which are not supported\n"; return($rest);}
[...]
Possibly this should be replaced with "if (!(defined $colorset))" but I'd
like an opinion from someone who is more familiar with this codebase.
Cheers,
Dominic.
