Package: libconfig-model-dpkg-perl
Version: 2.069
Severity: minor
Hi,
using scan-copyrights I get output like this for some files:
Path debian/copyright.new has no license info. Add a line in
debian/fill.copyright.blank file
1.)
This is misleading, the correct filepath is
debian/fill.copyright.blanks.yml. Attached patch fixes this, a
redundancy in the output when loading this file, and a capitalization error.
2.)
You already have documented this feature in
lib/Dpkg/Copyright/Scanner.pm, but this is not available in man
scan-copyrights. I didn't want to dive into the whole
buildsystem/perl/whatever, so no patch here.
Thanks a lot. This is the first time I use scan-copyrights, but I really
like it.
Greets
jre
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.3.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages libconfig-model-dpkg-perl depends on:
ii devscripts 2.15.9
ii libapt-pkg-perl 0.1.29+b3
ii libarray-intspan-perl 2.003-1
ii libconfig-model-perl 2.074-1
ii libexporter-lite-perl 0.06-1
ii liblog-log4perl-perl 1.44-1
ii libmouse-perl 2.4.5-1
ii libparse-recdescent-perl 1.967013+dfsg-1
ii libsoftware-license-perl 0.103010-4
ii libtext-autoformat-perl 1.720000-1
ii libtext-levenshtein-damerau-perl 0.41-1
ii liburi-perl 1.69-1
ii libwww-perl 6.13-1
ii lintian 2.5.38
ii perl 5.20.2-6
ii perl-modules [libmodule-corelist-perl] 5.20.2-6
Versions of packages libconfig-model-dpkg-perl recommends:
ii libconfig-model-tkui-perl 1.350-1
libconfig-model-dpkg-perl suggests no packages.
-- no debconf information
diff --git a/lib/Dpkg/Copyright/Scanner.pm b/lib/Dpkg/Copyright/Scanner.pm
index c46d7b2..1306cd2 100644
--- a/lib/Dpkg/Copyright/Scanner.pm
+++ b/lib/Dpkg/Copyright/Scanner.pm
@@ -174,10 +174,10 @@ sub scan_files ( %args ) {
}
if ( $c =~ /no-info-found/ and $is_debian_package) {
- _warn "Path $f has no copyright info. Add a line in debian/fill.copyright.blank file\n";
+ _warn "Path $f has no copyright info. Add a line in debian/fill.copyright.blanks.yml\n";
}
if ( $l =~/unknown/i and $is_debian_package ) {
- _warn "Path $f has no license info. Add a line in debian/fill.copyright.blank file\n";
+ _warn "Path $f has no license info. Add a line in debian/fill.copyright.blanks.yml\n";
}
#say "Storing '$f' : '$c' '$l'";
@@ -186,7 +186,7 @@ sub scan_files ( %args ) {
my @notused = grep { ! $fill_blank_data->{$_}{used} and $_; } sort keys %$fill_blank_data ;
if (@notused) {
- _warn "Warning: the following entries from fill.copyright.blanks were not used\n- '"
+ _warn "Warning: the following entries from fill.copyright.blanks.yml were not used\n- '"
.join("'\n- '",@notused)."'\n";
}
@@ -465,7 +465,7 @@ sub __load_fill_blank_data ($current_dir) {
if ($debian->is_dir) {
my @fills = $debian->children(qr/fill\.copyright\.blanks\.yml$/);
- say "Note: loading @fills fixes from copyright fix files" if @fills and not $quiet;
+ say "Note: loading @fills fixes" if @fills and not $quiet;
foreach my $file ( @fills) {
my $yaml = $file->slurp_utf8;
my $data = Load $yaml;
@@ -537,7 +537,7 @@ will be used. Unfortunately, this will prevent a correct grouping and
merging of copyright entries.
Instead of patching upstream source files to fill the blank, you can
-specify the missing information in a special file. THis file is
+specify the missing information in a special file. This file is
C<debian/fill.copyright.blanks.yml>. It should contain a "mapping"
YAML structure (i.e. a hash), where the key is a Perl pattern used to
match a path. E.g:
