Control: tag -1 +pending, fixed-upstream

On Thu, 2016-04-07 at 16:33 +0530, Ritesh Raj Sarraf wrote:
> About cpufreq-info's output, I think after re-reading Arjan's explanation, it
> makes sense.
> 

I've changed the defaults to what has been proposed in this bug report. Why 50%
was chosen, I really don't have an answer. But thanks for reporting the bug. I
took time to monitor it today, and the improvements are good, and there is no
negative power impact.

I don't intend another point release immediately. So, until the next release,
please change the values.


Exact git commit is:

commit 07457235f45630b7b5b0091eed7774fe7fb39147
Author: Ritesh Raj Sarraf <[email protected]>
Date:   Thu Apr 7 19:05:42 2016 +0530

    Fix defaults for Intel P State Driver
    
    Thanks: George Caswell and Matthew Gabeler-Lee
    Closes: #814578
    
    The LMT P State module's history shows the ONBATT default value of 50. I
    have no history on why that was chosen. But reading up the docs, and
    looking at  the feedback from reporters (thanks), this seems to be
    wrong.
    
    Intel P State driver is self sufficient in scaling in/out the frequency
    and voltage based on the state of the machine. There isn't a need to do
    much from sysfs, for the default cases.
    
    Reference:
    https://software.intel.com/en-us/articles/power-management-states-p-states-c
-states-and-package-c-states#_Toc383778909

diff --git a/etc/laptop-mode/conf.d/intel_pstate.conf b/etc/laptop-
mode/conf.d/intel_pstate.conf
index 9b11844..d060c1d 100644
--- a/etc/laptop-mode/conf.d/intel_pstate.conf
+++ b/etc/laptop-mode/conf.d/intel_pstate.conf
@@ -27,16 +27,16 @@ DEBUG=0
 CONTROL_INTEL_PSTATE="auto"
 
 #On AC, Laptop Mode Tools inactive
-NOLM_AC_INTEL_PSTATE_PERF_MIN_PCT=25 # Minimum performance, in percent
+NOLM_AC_INTEL_PSTATE_PERF_MIN_PCT=0 # Minimum performance, in percent
 NOLM_AC_INTEL_PSTATE_PERF_MAX_PCT=100 # Maximum performance, in percent
 NOLM_AC_INTEL_PSTATE_NO_TURBO=0 # Disable "Turbo Boost"?
 
 #On AC, Laptop Mode Tools active
-LM_AC_INTEL_PSTATE_PERF_MIN_PCT=25 # Minimum performance, in percent
+LM_AC_INTEL_PSTATE_PERF_MIN_PCT=0 # Minimum performance, in percent
 LM_AC_INTEL_PSTATE_PERF_MAX_PCT=100 # Maximum performance, in percent
 LM_AC_INTEL_PSTATE_NO_TURBO=0 # Disable "Turbo Boost"?
 
 #On battery
 BATT_INTEL_PSTATE_PERF_MIN_PCT=0 # Minimum performance, in percent
-BATT_INTEL_PSTATE_PERF_MAX_PCT=50 # Maximum performance, in percent
+BATT_INTEL_PSTATE_PERF_MAX_PCT=100 # Maximum performance, in percent
 BATT_INTEL_PSTATE_NO_TURBO=1 # Disable "Turbo Boost"?



Thanks.
-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to