Source: gpsd
Version: 3.12-1
Severity: important
Tags: patch upstream
User: [email protected]
Usertags: hurd

gpsd FTBFS on hurd-i386:

Creating 'gpsd_config.h'
gcc -o ais_json.os -c -g -O2 -fstack-protector-strong -Wformat 
-Werror=format-security -Wextra -Wall -Wno-uninitialized 
-Wno-missing-field-initializers -Wcast-align -Wmissing-declarations 
-Wmissing-prototypes -Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread 
-Wmissing-declarations -O2 -pthread -fPIC -D_FORTIFY_SOURCE=2 
-I/usr/include/dbus-1.0 -I/usr/lib/i386-gnu/dbus-1.0/include ais_json.c
gcc -o bits.os -c -g -O2 -fstack-protector-strong -Wformat 
-Werror=format-security -Wextra -Wall -Wno-uninitialized 
-Wno-missing-field-initializers -Wcast-align -Wmissing-declarations 
-Wmissing-prototypes -Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread 
-Wmissing-declarations -O2 -pthread -fPIC -D_FORTIFY_SOURCE=2 
-I/usr/include/dbus-1.0 -I/usr/lib/i386-gnu/dbus-1.0/include bits.c
clock_gettime.c:13:24: fatal error: mach/clock.h: No such file or directory
compilation terminated.
scons: *** [clock_gettime.os] Error 1
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

Full build log:
https://buildd.debian.org/status/fetch.php?pkg=gpsd&arch=hurd-i386&ver=3.15-1&stamp=1442789711

This happens because upstream uses the __MACH__ macro to determine if
it's a Darwin system. However, __MACH__ is defined on Hurd, too. Using
the __APPLE__ macro instead should do the trick.


I tested the attached patch and its enough to have gpsd build again on
hurd-i386.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
Description: Fix FTBFS on hurd by correctly checking for __APPLE__ instead of 
__MACH__
Author: Mattia Rizzolo <[email protected]>
Last-Update: 2016-04-19
Forwarded: no

--- a/clock_gettime.c
+++ b/clock_gettime.c
@@ -9,7 +9,7 @@
 
 #include "compiler.h"
 
-#ifdef __MACH__
+#ifdef __APPLE__
 #include <mach/clock.h>
 #include <mach/mach.h>
 #endif

Attachment: signature.asc
Description: PGP signature

Reply via email to