Thanks Guillem & Benjamin for your input on this ! On Sat, May 28, 2016 at 12:43:21PM +0200, Guillem Jover wrote: > On Tue, 2015-10-27 at 16:27:24 +0100, Benjamin Drung wrote: > > > To make it easier to patch Makefile.am after applying patches [1], > > please run autoreconf when building collectd. > > It seems part of this got fixed when fixing #823012, but it still > needs some minor changes, otherwise this fails when doing a second > build in a row. Attached the needed change to solves this.
I must admit I was initially a bit reluctant to run autoreconf: I ran into numerous problems when doing this while setting up the CI pipeline at https://ci.collectd.org/. Admittedly mostly when combining ancient autoconf versions from legacy distros with the latest collectd code. But as there doesn't seem to be any reason to hold this back for the combination of recent autoconf & collectd versions, I suggest running autoreconf for the stable/testing/unstable lines, but disabling it for the backports (+ other non-debian lines such as the nightly builds). Unless Tokkee has any comments on this, I'll prepare a 5.5.1-4 release shortly including Guillem's patch. Thanks ! Marc
signature.asc
Description: PGP signature
