Hello, On Mon, May 30, 2016 at 11:06:32AM +0200, Marc Fournier wrote: > On Sat, May 28, 2016 at 12:43:21PM +0200, Guillem Jover wrote: > > On Tue, 2015-10-27 at 16:27:24 +0100, Benjamin Drung wrote: > > > > > To make it easier to patch Makefile.am after applying patches [1], > > > please run autoreconf when building collectd. > > > > It seems part of this got fixed when fixing #823012, but it still > > needs some minor changes, otherwise this fails when doing a second > > build in a row. Attached the needed change to solves this. > > I must admit I was initially a bit reluctant to run autoreconf: I ran into > numerous problems when doing this while setting up the CI pipeline at > https://ci.collectd.org/. Admittedly mostly when combining ancient autoconf > versions from legacy distros with the latest collectd code.
So unfortunately your patch introduces one of these issues: dh_autoreconf is now run only if "configure" is not found, but as we're patching "configure.ac", running autoreconf is mandatory. What happens then is that it triggers automake by itself, which fails if there's a version mismatch with the version used to generate the orig tarball (collectd 5.5.1 was released using 1.14, sid currently comes with 1.15). I have only little time for this this week, so I'm going to upload 5.5.1-4 without your patch (to fix a lintian error I introduced in -3) in a couple of minutes. Let me know if you come up with a patch solving this problem, else I'll take a look at this again in a few days. Thanks ! Marc
signature.asc
Description: PGP signature
