Heh, yes. :) - Josh Triplett
On Sat, Jul 09, 2016 at 05:53:35AM +0000, Craig Small wrote: > I messed up the manual patch when it wouldn't apply. I put the return > before the attrset() That'll do it! > > - Craig > > > On Sat, Jul 9, 2016 at 3:38 PM Craig Small <[email protected]> wrote: > > > there seems to be a problem, watch is now not interpreting any ansi > > sequences. > > im bisecting it now to work out what went wrong, one of the patches didnt > > apply cleanly so i suspect that one. > > > > > > On Sat, Jul 9, 2016 at 3:12 PM Josh Triplett <[email protected]> > > wrote: > > > >> On Sat, Jul 09, 2016 at 04:59:07AM +0000, Craig Small wrote: > >> > Hi Josh, > >> > Thanks for looking into this, I only do some simple use of watch so > >> don't > >> > see the problems. I agree, if it doesn't understand something then stop > >> > messing around and drop out. > >> > > >> > Patch 0001 was already fixed upstream commit 6fcb6900 has a similar fix > >> > The other three patches have been applied upstream. > >> > >> Thanks! > >> > >> It looks like the handling for \e[m still has a bug in it, as it has a > >> condition for that both before and after the loop. The one after the > >> loop looks wrong; I think the one before the loop is the only one that > >> makes sense. > >> > >> - Josh Triplett > >> > >
