Package: solaar-gnome3
Version: 0.9.2+dfsg-6
Severity: normal

Hi,

Could you please drop the dependency against gnome-icon-theme?
gnome-icon-theme is deprecated in favor of adwaita-icon-theme.

I'm not sure that the package should have an explicit dependency against
adwaita-icon-theme either as libgtk3 is dependending against it already.

Also I see in the code that it probes different icon themes to see which
one is available:

_has_gpm_icons = _default_theme.has_icon('gpm-battery-020-charging')
_has_oxygen_icons = _default_theme.has_icon('battery-charging-caution') and \
                                        
_default_theme.has_icon('battery-charging-040')
_has_gnome_icons = _default_theme.has_icon('battery-caution-charging') and \
                                        
_default_theme.has_icon('battery-full-charged')
_has_elementary_icons = _default_theme.has_icon('battery-020-charging')

if _log.isEnabledFor(_DEBUG):
        _log.debug("detected icon sets: gpm %s, oxygen %s, gnome %s, elementary 
%s",
                                        _has_gpm_icons, _has_oxygen_icons, 
_has_gnome_icons, _has_elementary_icons)
if (not _has_gpm_icons and not _has_oxygen_icons and
        not _has_gnome_icons and not _has_elementary_icons):
        _log.warning("failed to detect a known icon set")


So I would drop the dependency altogether.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages solaar-gnome3 depends on:
ii  gir1.2-appindicator3-0.1  0.4.92-4
ii  gnome-icon-theme          3.12.0-2
ii  gnome-shell               3.20.3-1
ii  solaar                    0.9.2+dfsg-6

solaar-gnome3 recommends no packages.

solaar-gnome3 suggests no packages.

-- no debconf information

Reply via email to