On Thu, 14 Jul 2016 14:59:49 -0400, Lizhou Sha wrote: > Hi Gregor,
Hi Lizhou, and thanks again for your help! > Indeed, socket activation would be nice. However, from my latest > testing, the current packaged version of iodined has some bug wrt > IPv6. Namely, systemd sockets are IPv6 by default, and on an IPv4-only > system, iodined will still think that the socket is IPv6. The upstream > master seems to have fixed it in this commit, by forcing the use of > separate IPv4 and IPv6 sockets: > https://github.com/yarrick/iodine/commit/4987aa536db069c9f687c2c85b325fc49756a0f2 > > In addition, there seems to be another bug that is not fixed upstream > that causes iodined to exit too quickly with the -i argument. From > empirical observation, I don't think they are counting the idle time > correctly. While it should be safe to pull in the upstream changes > that makes socket activation technically possible, I think it's best > for the Debian package to use traditional start-on-boot for now, and > address socket activation in another update. Ok, this makes sense, thanks for taking the time to explain this in detail. > I have also discovered that my patch is insufficient in a few ways. > The updated files are attached. > > 1. I forgot to include the chroot parameter. The chroot directory is > created with a tmpfile (see tmpfiles.d(5)). Since the original init > script seems to create the chroot directory with 0755 root:root > permission, I have replicated that in the tmpfile. > 2. I've tweaked the service file so that it won't start until > systemd-tmpfile has done its magic. > 3. I have not included a iodined.socket file because the upstream > example iodine-server.socket should just work, when the time comes to > enable socket activation for this Debian package. > > Finally, I should note that the package needs to build depend on > dh-systemd, which should take care of installing the iodined.service > and iodined.tmpfile files automatically when they're placed in the > debian/ directory. Excellent! I've included the files and made sure that they get installed. The only change I made was to add a Documentation key to the service file, as advised by lintian. [0] I've uploaded 0.7.0-5 to unstable right now. Thanks again, gregor [0] http://git.toastfreeware.priv.at/debian/iodine.git/commitdiff/cb868cd -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Pink Floyd: Sorrow
signature.asc
Description: Digital Signature
